Current master post 4.2.0

[DavidMedley]

Remove/Satisfy Hunger doesn't have to go to exactly 50%, either. It always seemed low to me. Especially with the crazy calorie burning druid regen spell.

[Nick]

Sounds good to me.

Question about the behavior upon reading an unknown scroll. Didn't it used to say "You see no more Scrolls titled IDENTIFIED" rather than what it does now, "You see no more Scrolls titled GOBLYGOOK"?

I think that's a side-effect of the fix to Rune of Protection. I'll have a look.

[Sky]

i too for having little played 4.2.0, find that the current food system is not-well-balanced but ultimately better.
Getting too full helps prevent the spamming of CCW (or, even ?Phase and CLW), however, i think that the gorged penalty should work like so:

1. food and other will top up your hunger meter for a certain amount up to 100%. You cannot gorge on food (if you are at 80% and eat a ration, you go to 100% - obviously IRL you would be in control how much food you eat)
2. the next step requires a soft cap. This means that it takes longer for the hunger meter to go from 100% to 99% than it does from 99% to 98%. In other words, conventional food and scrolls cap you at 100%.
3. drinking potions can put you over 100%; at this point you become gorged, severely gorged, sick, and catatonic. -2, -4, -6, -10. The higher you go over 100%, the longer it takes to come down.

The reasoning here is that you can eat normally until you are sated. Once you are sated, if you force to eat more because you need the HP, you are then punishing yourself with the excessive food, and get into the speed (and why not, combat as well) penalties.

i think this is the best solution and if you disagree you are a dumb poopityhead.

source: am a fatass.



EDIT: obviously Trolls should have a massive advantage here with the hunger meter being shifted up to 150% max cap.

[backwardsEric]

Question about the behavior upon reading an unknown scroll. Didn't it used to say "You see no more Scrolls titled IDENTIFIED" rather than what it does now, "You see no more Scrolls titled GOBLYGOOK"?

Yes, as Nick suspected it's a side-effect of fix for Rune of Protection: a scroll or potion is removed before computing the effect and learning what the item does.
With the change, the charge from a wand or staff is also deducted before use which means that, for an unknown wand or staff, you won't get the message that was previously printed about the new number of charges.

Could tweak it so that stuff from the pack is handled the old way, but stuff from the floor is handled with special care since that's the case that triggers one of the reported problems with Rune of Protection.

[Nick]

With the change, the charge from a wand or staff is also deducted before use which means that, for an unknown wand or staff, you won't get the message that was previously printed about the new number of charges.

Could tweak it so that stuff from the pack is handled the old way, but stuff from the floor is handled with special care since that's the case that triggers one of the reported problems with Rune of Protection.

The charges message does still happen, as it is coded following knowledge update.

I think the easiest fix for things that are consumed is to call *_object_for_use() with no message, and then print a specific message in use_aux() after knowledge is updated.

[mrfy]

Not just unidentified scrolls, but reading an already identified scroll on the floor gives this:

You see no more scrolls titled "inventum" of Enchant Weapon To-Hit.

It then lets you select the weapon. Canceling the action then says:

You feel something roll beneath your feet.

So you pick it up to read it but then drop it again? I guess that makes sense. Does it also take a turn of time to read but then drop?

[backwardsEric]

Not just unidentified scrolls, but reading an already identified scroll on the floor gives this:

You see no more scrolls titled "inventum" of Enchant Weapon To-Hit.

It then lets you select the weapon. Canceling the action then says:

You feel something roll beneath your feet.

So you pick it up to read it but then drop it again? I guess that makes sense. Does it also take a turn of time to read but then drop?

While the messages changed for that case, the time taken should not. Both the old version and the new one don't take a turn if the item is not used and no knowledge was gained. If the enchant weapon scroll was not identified when you read it and canceled the action, it would take a turn of time in the new and old versions.

[DavidMedley]

While the messages changed for that case, the time taken should not. Both the old version and the new one don't take a turn if the item is not used and no knowledge was gained. If the enchant weapon scroll was not identified when you read it and canceled the action, it would take a turn of time in the new and old versions.

I can confirm this from "nightly" play on Angband.live about 12 hours ago.

[Nick]

Could tweak it so that stuff from the pack is handled the old way, but stuff from the floor is handled with special care since that's the case that triggers one of the reported problems with Rune of Protection.

I now have this (I believe) completely fixed in development. The solution was to revert the previous fix, and then take out the call to push_object() in effect_handler_GLYPH (in the case of a scroll being used), which was unnecessary because it was done at the end of use_aux() anyway.

[Sphara]

Staff of Power worked outside LOS. I don't know how many squares its radius was from me but: I was in a very very long corridor when I started emptying Staff of Power charges at an approaching night mare. It was the only monster in the screen (Telepathy included) but I also got "it barely notices" or "it shudders" messages. Finally Vecna appeared on the screen in that corridor from the distance 0 N 20 W and he was missing one health star.

I have no idea if it is a bug so I don't report it.

EDIT: Oh, and I also found weird that Gilim (ice) and Nan (fire) do not have resistances for their flavor elements.

[backwardsEric]

I now have this (I believe) completely fixed in development. The solution was to revert the previous fix, and then take out the call to push_object() in effect_handler_GLYPH (in the case of a scroll being used), which was unnecessary because it was done at the end of use_aux() anyway.

Does it handle scrolls of teleport level read from the floor? If the level change happens in the effect handler and non-persistent levels are used, the object that represents the scroll no longer exists when the effect handler returns. Also, from the fix for #4131, pushing objects from use_aux() wasn't enough to always place the glyph of warding.

[Nick]

Staff of Power worked outside LOS. I don't know how many squares its radius was from me but: I was in a very very long corridor when I started emptying Staff of Power charges at an approaching night mare. It was the only monster in the screen (Telepathy included) but I also got "it barely notices" or "it shudders" messages. Finally Vecna appeared on the screen in that corridor from the distance 0 N 20 W and he was missing one health star.

I have no idea if it is a bug so I don't report it.

I think this is probably OK.

EDIT: Oh, and I also found weird that Gilim (ice) and Nan (fire) do not have resistances for their flavor elements.

I'm going to call this one a bug, though.

Does it handle scrolls of teleport level read from the floor? If the level change happens in the effect handler and non-persistent levels are used, the object that represents the scroll no longer exists when the effect handler returns. Also, from the fix for #4131, pushing objects from use_aux() wasn't enough to always place the glyph of warding.

I'm not sure - I'll test those.

EDIT: Teleport level is fine, but it does bring back #4131. My feeling is that our difficulties here indicate an underlying problem of how the code is approaching this; let me think about it for a bit.

[matronboy]

Hello, sorry if this is in the wrong place or has been asked before, I tried to use the search function best i could to check!

I'm trying to play through Terminal on my Mac using the version downloaded with Homebrew, but I'm crashing and getting a message after the title screen saying: "angband: Broken savefile - probably from a development version"

I've tried deleting and reinstalling and stuff like that but to no avail! Wondered if there was an easy fix for this? The download version works fine, so it's no bother, I just like having it all neat and tidy in my console.

Thanks in advance!

[fph]

Hello, sorry if this is in the wrong place or has been asked before, I tried to use the search function best i could to check!

I'm trying to play through Terminal on my Mac using the version downloaded with Homebrew, but I'm crashing and getting a message after the title screen saying: "angband: Broken savefile - probably from a development version"

I've tried deleting and reinstalling and stuff like that but to no avail! Wondered if there was an easy fix for this? The download version works fine, so it's no bother, I just like having it all neat and tidy in my console.

Thanks in advance!

Savefiles on Mac are in Documents/Angband/, I believe (or maybe Library/Preferences/Angband/save ? I never had a mac, so I'm just reading this stuff up). Probably you have a leftover one from a previous install.

Savefiles are the files that hold your current characters. They are usually named with your username, without extension, and their content begins with the characters "SaveVNLA" (you can use "head filename -c 8" from the command line to display the first 8 characters of a file's content). They are usually not compatible along different major versions.

It is not clear to me from your description what you are trying to do. Anyway:

1. If you had an active game saved with a previous version and wish to finish playing that character, you will need to reinstall the old version you were using.

2. If you wish to play different characters with two different Angband versions at the same time, you will need to tell them to load different savefiles with the command-line option "-u <savefile>" when running Angband.

3. Otherwise, if you only wish to play the new version, just delete the old savefile and a new one will be created.

[Nick]

Does it handle scrolls of teleport level read from the floor? If the level change happens in the effect handler and non-persistent levels are used, the object that represents the scroll no longer exists when the effect handler returns. Also, from the fix for #4131, pushing objects from use_aux() wasn't enough to always place the glyph of warding.

OK, I think I finally have a fix for this; it is incredibly ugly, but seems to work in every situation so far. If it survives further testing, it should get pushed in the next couple of days.