Current master post 4.2.0

[DavidMedley]

What are the current plans for the next release? ETA, will it be 4.2.1 or 4.3, anything that needs to be in it that's not in yet, etc.

[Nick]

Playing the nightly (4.2.0 may be the same) and there was a spear under webs. I couldn't find any indication it was there except for the object window and moving over it. Seems like if it's hidden from sight it should be hidden from the object window, or if it's visible in the object window it should be visible on screen or at least to the look command. Or possibly I remembered it was there from before the webs covered it, but I still feel the same principle should apply.

Yes, this is actually kind of tricky, I'm not sure of the best solution.

As for next release - once the nightlies are bug free is the general idea. With the new blackguards I wanted a little time for bugs to emerge and minor changes to be made too. Bugs are down under 20 now, so I think around a month is possible - but it could be longer, or theoretically shorter. And it will be 4.2.1 - the general idea being that 4.2 was a major change, and the 4.2.x series is essentially improvements on that, and maintains savefile compatibility.

[DavidMedley]

Sounds good. Thanks for the update.

[Diego Gonzalez]

Perhaps this is a problem of the android port but I'll report a possible bug here, just in case.

When inspecting Google's Play Console I see that there are several crashes in findpath, from anonymous users.

After trying to dissect the ndk coredump, the ndk-stack tool points me to this line:

pf_result[pf_result_index++] = '0' + (char)(10 - dir);

The code doesn't check for array overflow. This is a bug in Vanilla ?

I'll try to reproduce the bug.

[Nick]

Perhaps this is a problem of the android port but I'll report a possible bug here, just in case.

When inspecting Google's Play Console I see that there are several crashes in findpath, from anonymous users.

After trying to dissect the ndk coredump, the ndk-stack tool points me to this line:

pf_result[pf_result_index++] = '0' + (char)(10 - dir);

The code doesn't check for array overflow. This is a bug in Vanilla ?

I'll try to reproduce the bug.

A bug in this code would not surprise me at all. I'll do a check too.

EDIT: OK, one massive bug found here already. I'm rewriting the whole thing.

[mrfy]

Getting a crash with latest nightly, load save file, hit '/', 'E', 'y', 'space'. Crash.

savefile:

https://www.dropbox.com/s/dwhko5lkpam3476/mrfy?dl=0

randart file:

https://www.dropbox.com/s/5xgg2d5flzmh807/randart.log?dl=0

Hope this is enough.

[Nick]

Getting a crash with latest nightly, load save file, hit '/', 'E', 'y', 'space'. Crash.

savefile:

https://www.dropbox.com/s/dwhko5lkpam3476/mrfy?dl=0

randart file:

https://www.dropbox.com/s/5xgg2d5flzmh807/randart.log?dl=0

Hope this is enough.

Sorry, what you've given is the randart log file. I need either:

• A file in your user directory (the same one your randart.log was in) called randart.txt or
• A file in the archive directory inside your user directory, called randart_0ff02d87.txt

[Diego Gonzalez]

The Quake spell of the BG destroys the town and leaves the dungeon intact... Sorry, but its funny!

The logic is reversed. effect_handler_EARTHQUAKE

[mrfy]

Sorry, what you've given is the randart log file. I need either:

• A file in your user directory (the same one your randart.log was in) called randart.txt or
• A file in the archive directory inside your user directory, called randart_0ff02d87.txt

Sorry. It's still happening in my game so lets try again.

https://www.dropbox.com/s/jww4it6j8mn77sl/mrfy?dl=0

https://www.dropbox.com/s/jvksruw44o8vnrb/randart_0ff02d87.txt?dl=0

[mrfy]

Shopkeeper just said to me: "Look at the food bar at the bottom of the screen to see how well fed you are."

Food bar? Is that a tiles thing? Or is it some buffet mode added to the game I haven't discovered.

[Diego Gonzalez]

Update of the findpath bug. Could reproduce the bug a couple of times.



It seems that the ox variable is overwritten by a buffer overflow, or something strange.

[Nick]

Sorry. It's still happening in my game so lets try again.

https://www.dropbox.com/s/jww4it6j8mn77sl/mrfy?dl=0

https://www.dropbox.com/s/jvksruw44o...02d87.txt?dl=0

OK, the problem doesn't happen for me. It could possibly be an issue with your lore.txt file, but that seems unlikely.

More likely is that some of the code in the symbol query function is dubious; I'm going to rewrite that a bit and we'll see if the next update fixes the problem.

[Nick]

Shopkeeper just said to me: "Look at the food bar at the bottom of the screen to see how well fed you are."

Food bar? Is that a tiles thing? Or is it some buffet mode added to the game I haven't discovered.

Well, it's really a food indicator, but that makes the hint too long; I was thinking of bar as in progress bar. How does "The food indicator at the bottom of the screen shows how well fed you are." sound?

[Nick]

Update of the findpath bug. Could reproduce the bug a couple of times.



It seems that the ox variable is overwritten by a buffer overflow, or something strange.

Well, I've done a complete rewrite of the pathfinding function so it is much more efficient, and I think I have done sufficient bounds checking on the path array. Run behaviour is still a bit odd, so I'm going to have a look at fixing that too, and this should be in an update that I'll push later today.

[DavidMedley]

The Quake spell of the BG destroys the town and leaves the dungeon intact... Sorry, but its funny!

The logic is reversed. effect_handler_EARTHQUAKE

Confirmed. Probably introduced in the merge.