Angband 4.2.1

[PowerWyrm]

In critical_melee():

int chance = weight + (p->state.to_h + plus + debuff_to_hit) * 5 + (p->state.skills[SKILL_TO_HIT_MELEE] - 60);

In calculate_melee_crits():

int k, to_crit = weight + 5 * (state->to_h + plus) + [B][COLOR="Red"]3[/COLOR][/B] * state->skills[SKILL_TO_HIT_MELEE] - 60;

Second line kept the factor of 3 that was removed from the first line.

[DavidMedley]

I don't know if it's just the power of suggestion, but now I do seem to remember something weird like that happening to me... used a scroll of teleport from the floor and it didn't ID. I guess that's not a very helpful report...

[luneya]

Like a rod of recall?

Recall or deep descent wouldn't actually trigger this problem because they trigger a status effect immediately, and the effect removes the player from the level after several turns. The identity is learned as soon as the status effect is gained, at which point the rod/staff/wand is still present.

An object of teleport level would be a problem if such existed. We probably should also test if there is a problem using unknown staves of teleport from the floor, as the staff would no longer be visible to the player after teleporting.

[Nick]

For the current item set, I think that's fine. If you want to allow the possibility of things like rods or staffs of deep descent or teleport level (something where the item's effect would leave the original object inaccessible after use from the floor), then using a temporary object for the bookkeeping after the effect seems necessary.

OK, good thinking.

[DavidMedley]

Like a rod of recall?

[backwardsEric]

OK, I'm pretty sure this is actually the problem. Looking at that code, it seems to me that there is only need to use a work object for single use items, so that code for multi-use items could just be removed - do you agree?

For the current item set, I think that's fine. If you want to allow the possibility of things like rods or staffs of deep descent or teleport level (something where the item's effect would leave the original object inaccessible after use from the floor), then using a temporary object for the bookkeeping after the effect seems necessary.

[spara]

@ has been blinded and tries to look at objects formerly left behind. They all basically give the same "You see an open floor..." message. They can be seen in the "You are aware of ... objects" term-window though. @ should probably be able to use the look command to check the objects they are aware of even though being blinded.



Save: look.zip

[Nick]

There was a change to avoid problems when reading a rune of protection scroll from the floor. As a direct result of that or the subsequent fixes to clean up extra messages from that change, a problem with propagating knowledge about single-use items was introduced which Nick fixed. All those changes were in a routine that's called for all item use. So, they could be related to this bug about not learning the properties of a rod after using it.

OK, I'm pretty sure this is actually the problem. Looking at that code, it seems to me that there is only need to use a work object for single use items, so that code for multi-use items could just be removed - do you agree?

[spara]

Found another unknown rod. Zapped from the ground and it revealed itself to be Rod of Polymorph. Again missing details in description. I guess the problem is in the identification of (rods?) from the ground.

[DavidMedley]

Matching items
Command: =af

[moosferatu]

There is a user interface option to prevent this.

Do you mean disable auto-pickup matching items or charges being averaged across devices? I like auto-pickup most of the time. I'm not seeing a setting for the latter.

[DavidMedley]

I picked up a staff of speed with 6 charges. It was the only one I had in my inventory. Then I accidentally stepped on a staff of speed with 0 charges that I'd previously discarded. I immediately attempted to discard it again only to discover to my dismay that now I had 2 staves each with 3 charges.

I'm guessing this behaviour is not a bug, but it sure is annoying...

There is a user interface option to prevent this.

[moosferatu]

I picked up a staff of speed with 6 charges. It was the only one I had in my inventory. Then I accidentally stepped on a staff of speed with 0 charges that I'd previously discarded. I immediately attempted to discard it again only to discover to my dismay that now I had 2 staves each with 3 charges.

I'm guessing this behaviour is not a bug, but it sure is annoying...

[spara]

There was a change to avoid problems when reading a rune of protection scroll from the floor. As a direct result of that or the subsequent fixes to clean up extra messages from that change, a problem with propagating knowledge about single-use items was introduced which Nick fixed. All those changes were in a routine that's called for all item use. So, they could be related to this bug about not learning the properties of a rod after using it.

Now that you bring it up. It's totally possible that I used the rod first time from the floor. Can't really remember

Edit: Confirmed from the message recall from the save. The rod was identified from the ground, since @ had a full backpack.

[backwardsEric]

I vaguely recall a recent issue several nightlies ago, when the description only updated when @ left the level. Does that ring any bells?

There was a change to avoid problems when reading a rune of protection scroll from the floor. As a direct result of that or the subsequent fixes to clean up extra messages from that change, a problem with propagating knowledge about single-use items was introduced which Nick fixed. All those changes were in a routine that's called for all item use. So, they could be related to this bug about not learning the properties of a rod after using it.