Current master post-4.1.3

[MattB]

Starting with zero gold and zero stuff is perfectly viable as a warrior.
As a mage...less so.

[wobbly]

You assume the form of a bat
You die

Might want to decide if losing hps to shapeshifting should be able to kill a character & if so whether it should be warning you first.

[Nick]

You assume the form of a bat
You die

Might want to decide if losing hps to shapeshifting should be able to kill a character & if so whether it should be warning you first.

You've been warned

[Thraalbee]

artifact.txt | object_base.txt | object.txt mismatch

In the version I am looking at, armour spelling is both the UK and the US way
artifact.txt sample
name:'Hithlomir'
base-object:soft armour:Soft Leather Armour
...

object_base.txt sample
name:soft armor:Soft Armor~
graphics:slate
...

object.txt also uses both versions.


Not sure if it has any impact in the code or not, but I still recommend using just one of these consistently.

[Thraalbee]

artifact.txt continued

Ok, so comments are not up to date. Below is a suggestion.

However, there is currently a variance in placement of "values:" lines which makes it harder to parse with regexp. Usually it comes after flags:, but also in some occasions after time: or msg:
Again, probably not a problem for the game today but I'd like to see consistency to simplify coming work on artifacts.

# name: name without object name
# base-object: tval : sval
# graphics: symbol : color
# info: level : weight : cost
# alloc: allocation probability : min depth : max depth
# power: base armor class : base damage : plus to-hit : plus to-dam : plus to-ac
# flags: flag | flag | etc
# values: label[value] | label[value] | etc
# brand: brand info
# slay: slay info
# act: activation
# time: recharge time
# msg: message when activated
# desc: description

[Nick]

There has been a deliberate policy for a while to allow both armor and armour, because development has been pretty evenly split between users of the two different spellings. It is accounted for in the code:

/**
 * Small hack to allow both spellings of armer
 */
char *de_armour(const char *name)
{
	char newname[40];
	char *armour;

	my_strcpy(newname, name, sizeof(newname));
	armour = strstr(newname, "armour");
	if (armour)
		my_strcpy(armour + 4, "r", 2);

	return string_make(newname);
}

Standardising the order of lines in artifact.txt (and actually all the data files is a good idea - I'll get to it some time.

[takkaria]

Why don't you just split the whole file into chunks based on a double-newline and then within each one run a 'match all' for each regex? Then you're not reliant on a particular line order, which is not guaranteed.

[Thraalbee]

I did that in the previous version. But I code to learn/practise. wanted to learn using more complex regexp this time. But after adding room for comments and mutiple locations of some strings it has become silly in terms of efficiency although it works for artifacts too now

[Derakon]

Regular expressions are one of those "just because you can, doesn't mean you should" kinds of things. Often a complicated regex is better-represented as a few string splitting operations and a simple regex or two.

I guess what I'm saying is, part of practicing is knowing when to stop!

[Grotug]

I recharge a staff of detect evil and it goes from 1 charge to 4 charges. I guess warriors should have limited magic, so maybe I shouldn't complain about this. But I assume this scroll is as lousy for warriors as it is everyone else.

[MattB]

As a rogue, I just recharged a staff of summoning and it went from 1 charge to 34 charges... none of which appear to do anything...


(feature branch, btw)

[Nick]

New builds are now up on the nightlies page, incorporating:

• A new font, 16x16xw.fon, for use in Windows, SDL or SDL2 (thanks to Mikolaj)
• Documentation for adding tilesets (thanks to wkmanire)
• Some macOS bugfixes (thanks to elly)
• The feature/monster branch.

So with the (major) monster changes now incorporated, I will be focusing on master from now on, probably starting off with some bugfixes.

[Ingwe Ingweron]

Another awesome accomplishment, Nick. Thank you for the great work you do.

One extremely minor bug (spelling) slipped through, the description of Old Man Willow's "...may long-fingered hands...".

[Youssarian]

I have a question on the spell books for the new jobs. I am trying to play a mage and can buy a Book of Magic Spells [practical spells] which is the same color as my mage class books. However I cannot browse it or look at it in any other way.

Is this intentional somehow? Or is magic still a work in progress? It also only costs 25 gp in the store which is the same price as the starter book which I start with in my inventory.

Also, the chance for failure for the beginner Necromancer spells seems really high.

[wobbly]

I have a question on the spell books for the new jobs. I am trying to play a mage and can buy a Book of Magic Spells [practical spells] which is the same color as my mage class books. However I cannot browse it or look at it in any other way.

It's the rogue spell book. This comes up a lot & I think should be made a little more obvious in some way.

Also, the chance for failure for the beginner Necromancer spells seems really high.

Necromancers get a penalty standing in the light but don't need a torch to see. This could probably also be clearer.