Issues on current master

[Nick]

Sorry, I mean in buying from shops: so unseen !gainstat are going for 60 from the black market, unseen !CCW for 20 each (until you buy 1) from the temple, etc.

Ah, OK - that wasn't intended. Thanks for the report.

[Byzantium]

Yes, this is how it traditionally was; getting a reasonable price for unidentified stuff was a temporary artefact of some other changes, which I finally got around to fixing.

Sorry, I mean in buying from shops: so unseen !gainstat are going for 60 from the black market, unseen !CCW for 20 each (until you buy 1) from the temple, etc.

[Nick]

In the most recent nightly (f643be9), store pricing for unseen consumables seems to be setting all of them to a base value based upon object type: all unseen potions cost 20, wands 50 etc., updating to normal values once @ has seen them.

Yes, this is how it traditionally was; getting a reasonable price for unidentified stuff was a temporary artefact of some other changes, which I finally got around to fixing.

[Byzantium]

In the most recent nightly (f643be9), store pricing for unseen consumables seems to be setting all of them to a base value based upon object type: all unseen potions cost 20, wands 50 etc., updating to normal values once @ has seen them.

[wobbly]

If we're talking about inscriptions how hard would it be to allow inscribing devices to letters like is possible in some variants. For example I like my ?phase @rp, ?teleport @rt, _teleport @ut & my devices inscribed around the a & z keys. This doesn't seem to work in vanilla.

[MITZE]

Minor bug with inscriptions and praying

Even though you can start the praying process with 'p', trying to use 'p' in an inscription (@p1, ect.) doesn't work; inscriptions only allow for 'm' when trying to cast/pray a spell/prayer.

(Yeah, I know I can just use 'm' in inscriptions, but it bugs me that 'p' is a valid command and yet is not valid for inscription usage.)

[Nick]

The code that generalized damage from terrain has not been ported to effect_handler_THRUST_AWAY() when the player is thrown into molten lava... resulting in the player taking double damage in that case (from the effect + when player is processed).

Thanks - I had just noticed lava damage for monsters from THRUST_AWAY, but hadn't put it together that the player was getting it too. I'm half inclined to leave it that monsters get hurt on entry and again every turn

[PowerWyrm]

The code that generalized damage from terrain has not been ported to effect_handler_THRUST_AWAY() when the player is thrown into molten lava... resulting in the player taking double damage in that case (from the effect + when player is processed).

[Pete Mack]

Invisible PASS_WALL monsters are suddenly much less threat: they show up as a dark patch on the wall.

[Pete Mack]

Bummer. Some change in the last several weeks affected save file compatibility. Beware, if you pull git changes rarely!

[Ingwe Ingweron]

erpderp?!?

i cannot open doors automatically??

This bug came in the latest nightly, and also affects automatic disarming of traps. Nick is working on a fix. See the other 4.1 bug thread.

[Sky]

erpderp?!?

i cannot open doors automatically??

[Nick]

Commit 8e3e6b2, some code checking if the rune is known has been moved at the end of display_resistance_panel():

bool rune = false;

(old code setting the "rune" boolean removed)

...
else if ((j < player->body.count) && slot_object(player, j) &&
!known && ![COLOR="Red"][B]rune[/B][/COLOR])
...

/* Check if the rune is known */
(new code that doesn't use the "rune" boolean)

So for that check "rune" is always false.

Nice catch - rune needed to be set, so I've put back the code that does that.

[PowerWyrm]

Commit 8e3e6b2, some code checking if the rune is known has been moved at the end of display_resistance_panel():

bool rune = false;

(old code setting the "rune" boolean removed)

...
else if ((j < player->body.count) && slot_object(player, j) &&
!known && ![COLOR="Red"][B]rune[/B][/COLOR])
...

/* Check if the rune is known */
(new code that doesn't use the "rune" boolean)

So for that check "rune" is always false.

[Nick]

EDIT: NO. Randart seed is 131295932. build was g535565d from the 9th.

Yeah, the fix was done after that build.