[Announce] PosChengband 1.0.0

[chris]

I haven't look at the actual code yet, but there seems to be overflow when displaying negative numbers in the stat display (both for EXP and HP).

Even if it may work in practice, "%d" is not guaranteed to work for int32_t, only "int". You need to use

[code]
printf(PRId32, foo);
[code]

to be compliant with the standard.

Agreed. I was just pointing out that using "%ld" on an known 32 bit int was unnecessary for 32 bit compiles and that the current printf code will work for both compiles, while is obviously bound to break in the future, and is also obviously not the ideal solution.

I'm not sure about the XP, HP issue. Can you post a screen dump? The code is not using printf for these fields, but rather Angband's hand-coded printf substitute: format.

[AnonymousHero]

But isn't this incorrect?

    int32_t foo = 123;
    printf("%d", foo);

works just fine for both 32 bit and 64 bit compiles. Or am I missing something?

I haven't look at the actual code yet, but there seems to be overflow when displaying negative numbers in the stat display (both for EXP and HP).

Even if it may work in practice, "%d" is not guaranteed to work for int32_t, only "int". You need to use

[code]
printf(PRId32, foo);
[code]

to be compliant with the standard.

[chris]

Yeah, this is really an annoying part of the C89 standard printf(). The only really portable way to get this working properly (without always casting) on 32 and 64 bit is to use format string defines, so something like:

#ifdef ON_64_BIT_PLATFORM
#define FMTs32 "%d"
#define FMTu32 "%u"
#else
#define FMTs32 "%ld"
#define FMTu32 "%lu"
#endif

and then use them as follows:

     int32_t foo = 123;
     printf("something " FMTs32 " something something.", x);

(note that int32_t is also C99.)

The only other way is simply using "int" everywhere, but that may not be sufficient on all compilers/platforms.

But isn't this incorrect?

    int32_t foo = 123;
    printf("%d", foo);

works just fine for both 32 bit and 64 bit compiles. Or am I missing something?

[AnonymousHero]

I've begun removing the Japanese support since, as you noticed, it really messes up the code base.

Also, I did roll thru the code base replacing %ld with %d when used with 32 bit variables. When using %ld with longs, I changed it to %d with ints. Clearly the code was old enough that it was written at a time when ints where 16-bits so that a 32-bit variable required %ld. Now ints are 32-bits and %ld requires a 64-bit variable for 64-bit compiles. If you find things that are incorrect in the 1.0.5 codebase, can you let me know? Thanks.

There are definitely issues with format strings. (The basic issue is essentially impossible to fix without the use of format string macros if you want to be able to compile on both 32-bit and 64-bit.)

Do you have a repository (git, hg, whatever) somewhere which we can submit patches against?

[chris]

I was contemplating patching some of the printf/64bit-related stuff and noticed that there's a lot of "#ifdef JP" preprocessor stuff which complicates things... @Chris: Are you actually intending to support JP or would it be OK to just remove it?

I've begun removing the Japanese support since, as you noticed, it really messes up the code base.

Also, I did roll thru the code base replacing %ld with %d when used with 32 bit variables. When using %ld with longs, I changed it to %d with ints. Clearly the code was old enough that it was written at a time when ints where 16-bits so that a 32-bit variable required %ld. Now ints are 32-bits and %ld requires a 64-bit variable for 64-bit compiles. If you find things that are incorrect in the 1.0.5 codebase, can you let me know? Thanks.

[AnonymousHero]

I was contemplating patching some of the printf/64bit-related stuff and noticed that there's a lot of "#ifdef JP" preprocessor stuff which complicates things... @Chris: Are you actually intending to support JP or would it be OK to just remove it?

[Darin]

I downloaded and compiled and it works fine now. Thanks!

[chris]

I just downloaded the source for 1.0.5, and mystic.c seems to be missing.

Oops .. I uploaded a new poscheng-105-src.zip file that includes mystic.c. It has the same file name so hopefully your browser cache does not get confused.

I also booted into linux and checked a compile. Seems to work OK.

[Darin]

I just downloaded the source for 1.0.5, and mystic.c seems to be missing.

[chris]

1.0.5 is available here

* Added new class: The Mystic. (Available under the Martial Arts birth option).
* Monks and Forcetrainers now get their correct number of blows.
* Monks and Forcetrainers now get the two-handed martial arts bonus.
* Maulers should be working now

[chris]

Hey Chris, just reporting a major bug here in my latest character, a club weaponmaster. Every weapon I wield is reported as "Just lifting" on the equipment screen, and as you can see in the dump, I get 1 blow per round with Totila at near-max strength, and max dex. I wonder if it had anything with me using combat expertise briefly or trade blows? Not sure what triggered it.

http://angband.oook.cz/ladder-show.php?id=13972

Yeah, I found that one as well. Restarting the game gives a temporary fix, but I guess I'll just push 1.0.4. I keep telling myself to wait until I clean up the help files ... someday.

So, you can get 1.0.4 here.

Some of the changes include:
* Munchkin personality is less of a munchkin
* Touch of Confusion no longer confuses a dead foe for innate attacks.
* Cunning Strike (Clubmaster) now always has a chance to stun.
* Knockback is now 2 sqaures for each hit (Polearm master).
* Fleet of Foot is marginally improved (Still not as good as Chengband, though).
* Monster races get permanent heroism after slaying their boss.
* Armageddon damage amounts dialed down for Inertia and Disintegration breaths.
* Kamikaze Warrior's weaponmastery now works.
* Invulnerability and Berserk Rage now give total immunity to fear.
* Weird Mind no longer lies in the player dump (i.e., you don't get resist confusion).
* Jellies are now invulnerable to hunger based attacks.
* Player is far less likely to be insta-knocked out by monster criticals (i.e., going from no stun status to knocked out from a single blow).
* New Demigod Talent: Black Marketeer.
* When choosing a demigod talent, there is now a browse feature. The descriptions should be accurate. You won't get any powers that aren't at least hinted at in the descriptions.
* Added a prompt for the store buyout option. You are only prompted if "Disturb Minor" is turned on, though.
* Demigod parentage descriptions should now be accurate. You won't get any powers that aren't at least hinted at in the descriptions.
* Ego items of Power Throwing now enhance Club Toss and Dagger Toss.
* Jellies can now get up to 7 blows. They get a more favorable multiplier for calculating number of blows since they cannot use two "hands" to wield weapons.
* Demigods always get their family artifact from slaying their parent.
* Fixed bug with wielding heavy weapons described above.

[kingvictory2003]

Hey Chris, just reporting a major bug here in my latest character, a club weaponmaster. Every weapon I wield is reported as "Just lifting" on the equipment screen, and as you can see in the dump, I get 1 blow per round with Totila at near-max strength, and max dex. I wonder if it had anything with me using combat expertise briefly or trade blows? Not sure what triggered it.

http://angband.oook.cz/ladder-show.php?id=13972

[chris]

How are the daily wanted monsters generated? I've had the same target ("horse") for several game days now.

Daily wanted monsters are chosen randomly based on the maximum dungeon level you have visited. They are chosen at midnight each day, which is skipped if you rest over night in the Inn, I think. Also, it is possible to choose the same monster as before, though I think this would be unlikely.

[Djabanete]

It's keyed to whatever films Chris has recently watched; in this case, The Godfather.

[Qyx]

No, but I can add a prompt for next release if desired. I assume you accidentally pressed 'b' and spent a bunch of gold?

Exactly. A couple of times... (one would think you'd only make that mistake once, but some of us don't really learn from our mistakes! And of course, I only made the mistake when I had huge amounts saved up as well!)

How are the daily wanted monsters generated? I've had the same target ("horse") for several game days now.