Blackguards: 4.2.0 to 4.2.1

[backwardsEric]

With the new changes for the blackguard, the clang compiler packaged with Xcode 11.3.1 complained about the local variable, target, in effect_handler_MOV_ATTACK() being uninitialized when the condition

(context->dir == DIR_TARGET) && target_okay()

is false. Should target be initialized to loc(0, 0) so function will cleanly bail out if the target is not appropriately set?

[Nick]

With the new changes for the blackguard, the clang compiler packaged with Xcode 11.3.1 complained about the local variable, target, in effect_handler_MOV_ATTACK() being uninitialized when the condition

(context->dir == DIR_TARGET) && target_okay()

is false. Should target be initialized to loc(0, 0) so function will cleanly bail out if the target is not appropriately set?

Yes, that one's fixed in development.

[wobbly]

Breeder scumming seems a little generous, though I can't see a way to fix that without a cutoff for weak enemies.

[Diego Gonzalez]

Wow! The new BG is great! I have one with clvl 25. It's pretty strong. I like the new mechanics and spells a lot. You did really a great job.

[DavidMedley]

I'm glad you like it! It's not a complete work, so please continue to give feedback.

[Diego Gonzalez]

Silly jokes:

-Mushrooms of Terror should be avoided for true BGs?

-Can a BG slap himself to get enough mana for maa?

[Diego Gonzalez]

Got a crash when casting Leap Into Battle around a corner. The monster was running away.

I wanted to ask... The attacks made by Maim Foe, cannot be avoided? Im trying to figure out uses for it.

[DavidMedley]

Around a corner, huh? Did you just cast detect?

[DavidMedley]

The stunning cannot be avoided, but the blow(s) can be.

[DavidMedley]

Breeder scumming seems a little generous, though I can't see a way to fix that without a cutoff for weak enemies.

I thought about this for a while, both in development and after I read this comment. In the six months I've been here, wobbly is definitely among the people whose opinion I respect most.

But I don't see the above as an issue. Part of the idea of the Blackguard is that he's a bit of a bully. In fact that's one of his 10 titles, from before I returned to Angband. Thug and Tormentor are also notable on that list. On March 25 I listed it as one of the pros of the class

Instead of being bored by low level monsters, they look like small SP boosts to the player (bullying for fun and profit)

Of course, bullying low level monsters can be boring as well, but hopefully if you feel strongly about that then you've chosen a different class. And I don't find filling up to max SP a game breaking advantage for BGs. If it is, then I'll need to make adjustments since !Mana are easy enough to come by.

[Diego Gonzalez]

Around a corner, huh? Did you just cast detect?

# #
#K##
#  @
####

This situation

Perhaps I missed something of the code when I updated my android sources. I'll take a look.

[DavidMedley]

OK, thanks for the report!

[Diego Gonzalez]

I could reproduce the bug

Is this expression:

if (i == 2) {
   d -= 4;
}

It can generate negative indexes. In this case the starting value of d is 7, modified with every interation of the loop (0 to 2).

[DavidMedley]

Oh geez. OK thanks. It's probably easiest for Nick to fix such an obvious error himself. Well, it's obvious now that you point it out, anyway.

[Diego Gonzalez]

I tried to fix it but it ended working in a bizarre way hehe. Its better that you or Nick make it work in the right way.