Bugs and issues in 4.1.2

[Nick]

You should try using stat_add instead of stat_ind and you can probably remove all the hacks

Yeah, I thought of that, but having already got this wrong three or four times I decided to keep it to something I knew would work.

[PowerWyrm]

New builds on the nightlies page actually fix the weapon damage/blows info, I believe. Please let me know if there are still problems.

You should try using stat_add instead of stat_ind and you can probably remove all the hacks

[Ingwe Ingweron]

New builds on the nightlies page actually fix the weapon damage/blows info, I believe. Please let me know if there are still problems.

Confirmed fixed. Now working as expected.

Haven't had a lot of time to test the experimental branch with the revamped and new classes, and those with more experience playing classes in variants will probably have better input, but I'm looking forward to giving them a go!

[Nick]

New builds on the nightlies page actually fix the weapon damage/blows info, I believe. Please let me know if there are still problems.

[Nick]

Forgot about those, which I used for testing the malleability of spells and classes in the edit files when we were parsing through all those line-by-line back when we were talking about whether edit files could be manipulated to create hybrid classes. Haven't pursued that line now that you are doing the experimental branch. Didn't know they affected the savefile unless one of the objects appeared on the level or were used by the class in question. I'll make sure to delete those objects.

Yes, the savefile having more objects than the version you're opening it in always causes problems.

Am now having more of a look at this; really a lot of both the calculation code and the damage display code needs rewriting, but I don't really want to do a major rewrite for 4.1.x because it would probably introduce new bugs. So I will try to get the logic straight with the current code, leave it sitting on master for a while to make sure it's fixed (and give a chance for any more bugs to be found), and then release a 4.1.3 which with luck will be the last 4.1.x.

Also, gratuitous ad for feature/magic branch (source and builds), now with necromancers.

[Derakon]

I had immunity cold by ring of power but an ice spear still could stun me.

The stunning is because you got whacked with a frozen rock. Ice is a different kind of damage from cold -- cold is like walking into a freezer, while ice is tripping and smacking your face on a glacier. Cold immunity protects you from the temperature effects, but not the physical effects.

(Which is not to say that the game does a good job of calling this out to the player)

[Tibarius]

stun from ice spear

I had immunity cold by ring of power but an ice spear still could stun me.

I realy consider it a bug that mana storm does not has 0% fail with maxint + CL50 - it is just nerving that you fail but doesn not basically change gameplay.

Edit: +1 for the mages vs Morgoth

[wobbly]

Flavor? *shrug*

The wine tastes better.

[Pete Mack]

!Heroism is still significantly better, as it adds +10 to attack, which is a big deal for an early character or for a mage using melee or archery.

[luneya]

O wait -- I've been playing for years and I never knew that wine cured fear? *facepalm* I've always thought that non-ration food items were basically junk, and ignored them in shops.

What's the logic behind two different consumables with basically the same effect then (!boldness and wine)?

Wine acts as a nerfed hybrid of food and !heroism--it does not actually cure fear, but rather gives you a status effect that makes you temporarily immune to fear-causing attacks. Its main benefit is that is an always available in the shops, whereas !heroism, !boldness, and !berserk strength are only sometimes available (though the chance of getting at least one of the three is almost certain, as they are stocked by both the alchemist and the temple). Also, if you're severely cash-strapped, the combination of !boldness and wine is much cheaper than buying !heroism/berserk, and together they will allow you to both cure and resist fear.

[Ingwe Ingweron]

...although apparently augmented with a couple of books from SongOfIceAndFireband - it took me some time to open

Problem confirmed - I will get back to this when I have some more time.

Forgot about those, which I used for testing the malleability of spells and classes in the edit files when we were parsing through all those line-by-line back when we were talking about whether edit files could be manipulated to create hybrid classes. Haven't pursued that line now that you are doing the experimental branch. Didn't know they affected the savefile unless one of the objects appeared on the level or were used by the class in question. I'll make sure to delete those objects.

[Derakon]

What's the logic behind two different consumables with basically the same effect then (!boldness and wine)?

Flavor? *shrug*

[fph]

O wait -- I've been playing for years and I never knew that wine cured fear? *facepalm* I've always thought that non-ration food items were basically junk, and ignored them in shops.

What's the logic behind two different consumables with basically the same effect then (!boldness and wine)?

[Nick]

It is from the latest nightly build, as linked in your post that the issue was fixed. Nightly 28 Jan 2018 at 04:25 UTC, revision c4cfd6a2, macosx

...although apparently augmented with a couple of books from SongOfIceAndFireband - it took me some time to open

Problem confirmed - I will get back to this when I have some more time.

[Ingwe Ingweron]

Is that savefile from 4.1.2, the latest nightly build, or the feature/magic branch? If the last, which build?

It is from the latest nightly build, as linked in your post that the issue was fixed. Nightly 28 Jan 2018 at 04:25 UTC, revision c4cfd6a2, macosx