4.0.4 bugs

[Nick]

So I just got a new artifact weapon and it seems pretty great, except there's so many abilities etc that it has that none of the combat information actually appears on the screen, so I have no idea how many blows, how much damage, etc., the darn thing does. Resizing the screen does not help at all. Moreover, after I inspect such a weapon, when I return to the main screen, the whole left hand side with character stats, etc., remains covered up by partial writing from the inspection, and is very difficult to get rid of.

I can't reproduce either of these. Could you possibly zip up your savefile and your angband.INI file and post them here?

[Pete Mack]

I took a longer look. The code IS set up to do proper double buffering. But from what I can see from a quick look at SDL documentation, the methods being used are not guaranteed to have a full backing store.

"Accelerated graphics" uses a backing store.

http://wiki.libsdl.org/CategoryRender

This method:

http://www.libsdl.org/release/SDL-1.2.15/docs/html/sdlupdaterects.html

Does NOT guarantee double buffering. It assumes direct writes to media.


Of course, I don't know SDL, so I could be wrong. But "accelerated gfx" sounds like the way to go.

EDIT: The reason I said it's not using double buffering is because with double buffering there cannot be flickering. It may be slow, but it shouldn't flicker. It's not because I fully grok SDL!

So where is this needed?

[spara]

I was wearing a Ring of Intelligence <+3> and replaced it with an unidentified Ring of Intelligence. The messages made me smile a bit.

You were wearing a Ring of Intelligence <+3> (d).
You feel smarter!
You are wearing a Ring of Intelligence <+2> (d).

I suppose the first ring is taken off first and the intelligence drops down and then the new ring is put on and the intelligence goes up thus triggering the "You feel smarter!" message.

[Nick]

In Linux X11, my messages become corrupt whenever any message contains a non-ASCII symbol. I get similar behavior with other parts of the interface (e.g., equipment and inventory lists, object list, monster list, item inspection). Sometimes these corruptions lead to crashes, which are always repeatable, but can be worked around by not doing that again (don't request a monster list while Khamul is visible).

Message corruption never crashes the game, but those other buffer do. Looking at stack dumps, it seems these things occur variably sized buffers are allocated.

I've observed this in 4.0.4 and top of tree. I didn't play 4.0.3, and I did not observe in 4.0.2. I can load up wizard more and get some stack dumps if you are unable to reproduce.

Stack dumps would be good - I haven't been able to reproduce this.

Edit: The list of outstanding bugs is now here - this doesn't include those where I have asked for more info, or the monster appearing twice in the list thing because an in-development change may have fixed that.

[Egavactip]

I can't reproduce either of these. Could you possibly zip up your savefile and your angband.INI file and post them here?

Sorry, I threw away the artifact before I saw this.

[PowerWyrm]

I was looking to reproduce the problem described in #1913, so I changed from ASCII to Shockbolt. After a few minutes of meleeing stuff without experiencing any problem, I switched back to ASCII and closed the window. Got the message "Saving game (done). Press Return (or Escape)." I pressed ESC and nothing happened. I clicked on the main window and got the Windows "program creased to function" message. I tried again to reproduce the problem and didn't manage to do so unfortunately...

[kandrc]

Stack dumps would be good - I haven't been able to reproduce this.

Edit: The list of outstanding bugs is now here - this doesn't include those where I have asked for more info, or the monster appearing twice in the list thing because an in-development change may have fixed that.

Stack dump follows. Version is top of tree a couple of weeks ago, 4.0.3-27-g083e1d4. If you'd like me to check some other state, try another version, etc., please let me know.

This is a brand new character, loaded Khamul in town. Khamul is the only monster in sight. Tried to get a monster list.

jeremy@eventhorizon:~/angband$ LC_ALL=UTF-8.en_US gdb ./src/angband
GNU gdb (GDB) 7.6.1
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-slackware-linux".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/jeremy/angband/src/angband...done.
(gdb) run
Starting program: /home/jeremy/angband/./src/angband 
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8.en_US)
warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?
angband: z-textblock.c:115: textblock_vappend_c: Assertion `new_length >= 0' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff6d7f979 in raise () from /lib64/libc.so.6
(gdb) by
Undefined command: "by".  Try "help".
(gdb) bt
#0  0x00007ffff6d7f979 in raise () from /lib64/libc.so.6
#1  0x00007ffff6d81088 in abort () from /lib64/libc.so.6
#2  0x00007ffff6d78966 in __assert_fail_base () from /lib64/libc.so.6
#3  0x00007ffff6d78a12 in __assert_fail () from /lib64/libc.so.6
#4  0x00000000004dbb66 in textblock_vappend_c (tb=0xa28d98, attr=17 '\021', 
    fmt=0x507225 "%-*s%s\n", vp=0x7fffffffd748) at z-textblock.c:115
#5  0x00000000004dbe8c in textblock_append_c (tb=0xa28d98, attr=17 '\021', 
    fmt=0x507225 "%-*s%s\n") at z-textblock.c:186
#6  0x00000000004b58c6 in monster_list_format_section (list=0xa6de38, 
    tb=0xa28d98, section=MONSTER_LIST_SECTION_LOS, lines_to_display=1, 
    max_width=55, prefix=0x507281 "You can see", show_others=false, 
    max_width_result=0x7fffffffda20) at ui-mon-list.c:156
#7  0x00000000004b5bb4 in monster_list_format_textblock (list=0xa6de38, 
    tb=0xa28d98, max_lines=2, max_width=55, max_height_result=0x0, 
    max_width_result=0x0) at ui-mon-list.c:288
#8  0x00000000004b5e87 in monster_list_show_interactive (height=81, width=214)
    at ui-mon-list.c:409
#9  0x00000000004b11f9 in do_cmd_monlist () at ui-knowledge.c:3202
#10 0x00000000004a6de2 in textui_process_command () at ui-game.c:314
#11 0x00000000004a6e2e in textui_get_cmd (context=CMD_GAME) at ui-game.c:326
#12 0x00000000004a70e2 in play_game (new_game=false) at ui-game.c:429
#13 0x00000000004de5a2 in main (argc=1, argv=0x7fffffffdc78) at main.c:556
(gdb) up
#1  0x00007ffff6d81088 in abort () from /lib64/libc.so.6
(gdb) 
#2  0x00007ffff6d78966 in __assert_fail_base () from /lib64/libc.so.6
(gdb) 
#3  0x00007ffff6d78a12 in __assert_fail () from /lib64/libc.so.6
(gdb) 
#4  0x00000000004dbb66 in textblock_vappend_c (tb=0xa28d98, attr=17 '\021', 
    fmt=0x507225 "%-*s%s\n", vp=0x7fffffffd748) at z-textblock.c:115
115             assert(new_length >= 0); /* If this fails, the string was badly formed */
(gdb) print new_length
$1 = -1

[Nick]

Stack dump follows. Version is top of tree a couple of weeks ago, 4.0.3-27-g083e1d4. If you'd like me to check some other state, try another version, etc., please let me know.

This is a brand new character, loaded Khamul in town. Khamul is the only monster in sight. Tried to get a monster list.

OK, this looks like it might be to do with your locale settings. You call gdb like this:

jeremy@eventhorizon:~/angband$ LC_ALL=UTF-8.en_US gdb ./src/angband

when you start angband it tells you

(gdb) run
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8.en_US)

and the line with the failed assert that causes it to crash is

#4  0x00000000004dbb66 in textblock_vappend_c (tb=0xa28d98, attr=17 '\021', 
    fmt=0x507225 "%-*s%s\n", vp=0x7fffffffd748) at z-textblock.c:115
115             assert(new_length >= 0); /* If this fails, the string was badly formed */

so it's saying the string (presumably including 'Khaműl') is badly formed. That string has come from a call to mbstowcs, which is what translates utf-8 characters.

I don't fully understand locales, and I would have thought on the face of it that setting LC_ALL to UTF_8.en_US would be OK; mine is unset, though. And in fact, I can now mimic this behaviour by setting my LC_ALL as you do. So maybe just don't do that?

[hjklyubn]

I don't fully understand locales, and I would have thought on the face of it that setting LC_ALL to UTF_8.en_US would be OK; mine is unset, though. And in fact, I can now mimic this behaviour by setting my LC_ALL as you do. So maybe just don't do that?

The actual locale name is en_US.UTF-8, not UTF-8.en_US, at least on my Linux system.

[Nick]

The actual locale name is en_US.UTF-8, not UTF-8.en_US, at least on my Linux system.

Told you I didn't know much

Well done - sure enough, running with

LC_ALL=en_US.UTF-8

works just fine.

[mzhr]

There's a spelling mistake inside the lib/gamedata/hints.txt file where
'invincible' is spelled wrong.

On line 92 it says:

H:You're never invicible. Never forget that.

[Timo Pietilä]

There's a spelling mistake inside the lib/gamedata/hints.txt file where
'invincible' is spelled wrong.

On line 92 it says:

H:You're never [B]invicible[/B]. Never forget that.

Invincible or invisible. Both could work on that.

[Pete Mack]

Well, it's true you're not invicible either.

[Nick]

Now that I'm playing... This is a minor cosmetic thing and probably has been reported already, but anyway, I'm browsing my spellbook with descriptions on and move from one spell to another. If the previous spell's description uses two more lines than the current one, part of the previous description is left on screen. And still running the SDL port on Linux.

I'm unable to reproduce this, in the SDL port, either with tiles or ascii, and with various sized windows.

[Nick]

Updated builds for bugfixed 4.0.4 - Windows and OS X.

Bugs fixed, changes made:

• Bad friends for master mystics
• Some OS X cleanup
• Monster lore from probing is more complete
• Fix to store names
• Monster list updates after detection
• Windows sound fixed
• Flicker when player moves with center_player set removed
• No more duplicate labels in death object examine menus, plus quiver gets shown in death info
• Bashing and jamming removed from help, plus invicible->invincible

Bugs not fixed, changes not made:

• Monster tiles sometimes vanishing under the cursor
• Screen redraw delay so it seems player appears twice
• Map window update issues
• OS X term windows opening with Command-1, etc - I think this one is beyond my capabilities, and I will have to wait for someone who knows something