Angband 4.2.5

[PowerWyrm]

The logic for reducing chance of successfully applying a skill (disarming, opening...) is not consistent everywhere. Sometimes a factor of 1/10 is applied for TMD_BLIND/no light/TMD_CONFUSED/TMD_IMAGE and sometimes a 1/10 factor is applied for TMD_BLIND/no light and then another 1/10 reduction is applied for TMD_CONFUSED/TMD_IMAGE.

10% factor: do_cmd_lock_door(), do_cmd_disarm_aux()
10% + 10% factors: do_cmd_open_chest(), do_cmd_disarm_chest(), calc_unlocking_chance()

The best would be to rename calc_unlocking_chance() and use it everywhere a skill power is calculated.

[mrfy]

Using 4.2.5-185-g02b5e5f72 on macosx, I'm noticing that the first action taken doesn't make a sound but the second does.

For example,
Picking up multiple arrows/shots/bolts, sometimes the first item picked up is silent but 2nd and following ones make the quiver pick up sound.

Or switch to tunneling, and the first wall removed doesn't make a sound but following ones do.

Submitted to github as #5962

[Nick]

Using 4.2.5-185-g02b5e5f72 on macosx, I'm noticing that the first action taken doesn't make a sound but the second does.

For example,
Picking up multiple arrows/shots/bolts, sometimes the first item picked up is silent but 2nd and following ones make the quiver pick up sound.

Or switch to tunneling, and the first wall removed doesn't make a sound but following ones do.

Submitted to github as #5962

Thanks for reporting.