Angband 4.2.5

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2981

    #46
    The logic for reducing chance of successfully applying a skill (disarming, opening...) is not consistent everywhere. Sometimes a factor of 1/10 is applied for TMD_BLIND/no light/TMD_CONFUSED​/TMD_IMAGE​ and sometimes a 1/10 factor is applied for TMD_BLIND​/no light and then another 1/10 reduction is applied for TMD_CONFUSED​/TMD_IMAGE.

    10% factor: do_cmd_lock_door(), do_cmd_disarm_aux()
    10% + 10% factors: do_cmd_open_chest(), do_cmd_disarm_chest(), calc_unlocking_chance()

    The best would be to rename calc_unlocking_chance() and use it everywhere a skill power is calculated.
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

    Comment

    • mrfy
      Swordsman
      • Jul 2015
      • 322

      #47
      Using 4.2.5-185-g02b5e5f72 on macosx, I'm noticing that the first action taken doesn't make a sound but the second does.

      For example,
      Picking up multiple arrows/shots/bolts, sometimes the first item picked up is silent but 2nd and following ones make the quiver pick up sound.

      Or switch to tunneling, and the first wall removed doesn't make a sound but following ones do.

      Submitted to github as #5962

      Comment

      • Nick
        Vanilla maintainer
        • Apr 2007
        • 9596

        #48
        Originally posted by mrfy
        Using 4.2.5-185-g02b5e5f72 on macosx, I'm noticing that the first action taken doesn't make a sound but the second does.

        For example,
        Picking up multiple arrows/shots/bolts, sometimes the first item picked up is silent but 2nd and following ones make the quiver pick up sound.

        Or switch to tunneling, and the first wall removed doesn't make a sound but following ones do.

        Submitted to github as #5962
        Thanks for reporting.
        One for the Dark Lord on his dark throne
        In the Land of Mordor where the Shadows lie.

        Comment

        • Ingwe Ingweron
          Veteran
          • Jan 2009
          • 2128

          #49
          Has there been a change to "Afraid" status? Playing the nightly, I've noticed that @ can still melee while "Afraid" even though @ does not have pFear.
          “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
          ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

          Comment

          • backwardsEric
            Knight
            • Aug 2019
            • 506

            #50
            Originally posted by Ingwe Ingweron
            Has there been a change to "Afraid" status? Playing the nightly, I've noticed that @ can still melee while "Afraid" even though @ does not have pFear.
            Not intentionally, but a post 4.2.5 change caused two timed effects (AFRAID and TERROR) to not apply the side effects of fear to the player. A proposed fix for that is at https://github.com/angband/angband/pull/5965 . Thanks for reporting the problem.

            Comment

            • Nick
              Vanilla maintainer
              • Apr 2007
              • 9596

              #51
              Originally posted by backwardsEric

              Not intentionally, but a post 4.2.5 change caused two timed effects (AFRAID and TERROR) to not apply the side effects of fear to the player. A proposed fix for that is at https://github.com/angband/angband/pull/5965 . Thanks for reporting the problem.
              That fix is in place now.
              One for the Dark Lord on his dark throne
              In the Land of Mordor where the Shadows lie.

              Comment

              • gglibertine
                Adept
                • Dec 2007
                • 232

                #52
                Very minor bug -- the potion is called "Resist Heat", but when you take it, your status bar says "Resist Fire". This is inconsistent with the behaviour of "Resist Cold", which matches in both places. (I observed this in the Android app but remember it being the same in the Windows build.)

                Comment

                Working...
                😀
                😂
                🥰
                😘
                🤢
                😎
                😞
                😡
                👍
                👎