Competition 110

[Psi]

I've been into debug mode and tried 'v' which should create great items... so far I've only got {good} from it. I think that confirms it!

This is WEIRD. I have used the 'o' command to play with the object and rerolling it {good} or {excellent} hundreds if not thousands of times only ever produces a {good} item. However if you roll it as normal, you will eventually get both good and bad egos.

Bottom line is, you can only get egos if the object is *NOT* guaranteed good...

[Psi]

Ok... shot in the dark time. There is a good_ego function in obj-make.c - if that always returned FALSE then I think we'd see exactly what we are seeing. I'm struggling to see where else in the code this bug could be hiding, so that is my guess.

[Nick]

Not sure but it seemed like becoming hungry while rested did not break the resting. I nearly starved to death. Although I was wearing a perilous ring I had not ID'ed so if there is a hunger curse maybe that was it.

Yes, I've seen something like this too, but not consciously recognised it.

OK, looks as though there is some problem with artifact magic devices; the wand 'Ilkhorin' has the same 'bad effect' issue.

Yep, I've had bad artifact device effects reported, too.

Ok... shot in the dark time. There is a good_ego function in obj-make.c - if that always returned FALSE then I think we'd see exactly what we are seeing. I'm struggling to see where else in the code this bug could be hiding, so that is my guess.

Thanks for that - looks like it is close but not quite correct. It seems that there is something wrong with the logic in make_ego_item, so it never even gets to call good_ego.

[Psi]

Thanks for that - looks like it is close but not quite correct. It seems that there is something wrong with the logic in make_ego_item, so it never even gets to call good_ego.

Good stuff. Hope you fix it soon. I must admit I didn't quite understand the logic in good_ego. It looks like it treats egos with 0 max_to_h and max_to_d in the same way as those with negative values. Maybe that is intended, but I was concerned that would mean all armour egos would be classed like bad weapon egos? I haven't read the code closely enough, so I'm probably missing something.

[ewan]

Next on the bug list

First scroll of electroproofing; every time I try to read it the game crashes completely.

[ewan]

Same issue with Coldproofing.

[Nick]

On the plus side, if you're finding those scrolls, you're progressing well...

[caruso]

The manual says that Edain "fight their best in the forests of Beleriand". Do they get advantages when standing on any kind of "tree" square? Please clarify in the manual as well.

Where do I find the character dumps? I even searched the FAangband folder manually but can't find them. Actually this is not so urgent... I've lost ten characters already, more than half of which did not even survive their first battle. Maybe you should add one more hint to the competition: "Be prepared to lose a lot of characters in the early game".

[Nick]

The manual says that Edain "fight their best in the forests of Beleriand". Do they get advantages when standing on any kind of "tree" square? Please clarify in the manual as well.

They get a to-skill bonus when in a forest level - if you look at the local area map (which comes up second at the 'M' command, or for a full one see worldmap.png in the top level folder), you will see which levels are forests.

Where do I find the character dumps? I even searched the FAangband folder manually but can't find them.

It should be in lib\user (if you're playing in windows).

Actually this is not so urgent... I've lost ten characters already, more than half of which did not even survive their first battle. Maybe you should add one more hint to the competition: "Be prepared to lose a lot of characters in the early game".

Yes - this competition was tougher than I intended...

[caruso]

They get a to-skill bonus when in a forest level - if you look at the local area map (which comes up second at the 'M' command, or for a full one see worldmap.png in the top level folder), you will see which levels are forests.

Ahhh... So the idea is to go leveling up in the north first before heading for the dungeon in the south. Thanks! Maybe if you mention this in the description of the competition, the competition would become more balanced.

It should be in lib\user (if you're playing in windows).

There is a file named "110" in there. Should have been "Arin.txt". Gonna try it tomorrow.

[ewan]

There are trees everywhere; no need to seek out a forest especially.

But the reason for coming to post was: Hey! Unfair! :-)

Found the little shield of Khazad-Dum, with ImmAcid, fine. Ancalagon breathes acid, excellent. EXCEPT that although I take no damage, apparently items can still be destroyed - in this case my staff of holiness. Bah, humbug.

Right now on Angband 95, slowly luring out denizens of a huge vault. Omarax is dead, Ancalagon in battle right now; Gothmog and Krotus among others still to come. I should just flee, but...

[Psi]

Yep. In O-variants, immunities are for the player not the inventory (though it does help to protect your stuff).

[caruso]

There are trees everywhere; no need to seek out a forest especially.

The way I understand it, you get the adan bonus when being in any wilderness level labelled "forest" on the map screen, not when standing on a tree...

[ewan]

Oh! Well, doubtless you're right - I'm inexperienced with O and variants - but it means I spent a lot of wasted time trying to hide in trees

[Nick]

The way I understand it, you get the adan bonus when being in any wilderness level labelled "forest" on the map screen, not when standing on a tree...

Correct - and this is an FA only innovation. But all bets are off when the new wilderness happens - although I am going to make an effort to get 1.2 properly bug fixed before I start on that.