Bugs and issues in 4.1.0

[Sideways]

In g36595ad:

My @ has all resists except light (which includes rBlind). He has ESP, but no see invis.

Attached image shows @ is pounding on a bone golem. Nearby master vamp summons darkness, and then @ is blind. Save and restore of the game restored @'s vision.

Were you actually blind, or just surrounded by dark squares that hid the monsters? I've had strange dark squares appear that hide monsters even within light radius, though I'm not sure whether they still do that with ESP.

[passer_by]

The priest prayer Sense invisible has a lower-case i; it should have an upper-case I to be consistent with every other prayer and spell.

Also, in quiver-related prompts (like "fire which ammunition?") the text says "Quiver: a-c" but the slots involved are actually 0, 1 and 2; so either the text should say "Quiver: 0-2" or letters should be allowed as substitutes for digits.

(Yes, finding trivial things to complain about when everybody else is reporting serious bugs is my specialty )

I have a couple of trivial complaints along very much the same lines ...

1. The "remove which curse?" prompt should label the curse slots a), b), etc. so that, like every other prompt, you can select the curse with a keyboard letter rather than the arrow keys.

2. It would be more in keeping with Angband UX style for the curses to be referred to as, for example, "Curse of Treacherous Weapon" (note capitalization) instead of "treacherous weapon curse".

[passer_by]

In my 4.1.0 savefile the Black Market is selling a Ring of Strength which is not fully identified — pval is not shown, and 'x' tells me "You do not know the full extent of this item's powers". There appears to be no way of determining the pval of the ring without buying it.

Or is this a new feature of the Black Market?

[kandrc]

Were you actually blind, or just surrounded by dark squares that hid the monsters? I've had strange dark squares appear that hide monsters even within light radius, though I'm not sure whether they still do that with ESP.

Not clear. I never get a "You can't see" message, but everything else in LoS was ESP visible. Regardless, I had multiple sources of permanent light but couldn't see the monster in the cell adjacent to me.

[TranceProgHouse]

In the current build, 4.1.0 and one of the recent build (subsets?), I cannot get sound to work, it last worked for me in 4.0.5 when it was setup under the xtra folder. Does anyone know a fix for this?

Although I do not have a lot of time because of work, I have been making some sound effects for roguelikes, especially dcss/nethack and would like to gradually put together a common sound pack for those plus angband, and as a gamer in general, I enjoy audio cues when playing quickly because a sound can provide information faster than reading a message in some cases.

[Nick]

In the current build, 4.1.0 and one of the recent build (subsets?), I cannot get sound to work, it last worked for me in 4.0.5 when it was setup under the xtra folder. Does anyone know a fix for this?

If it's windows, then this is a known bug. PowerWyrm has suggested a cause to do with the build environment not being clean - I doubt if that's it, because I think the autobuilder always has a clean environment.

[TranceProgHouse]

If it's windows, then this is a known bug. PowerWyrm has suggested a cause to do with the build environment not being clean - I doubt if that's it, because I think the autobuilder always has a clean environment.

Oh ok thanks, I'll see if I can figure out how to do this (beginner in terms of programming and what-not).

Edit:

I received the following error when attempting to compile with MinGW :https://i.imgur.com/bfQNn2H.png
[spoiler]
[/spoiler]

[passer_by]

When I kill things while blind, I'm getting messages like "You freeze someone. You have killed it."

I love that we are now distinguishing "someone"s from "something"s, but my intuition of English grammar is that we should then refer back to them as "him" or "her" or "them" but not "it".

A cursory glance at mon-desc.c suggests that there is exactly such code for pronouns. But it doesn't seem to be showing up in the message "You have killed %s".

[kandrc]

Oh ok thanks, I'll see if I can figure out how to do this (beginner in terms of programming and what-not).

Edit:

I received the following error when attempting to compile with MinGW :https://i.imgur.com/bfQNn2H.png
[spoiler]
[/spoiler]

That looks like it may be a path issue. It's been most of a decade since I've used MinGW (or Windows), but if I'm interpreting this correctly, it failed to launch gcc. And it says "Administrator: Command Prompt" at the top. If I recall correctly, MinGW installs an "MinGW Shell" that, when launched, sets up a working MinGW environment (and simply installing MinGW does not). Assuming I'm correct in that dim recollection, you need to launch a MinGW shell and try your build in there.

That said, the odd thing about this is that make is in your path, but gcc (apparently) is not. Perhaps you have more than one make installed?

[Sideways]

Not clear. I never get a "You can't see" message, but everything else in LoS was ESP visible. Regardless, I had multiple sources of permanent light but couldn't see the monster in the cell adjacent to me.

That sounds like it was probably the same problem I've had.

The problem should be fairly easy to reproduce in debug mode; just get a nice light source with a good radius and then run around in a room with several master vampires in it. (I'm not sure whether it needs to be a room, but it's at least easier to reproduce in rooms.)

[Estie]

Regarding lights:

I have waited for the base item fix before posting, but with the new light pattern it often happens that the best randarts are lowly torches and lanterns. I very rarely find those in the early game and later they cant appear anymore becaue of max level allocation. Back when there was always at least one arkenstone with a decent pool of properties that was no issue, but when that is not guaranteed, shouldnt the level allocation match the relative quality ?

For me, I could see maxlevel removed completely, I dont mind finding a *thanc in a lvl 98 GV any more than I do finding another elven armour.

[TranceProgHouse]

That looks like it may be a path issue. It's been most of a decade since I've used MinGW (or Windows), but if I'm interpreting this correctly, it failed to launch gcc. And it says "Administrator: Command Prompt" at the top. If I recall correctly, MinGW installs an "MinGW Shell" that, when launched, sets up a working MinGW environment (and simply installing MinGW does not). Assuming I'm correct in that dim recollection, you need to launch a MinGW shell and try your build in there.

That said, the odd thing about this is that make is in your path, but gcc (apparently) is not. Perhaps you have more than one make installed?

Yes, Cygwin, I tried from both as well as adding the MinGW to my user PATH variable. I also did try both shells and they can't find the "make" command or give the error above. I am not even sure where the make .exe for Cygwin is. I do not have either installed in the default C: directory, which always seem to be an issue for me when it comes to tasks like this.

I think I did get an alternate error where it was something like "line 38 aclocal not found", I might try again later. Any suggestions would be appreciated.

[Nick]

Yes, Cygwin, I tried from both as well as adding the MinGW to my user PATH variable. I also did try both shells and they can't find the "make" command or give the error above. I am not even sure where the make .exe for Cygwin is. I do not have either installed in the default C: directory, which always seem to be an issue for me when it comes to tasks like this.

I think I did get an alternate error where it was something like "line 38 aclocal not found", I might try again later. Any suggestions would be appreciated.

I'm not the world's greatest *nix guru, but have you tried putting the MINGW=yes at the start of the command instead of the end?

[Gwarl]

the line 38 aclocal not found thing is autotools

if you're using mingw you need to use msys (found somewhere inside your mingw folder) which provides a unix-like environment and you enter your commands there (not in windows command line even though it thinks you have gcc now). But you also need to set up the msys thing to have the dependencies angband needs (like autotools stuff)

What are your motivations for compiling vs precompiled windows binary?

[TranceProgHouse]

the line 38 aclocal not found thing is autotools

if you're using mingw you need to use msys (found somewhere inside your mingw folder) which provides a unix-like environment and you enter your commands there (not in windows command line even though it thinks you have gcc now). But you also need to set up the msys thing to have the dependencies angband needs (like autotools stuff)

What are your motivations for compiling vs precompiled windows binary?

http://trac.rephial.org/ticket/2028

I was trying to get sound to work based on the bug report above.

It appears that moving the MINGW=yes in front of the command did not resolve the GCC related error.

I'm probably a bit in over my head as I think there are multiple things I need to learn about and check. I won't have much time during the week so I may return to this at another time - thanks though.