Bugs and complaints on current master

[PowerWyrm]

There'a also a potential problem with add_brand() and add_slay(). For example (brand -- slay is identical):

struct brand *brand;

...
append_random_brand(&art->brands, &brand)
...
if (streq(brand->name, elements[i].name)
...

"brand" is always initialized with the "pick" even if nothing is appended. To avoid spamming randarts with resists, a check should be added:

struct brand *brand;

...
if (append_random_brand(&art->brands, &brand)) {
  ...
  if (streq(brand->name, elements[i].name)
  ...
}

[Nick]

Thanks - I had found the powerful one (although there are still issues with that code), but not the brand/slay one.

[Thraalbee]

An issue with [angband-4.0.3-504-g35c4104] and a !*healing* located on top of a lava flow # caused by monsters. I see it in the items list, I see it with "x" but when I step on it I get no "You see..." message and no auto pickup adding it to the stack in my inventory. "Get" works though.

[Nick]

I havent been playing much, but looking at the randrat file of my latest characters, not a single randart had extra attacks. Standarts are still the same.

Basically, this means that randart weapons are even worse than before, so I would almost always end up with an ego weapon in the endgame, which is not what I want when picking randarts. I assume this is an error ?

All right, I've found the actual error here - when I first started working on randarts post 4.0, I had accidentally left a line in which unconditionally set extra blows to 0 on everything. Unsurprisingly, removing that line is an improvement

[Nick]

New build on the nightlies page with extra blows on randarts now allowed, and several improvements (including it now works) to the curse removal process.

[Grotug]

Not sure if this has already been listed or if I'm the only one experiencing it:

When I look at a pile of objects, and one of the objects is money, the money displays as blank and then the game randomly replaces tiles with blanks, like so:



Usually this bug only affects hitpoints and one or two other items, but on this occasion it kinda when funkytown on the whole vault. The Heavy Xbow that @ sees @ is on, but because of said bug, @ is not being displayed presently. That's why you can't see @ anywhere on the screen. The Heavy Xbow is smack dab in the center of the vault.

To restore the display to normal, I simply bring up the Character screen and then return to the main screen and everything looks as it should again.

Mac OS 10.10.5 (Yosemite). Angband version 4.0.5 dirty Btw, Yosemite Nat'l Park is amazing.

[Azuria]

Two things I've found:

If a monster with light is killed, its light remains until you move.

Also, stone to mud isn't affecting the passable rubble.

[PowerWyrm]

All right, I've found the actual error here - when I first started working on randarts post 4.0, I had accidentally left a line in which unconditionally set extra blows to 0 on everything. Unsurprisingly, removing that line is an improvement

In the original code, which I use for PWMAng, the line was actually "if number of blows is negative, set it to zero", which is more like it, since the remove_contradictory function does the same for other modifiers.

Also in the original code, the number of blows added was actually "INHIBIT_STRONG? 3: randint1(2)" (chance of +3), bit of code which disappeared when the fake pvals were removed.

[PowerWyrm]

Minor stuff with latest build (curse menu):

"Your a Beaked Axe... is now fragile." while failing to remove a curse (no need for the prefix in object_desc).

"It Poisons you from time to time." while inspecting a cursed item (would be better to leave curse descriptions like before and do a my_strcap in curse_menu_browser).

[Azuria]

Just got locked into casting Meteor Swarm indefinitely at a wall until I ran out of mana. I'm guessing the game thought I had the n key held or something like that, since it was a continuation of killing an elder vampire with it.

[Thraalbee]

Randart curses seem to be appended without coordination. Nbr 2 and 3 cancel each other out. Also not clear how the curse (providing only one of 2 and 3) interacts with "provides resistance to acid, lightning, fire, frost"

the Adamantite Plate Mail 'Teith' (-4) [80,-13] {cursed}
--------------------------------------------------------
It  Makes your skin harder to damage, but conduct electricity.
It  Makes you vulnerable to cold attacks, but resistant to fire.
It  Makes you vulnerable to fire attacks, but resistant to cold.
It  Makes you hallucinate sometimes.
It  Poisons you from time to time.
It  Weakens your grasp.
It  Attracts opponents and weakens the defences.
Provides resistance to acid, lightning, fire, frost.
Cannot be harmed by acid.
Grants the ability to see invisible things.  Prevents teleportation.  


Min Level 15, Max Level 21, Generation chance 10, Power -27, 42.0 lbs
Based on Camlost.

[Nick]

Randart curses seem to be appended without coordination. Nbr 2 and 3 cancel each other out. Also not clear how the curse (providing only one of 2 and 3) interacts with "provides resistance to acid, lightning, fire, frost"

Yes, curses on randarts are still just tacked on. That part of the randart code needs to be fixed, but it probably makes sense to do that at the same time as any other deeper changes to randarts.

Do randarts seem to be working OK aside from that?

[Nick]

Another new build on the nightlies page, with the following fixes:

• Weirdness with objects on lava - now any objects not burned by the lava creation are pushed aside
• Stone to mud destroys passable rubble
• Curse descriptions are fixed
• Monster lights disappear when the monster is killed

[Estie]

Do randarts seem to be working OK aside from that?

I have played one character only to the lategame and not noticed anything amiss. Maybe I should just create some randart sets and look at them, but then there are people better suited for that who can actually write a program that can quickly create a sample of sets and output it to a text file.

[spara]

Monsters are in funny order in monster list subwindow:


Save file, if needed:
Order.zip