Bugs and complaints on current master

[Nomad]

A few thoughts on curses, since I missed most of the earlier testing of the curse branch:

First, I really like how the new curse system works now! My early-game warrior just found a +5 dagger that does much better damage than anything else so far, despite coming with the minor side effects of summoning undead and occasional hallucinations. That's exactly the kind of trade-off curses should be aiming for, I think. (Also, ghosts randomly appearing while you walk around is just fun. My favourite curse I've encountered so far.)

My main issue with the system is just that curses on (+0, +0) weapons or [+0] armour are too immediately obvious. Could it be altered so that curses only occur on magical or better equipment? That would also have the side benefit of making them more likely to be worth the trade-off of using despite being cursed. (The arguably better fix might be to allow +0 egos, but that's probably a bit more involved.)

I also have mixed feelings about the "identify your first curse, subsequently recognise all items that are cursed" aspect - I'd actually prefer it if curses were treated like any other runes and all had to be discovered individually to retain more of a "gotcha" effect. If that's too much of a risk for people with more cautious playstyles, then you could perhaps add a Detect Curses spell that detects whether any of your gear is cursed without fully identifying the curses. You could even give it to priests as a class-specific inherent ability that lets them spot cursed items on walkover.

[Grotug]

It just crashed again going for the downstairs. I'll send you the files soon.

[Nick]

I tried twice to descend to DL100 but it crashes every time.

Any crash is bad as far as I'm concerned. Your crash log gives some info about where it happened (my guess is it's something to do with generation of the new special randarts), but a savefile (and as Pete says, probably a randart file) would enable me to track it down properly.

[Grotug]

Well, I guess the save is no longer since Ironfist died and I started a new game with the same name.

[Pete Mack]

Post a save file, and randarts file. Apparently you need both now, which seems bad.

[Grotug]

I tried twice to descend to DL100 but it crashes every time. I'm playing the Feb 27th Nightly:

Process:               angband [1955]
Path:                  /Users/USER/Downloads/*/Angband.app/Contents/MacOS/angband
Identifier:            org.rephial.angband
Version:               4.0.3-651-gea18824-dirty (???)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           angband [1955]
User ID:               501

Date/Time:             2017-03-04 08:00:16.025 -0500
OS Version:            Mac OS X 10.10.5 (14F1912)
Report Version:        11
Anonymous UUID:        26B70A5A-D032-6325-D710-460859433293

Sleep/Wake UUID:       335234C0-FB5E-4728-8DAE-BEC66F1601E4

Time Awake Since Boot: 54000 seconds
Time Since Wake:       23000 seconds

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x000000000000001c

VM Regions Near 0x1c:
--> 
    __TEXT                 0000000100000000-0000000100112000 [ 1096K] r-x/rwx SM=COW  /Users/USER/Downloads/*/Angband.app/Contents/MacOS/angband

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_platform.dylib      	0x00007fff977d6056 _platform_memmove$VARIANT$Unknown + 182
1   org.rephial.angband           	0x00000001000c2ec9 flag_copy + 9
2   org.rephial.angband           	0x000000010006144f object_prep + 159
3   org.rephial.angband           	0x0000000100042cec place_monster + 716
4   org.rephial.angband           	0x0000000100043928 place_new_monster_one + 1192
5   org.rephial.angband           	0x00000001000439dd place_new_monster + 93
6   org.rephial.angband           	0x0000000100043d09 pick_and_place_monster + 73
7   org.rephial.angband           	0x0000000100024443 build_vault + 2291
8   org.rephial.angband           	0x0000000100029ff3 build_greater_vault + 355
9   org.rephial.angband           	0x000000010002bd7c room_build + 428
10  org.rephial.angband           	0x000000010001b0c1 classic_gen + 1041
11  org.rephial.angband           	0x0000000100019553 cave_generate + 211
12  org.rephial.angband           	0x0000000100018673 run_game_loop + 547
13  org.rephial.angband           	0x0000000100097bdd play_game + 237
14  org.rephial.angband           	0x00000001000cb5ae +[AngbandContext beginGame] + 1630
15  org.rephial.angband           	0x00000001000cea1d -[AngbandAppDelegate applicationDidFinishLaunching:] + 29
16  com.apple.CoreFoundation      	0x00007fff95e2f45c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
17  com.apple.CoreFoundation      	0x00007fff95d1f634 _CFXNotificationPost + 3140
18  com.apple.Foundation          	0x00007fff94489aa1 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
19  com.apple.AppKit              	0x00007fff97f50a8b -[NSApplication _postDidFinishNotification] + 291
20  com.apple.AppKit              	0x00007fff97f507f6 -[NSApplication _sendFinishLaunchingNotification] + 191
21  com.apple.AppKit              	0x00007fff97f4d946 -[NSApplication(NSAppleEventHandling) _handleAEOpenEvent:] + 574
22  com.apple.AppKit              	0x00007fff97f4d385 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 244
23  com.apple.Foundation          	0x00007fff944bc818 -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 290
24  com.apple.Foundation          	0x00007fff944bc689 _NSAppleEventManagerGenericHandler + 102
25  com.apple.AE                  	0x00007fff8e94743c aeDispatchAppleEvent(AEDesc const*, AEDesc*, unsigned int, unsigned char*) + 531
26  com.apple.AE                  	0x00007fff8e9471b9 dispatchEventAndSendReply(AEDesc const*, AEDesc*) + 31
27  com.apple.AE                  	0x00007fff8e9470c3 aeProcessAppleEvent + 295
28  com.apple.HIToolbox           	0x00007fff94bf6c6e AEProcessAppleEvent + 56
29  com.apple.AppKit              	0x00007fff97f46da2 _DPSNextEvent + 2249
30  com.apple.AppKit              	0x00007fff97f45e58 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 346
31  com.apple.AppKit              	0x00007fff97f3baf3 -[NSApplication run] + 594
32  com.apple.AppKit              	0x00007fff97eb8244 NSApplicationMain + 1832
33  org.rephial.angband           	0x00000001000cedf9 main + 9
34  org.rephial.angband           	0x0000000100001754 start + 52

Thread 1:: Dispatch queue: com.apple.libdispatch-manager
0   libsystem_kernel.dylib        	0x00007fff97e36232 kevent64 + 10
1   libdispatch.dylib             	0x00007fff9232926e _dispatch_mgr_thread + 52

Thread 2:
0   libsystem_kernel.dylib        	0x00007fff97e304de mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff97e2f64f mach_msg + 55
2   com.apple.CoreFoundation      	0x00007fff95d81eb4 __CFRunLoopServiceMachPort + 212
3   com.apple.CoreFoundation      	0x00007fff95d8137b __CFRunLoopRun + 1371
4   com.apple.CoreFoundation      	0x00007fff95d80bd8 CFRunLoopRunSpecific + 296
5   com.apple.AppKit              	0x00007fff9800e56b _NSEventThread + 137
6   libsystem_pthread.dylib       	0x00007fff8cf1705a _pthread_body + 131
7   libsystem_pthread.dylib       	0x00007fff8cf16fd7 _pthread_start + 176
8   libsystem_pthread.dylib       	0x00007fff8cf143ed thread_start + 13

Thread 3:
0   libsystem_kernel.dylib        	0x00007fff97e3594a __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff8cf143dd start_wqthread + 13

Thread 4:
0   libsystem_kernel.dylib        	0x00007fff97e3594a __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff8cf143dd start_wqthread + 13

Thread 5:
0   libsystem_kernel.dylib        	0x00007fff97e3594a __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff8cf143dd start_wqthread + 13

Thread 6:
0   libsystem_kernel.dylib        	0x00007fff97e3594a __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff8cf143dd start_wqthread + 13

Thread 7:: com.apple.audio.IOThread.client
0   libsystem_kernel.dylib        	0x00007fff97e304de mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff97e2f64f mach_msg + 55
2   com.apple.audio.CoreAudio     	0x00007fff94b87544 HALB_MachPort::SendMessageWithReply(unsigned int, unsigned int, unsigned int, unsigned int, mach_msg_header_t*, bool, unsigned int) + 98
3   com.apple.audio.CoreAudio     	0x00007fff94b874d2 HALB_MachPort::SendSimpleMessageWithSimpleReply(unsigned int, unsigned int, int, int&, bool, unsigned int) + 42
4   com.apple.audio.CoreAudio     	0x00007fff94b85a05 HALC_ProxyIOContext::IOWorkLoop() + 1089
5   com.apple.audio.CoreAudio     	0x00007fff94b854f2 HALC_ProxyIOContext::IOThreadEntry(void*) + 88
6   com.apple.audio.CoreAudio     	0x00007fff94b853c3 HALB_IOThread::Entry(void*) + 157
7   libsystem_pthread.dylib       	0x00007fff8cf1705a _pthread_body + 131
8   libsystem_pthread.dylib       	0x00007fff8cf16fd7 _pthread_start + 176
9   libsystem_pthread.dylib       	0x00007fff8cf143ed thread_start + 13

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x000000010a61410c  rbx: 0x000000010a6140c8  rcx: 0x0000000000000000  rdx: 0x0000000000000005
  rdi: 0x000000010a61410c  rsi: 0x000000000000001c  rbp: 0x00007fff5fbfe450  rsp: 0x00007fff5fbfe450
   r8: 0x0000000000000000   r9: 0x0000000080000000  r10: 0x000000000b6cae9d  r11: 0x000000010a6140f0
  r12: 0x0000000000000064  r13: 0x000000010a61410c  r14: 0x0000000109d71d98  r15: 0x0000000000000004
  rip: 0x00007fff977d6056  rfl: 0x0000000000010246  cr2: 0x000000000000001c
  
Logical CPU:     2
Error Code:      0x00000004
Trap Number:     14


Binary Images:
       0x100000000 -        0x100111fff +org.rephial.angband (4.0.3-651-gea18824-dirty - ???) <6B6B1C84-692C-3D17-970C-DABC45647C5E> /Users/USER/Downloads/*/Angband.app/Contents/MacOS/angband
       0x1005f7000 -        0x1005f7fef +cl_kernels (???) <54A560A7-7C6F-42F5-B3DA-6978472833EB> cl_kernels
       0x100606000 -        0x100606ff5 +cl_kernels (???) <49AE5DC9-A834-4217-B87D-61A925193154> cl_kernels
       0x103e0f000 -        0x103e13fff  com.apple.audio.AppleHDAHALPlugIn (272.18.3 - 272.18.3) <D40CF081-95C3-3B08-B43F-8A84B579195B> /System/Library/Extensions/AppleHDA.kext/Contents/PlugIns/AppleHDAHALPlugIn.bundle/Contents/MacOS/AppleHDAHALPlugIn
       0x1071f7000 -        0x107414ff3  com.apple.audio.units.Components (1.12 - 1.12) <AC14ADC7-587F-3E0F-92E7-9D8C07753C22> /System/Library/Components/CoreAudio.component/Contents/MacOS/CoreAudio
       0x1074d0000 -        0x107784fff  com.apple.audio.codecs.Components (5.0 - 5.0) <F3090310-6B20-35C1-9EE7-9324EF1A84B5> /System/Library/Components/AudioCodecs.component/Contents/MacOS/AudioCodecs
       0x109fe1000 -        0x10a0c7fef  unorm8_bgra.dylib (2.4.5) <9980365E-FADF-36CB-97CC-2530BB70BA8A> /System/Library/Frameworks/OpenCL.framework/Versions/A/Libraries/ImageFormats/unorm8_bgra.dylib
       0x10a1f8000 -        0x10a1f8ffe +cl_kernels (???) <660C0777-F0C5-4D42-9709-377F8610F652> cl_kernels
       0x10a5cd000 -        0x10a5d4fff  com.apple.CacheDelete (1.0 - 1) <B1800E38-6208-3E66-8D48-7A7A2F085EB0> /System/Library/PrivateFrameworks/CacheDelete.framework/CacheDelete
       0x10ab7d000 -        0x10ac5dff7  unorm8_rgba.dylib (2.4.5) <6FB16659-64C4-3D3C-B33F-7B8F073B4A16> /System/Library/Frameworks/OpenCL.framework/Versions/A/Libraries/ImageFormats/unorm8_rgba.dylib
       0x10ae45000 -        0x10ae45ffe +cl_kernels (???) <660C0777-F0C5-4D42-9709-377F8610F652> cl_kernels
       0x10ae49000 -        0x10ae49fef +cl_kernels (???) <54A560A7-7C6F-42F5-B3DA-6978472833EB> cl_kernels
       0x10ba3d000 -        0x10ba58ff3  com.apple.security.csparser (3.0 - 57031.40.8) <35475F97-6B31-3ED1-BB64-9FEC231883F7> /System/Library/Frameworks/Security.framework/PlugIns/csparser.bundle/Contents/MacOS/csparser
       0x10c45a000 -        0x10c45efff  com.apple.qldisplay.Generic (5.0 - 675.43) <6D99102E-6A85-3F5F-B819-3C890B321435> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuickLookUI.framework/Versions/A/PlugIns/Generic.qldisplay/Contents/MacOS/Generic
    0x7fff6841d000 -     0x7fff6845392f  dyld (353.2.4) <708E385E-50C6-32A3-983C-42E97BEE4346> /usr/lib/dyld
    0x7fff8c1af000 -     0x7fff8c1b5fff  libsystem_trace.dylib (72.20.1) <840F5301-B55A-3078-90B9-FEFFD6CD741A> /usr/lib/system/libsystem_trace.dylib
    0x7fff8c1db000 -     0x7fff8c1f7ff7  com.apple.pluginkit.framework (1.0 - 1) <D1A7F6E5-091B-30E7-852B-E866BF38A5AB> /System/Library/PrivateFrameworks/PlugInKit.framework/Versions/A/PlugInKit
    0x7fff8c1f8000 -     0x7fff8c242fff  com.apple.HIServices (1.22 - 523) <99ADA325-53C8-368E-A5FA-3F913CD2245A> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices
    0x7fff8c243000 -     0x7fff8c25eff7  com.apple.aps.framework (4.0 - 4.0) <EAC8C347-55F4-3769-995E-B140C95553F6> /System/Library/PrivateFrameworks/ApplePushService.framework/Versions/A/ApplePushService
    0x7fff8c25f000 -     0x7fff8c4a4ff7  com.apple.AddressBook.framework (9.0 - 1579) <A31956C5-AA13-35E6-B553-6BDF33F35103> /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook
  %2

[PowerWyrm]

Sounds ominous/promising...

Incidentally, have the monster power calculations been changed? I seem to get much higher danger feelings at low depths from things like early pits now. Just got "Omens of death haunt this place" at 250' from a creepy crawly nest. (Not that this is a complaint - I think it's probably actually more accurate, and it definitely makes the early levels seem more interesting.)

Well getting ganged up by multiple Mirkwood Spiders at 250' usually means certain death, so the feeling seems accurate

[Nomad]

Oh, cool. You're probably going to have to update again before 4.1, you understand. With monsters

Sounds ominous/promising...

Incidentally, have the monster power calculations been changed? I seem to get much higher danger feelings at low depths from things like early pits now. Just got "Omens of death haunt this place" at 250' from a creepy crawly nest. (Not that this is a complaint - I think it's probably actually more accurate, and it definitely makes the early levels seem more interesting.)

[Nick]

Quick update for my tile set: this now has tiles for all the new trap types and corrected mappings for the new object flavours so that potions are the right colour.

Oh, cool. You're probably going to have to update again before 4.1, you understand. With monsters

[Nomad]

Quick update for my tile set: this now has tiles for all the new trap types and corrected mappings for the new object flavours so that potions are the right colour.

[PowerWyrm]

The (charging) is a bug I thought I'd fixed.

IIRC when randomizing arts, activations are reset but not recharge time. See copy_artifact_data():

	/* Activations can come from the artifact or the kind */
	if (art->activation) {
		obj->activation = art->activation;
	} else if (kind->activation) {
		obj->activation = kind->activation;
	}

	if (art->time.base != 0) obj->time = art->time;

Should be:

	if (art->activation) {
		obj->activation = art->activation;
		obj->time = art->time;
	} else if (kind->activation) {
		obj->activation = kind->activation;
		obj->time = kind->time;
	}

[Nick]

Umm... I'm wearing the ring of 'Thurit' and I just found the ring of 'Thurit' again. So I have two identical rings of 'Thurit' now. Sangyhando dropped the first one on DL32. And I just found the duplicate on DL69 in a golem pit.

This is the February 27th build.

And just found another amulet I already have. I guess it bears mentioning that the game crashed and I reloaded it right before this happened. So it seems the game forgot the artifacts I have already found when it crashed. Angband always crashes; this is the first time I've experienced this after a crash.

Hm, thanks. Will look into it.

[Grotug]

Umm... I'm wearing the ring of 'Thurit' and I just found the ring of 'Thurit' again. So I have two identical rings of 'Thurit' now. Sangyhando dropped the first one on DL32. And I just found the duplicate on DL69 in a golem pit.

This is the February 27th build.

And just found another amulet I already have. I guess it bears mentioning that the game crashed and I reloaded it right before this happened. So it seems the game forgot the artifacts I have already found when it crashed. Angband always crashes; this is the first time I've experienced this after a crash.

[AnonymousHero]

These are a consequence of randomising rings, amulets and lights more - there's no longer a one-for-one with the standard special artifacts, so all sorts of things are possible. The (charging) is a bug I thought I'd fixed.

After all these years, I'm sure you have enough WIS+CON to persevere and even push back, but just in case: Don't listen to the haters, at least not exclusively. I mean, they may sometimes be right, but don't assume that they're right.

(... and that was... well, I'm not sure what that was. Hi, mom!)

[Nick]

The thing I like less is having 5 randart Rings of Firmament in the randart set. I liked the old system better (one randart per ring/amulet).


Since when can you get randart Lanterns? And it's "charging"...

These are a consequence of randomising rings, amulets and lights more - there's no longer a one-for-one with the standard special artifacts, so all sorts of things are possible. The (charging) is a bug I thought I'd fixed.