Curses feature branch

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Huqhox
    Adept
    • Apr 2016
    • 145

    Originally posted by Bogatyr
    Some quick ideas:

    "curse of the vampire": increased strength and/or speed, but take damage from all light sources (stronger the source the higher the damage) and when stepping on to lit squares (gives staff of darkness a use!)

    diamondskin: higher AC but amplified damage from sound/cold

    insane metabolism: increased speed but food consumption exponentially higher (no time even to rest fully without getting hungry/weak, must eat constantly).

    shadow curse: increased stealth but reduced visibility.
    Liking these (especially) the last two a whole lot
    "This has not been a recording"

    Comment

    • PowerWyrm
      Prophet
      • Apr 2008
      • 2986

      Currently, items that only differ by curses will stack. So don't pick up boots of speed [2, +10] (+10) (??) when you have boots of speed [2, +10] (+10) in your inventory
      PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

      Comment

      • PowerWyrm
        Prophet
        • Apr 2008
        • 2986

        Originally posted by Nick
        They are probably a little rare at the moment.
        There's 1/20 chance at considering adding a curse, but you get only one shot vs tval. If the pick is incorrect, no curse is added. This should give 1/(20*curse_max) chance of getting a sticky curse... and probably close to zero chance of getting something else. Maybe lower the initial chance, but make the pick guaranteed vs tval.
        PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

        Comment

        • PowerWyrm
          Prophet
          • Apr 2008
          • 2986

          The "stone" curse has no "time" value, so it never triggers.
          PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

          Comment

          • PowerWyrm
            Prophet
            • Apr 2008
            • 2986

            Originally posted by Nick
            Yeah, looks like I've broken random teleport - d_m has noticed it too.
            Just adding this at the end of do_curse_effect() should fix the problem for all curses with timed effects:

            Code:
            curse->obj->timeout = randcalc(curse->obj->time, 0, RANDOMISE);
            PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

            Comment

            • PowerWyrm
              Prophet
              • Apr 2008
              • 2986

              Originally posted by PowerWyrm
              Just adding this at the end of do_curse_effect() should fix the problem for all curses with timed effects:

              Code:
              curse->obj->timeout = randcalc(curse->obj->time, 0, RANDOMISE);
              Well that's still not working. It appears that the original timeout is set when a curse is appended (normal object gets cursed), but not when an already cursed item is generated. In this case, the timeout needs to be set when the object is created. The easiest way to fix that is to add the same code in copy_curse() inside the "randomise" part, which is called by ego_apply_magic() for ego curses and object_prep() for kind curses.
              PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

              Comment

              • Ingwe Ingweron
                Veteran
                • Jan 2009
                • 2129

                Not sure which branch the nightlies are now; I assume it is the curses branch.

                So, a couple bugs still around:

                1. kill a pass through walls monster, and sometimes their drop appears inside the wall. @ has to dig or stone-to-mud to get at the drop, and has to guess as to whether a drop occurred.

                2. Very odd to kill Sauron, get the message "... a magical staircase appears", BUT no staircase! @ had to deal with Angalacon and a Greater Balrog, summoned by Sauron before his death. Having done so, @ looks around for the staircase, but it is nowhere to be seen.

                Sorry, I forgot to get a savefile for either of these events.
                “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
                ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

                Comment

                • Ingwe Ingweron
                  Veteran
                  • Jan 2009
                  • 2129

                  Another bug in the nightlies...

                  The One Ring, retains the "??" even though identify scrolls reveal no new runes. "You do not know the full extent of this item's powers." But, everything seems known, including that it activates for bizarre things. Is it that @ is required to risk the Bizarre activation before knowing the item fully? Or even multiple activation until each possible bizarre activation is known?
                  “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
                  ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

                  Comment

                  • PowerWyrm
                    Prophet
                    • Apr 2008
                    • 2986

                    Originally posted by Ingwe Ingweron
                    Another bug in the nightlies...

                    The One Ring, retains the "??" even though identify scrolls reveal no new runes. "You do not know the full extent of this item's powers." But, everything seems known, including that it activates for bizarre things. Is it that @ is required to risk the Bizarre activation before knowing the item fully? Or even multiple activation until each possible bizarre activation is known?
                    I don't know if it's the same issue, but in my variant (which is roughly based on the latest code) jewelry doesn't get fully IDed until worn. Of course, that would mean equipping the One Ring to check.
                    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

                    Comment

                    • MattB
                      Veteran
                      • Mar 2013
                      • 1214

                      Can one ever know everything about The One Ring?

                      Comment

                      • Ingwe Ingweron
                        Veteran
                        • Jan 2009
                        • 2129

                        Originally posted by PowerWyrm
                        I don't know if it's the same issue, but in my variant (which is roughly based on the latest code) jewelry doesn't get fully IDed until worn. Of course, that would mean equipping the One Ring to check.
                        As I recall, the events occurred as follows:

                        1. Found The One Ring and picked it up.
                        2. Since @ was running with the birth option of all runes known, The One Ring when examined in the pack showed everything as known.
                        3. @ Wielded The One Ring.
                        4. Immediate Game CRASH.
                        5. Reopened game and wielded ring again. This time it shows with "??".
                        6. ?Identify show nothing needs to be learned, but The One remains "??".
                        “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
                        ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

                        Comment

                        • MattB
                          Veteran
                          • Mar 2013
                          • 1214

                          Originally posted by Ingwe Ingweron
                          3. @ Wielded The One Ring.
                          4. Immediate Game CRASH.
                          Well...naturally.

                          Comment

                          • AnonymousHero
                            Veteran
                            • Jun 2007
                            • 1393

                            Originally posted by MattB
                            Well...naturally.
                            On the upside OP is going to live forever!

                            EDIT: Or... wait. Is that an upside?

                            Comment

                            • Nick
                              Vanilla maintainer
                              • Apr 2007
                              • 9633

                              Originally posted by Ingwe Ingweron
                              Not sure which branch the nightlies are now; I assume it is the curses branch.
                              The feature branches have all been rolled into the nightlies now. This thread is still fine to report bugs on, or there are several other options

                              Originally posted by Ingwe Ingweron
                              So, a couple bugs still around:

                              1. kill a pass through walls monster, and sometimes their drop appears inside the wall. @ has to dig or stone-to-mud to get at the drop, and has to guess as to whether a drop occurred.

                              2. Very odd to kill Sauron, get the message "... a magical staircase appears", BUT no staircase! @ had to deal with Angalacon and a Greater Balrog, summoned by Sauron before his death. Having done so, @ looks around for the staircase, but it is nowhere to be seen.

                              Sorry, I forgot to get a savefile for either of these events.
                              If you do get a savefile for either of these, that would be very helpful.
                              One for the Dark Lord on his dark throne
                              In the Land of Mordor where the Shadows lie.

                              Comment

                              • Nick
                                Vanilla maintainer
                                • Apr 2007
                                • 9633

                                Originally posted by PowerWyrm
                                Well that's still not working. It appears that the original timeout is set when a curse is appended (normal object gets cursed), but not when an already cursed item is generated. In this case, the timeout needs to be set when the object is created. The easiest way to fix that is to add the same code in copy_curse() inside the "randomise" part, which is called by ego_apply_magic() for ego curses and object_prep() for kind curses.
                                Thanks for this analysis. There's a further subtlety - artifacts don't get other curse values randomised. So what I have done is make copy_curse work differently for new and copied objects.
                                One for the Dark Lord on his dark throne
                                In the Land of Mordor where the Shadows lie.

                                Comment

                                Working...
                                😀
                                😂
                                🥰
                                😘
                                🤢
                                😎
                                😞
                                😡
                                👍
                                👎