Angband 4.0 beta release

[Nomad]

It's not possible to pick up additional ammo when the inventory is full, even if you've got enough space in the quiver. (i.e. The quiver is allowed 40 missiles per inventory slot, but if you've only got 20 in there and try to pick up another 20, you get the 'You have no room' message despite the fact you should be able to hold that many without needing a second slot free for them.)

[AnonymousHero]

@nick: I just want to bring your attention to this, I'm not sure what the actual real-life impact is: If you compile using clang + "-fsanitize=address,integer,undefined", you'll hit several instances of undefined behavior, esp. regarding signed integer overflow. I'm not sure how serious these things are in practice, but I think there was some low-hanging fruit in the input handling code. (I think the memory leak errors that I experienced can be safely ignored -- AFAICT the "leaks" are things that will be freed at program exit by the OS.)

[Nick]

@nick: I just want to bring your attention to this, I'm not sure what the actual real-life impact is: If you compile using clang + "-fsanitize=address,integer,undefined", you'll hit several instances of undefined behavior, esp. regarding signed integer overflow.

I'm not currently set up for clang - can you be more specific ?

PS - the crash-on-drop bug is not fixed, but probably will be in the next update.

[Nick]

Update ecdb950 includes:

• Some fixes by PowerWyrm to dungeon generation
• Probably actual fix to the crash from dropping stuff or firing missiles
• Make all activations work, and fix their descriptions
• Make !Enlightenment fully detect objects again
• Remove bug which caused frequent crashes on level generation (usually after recall)

Also, I've been looking into digging, and it really looks like it's unchanged, but I will look further.

[Thraalbee]

Latest build is great. No bugs found on traps or recall but then I died and see that the Hall of fame text is broken, rank is fine (1) but Points, Gold and Turn count are all very high (300658682, 1143534363 and 386556937 in my dump

[AnonymousHero]

I'm not currently set up for clang - can you be more specific ?

PS - the crash-on-drop bug is not fixed, but probably will be in the next update.

diff --git a/src/ui-input.c b/src/ui-input.c
index 2963695..7a1a72c 100644
--- a/src/ui-input.c
+++ b/src/ui-input.c
@@ -1482,9 +1481,9 @@ bool key_confirm_command(unsigned char c)
                verify_inscrip[1] = c;

                /* Verify command */
                                check_for_inscrip(obj, verify_inscrip);
-               while (n--) {
+               if (n > 0) {
                        if (!get_check("Are you sure? "))
                                return FALSE;
                }

(Actually, now that I look at it again, this isn't actually UB, just weird since the post-decrement will cause n to wrap.)

Another thing: There are quite a lot of variable declarations that are missing an "extern" qualifier. AFAIUI this is bad practice and can easily lead to linkage problems. Examples include: "get_file" in ui-input.h, "text_mbcs_hook" in z-util.h and "get_angle_to_grid" in generate.h.

Here's an example UB:

z-rand.c:521:9: runtime error: signed integer overflow: 93535139268725 * 1103515245 cannot be represented in type 'long'
SUMMARY: AddressSanitizer: undefined-behavior z-rand.c:521

(Signed integer under-/overflow is UB.)

[MattB]

I've just recalled and ended up somewhere called 'Nowhere Town'?!!

[MattB]

I've just recalled and ended up somewhere called 'Nowhere Town'?!!

Just kidding, sorry, couldn't resist!

[Derakon]

Just kidding, sorry, couldn't resist!

You evil, evil man.

[Ingwe Ingweron]

Angband 4.0 dev ecdb950
1. Messages clear instantly. Always have to go to <ctrl>P to find out what happened.
2. Display when in Store and open the [e]quipment or [i]nventory window or [d]rop or [s]ell, the store contents and e/i window contents visually merge. There used to be a separation black border between the two. Without that border it’s harder to see.
3. An old bug that has been present in the previous versions too. The object display subwindow shows all objects encountered and still on the floor as "seen". Like the monster display subwindow, the objects should be separated into what @ can "see" and what @ is "aware" of.
4. Digging appears broken. E.g., dagger shown as clearing rubble in 13.0 turns takes 73 and 251 turns to clear rubble.
5. Picking locks appears broken. 57 turns and 114 turns to pick a lock on DL 1.
6. Inscriptions not working. ?Word of Recall inscribed with @r0!*. But when trying to read scroll 0, [r0] just lists the scrolls in inventory and asks “Read which scroll?” ?Identify inscribed @r1 works properly. Maybe the “!*” which is supposed to cause a confirmation request is the part that’s not working?
7. Crashed in the midst of pseudo-id. Several items dropped by Bullroarer were being identified under the pseudo-id while @ moved across the dungeon when the game crashed.

[Timo Pietilä]

In windows 7, if you start game, select open and then cancel and try to start new game sometimes doesn't refresh the screen so that race selection screen isn't visible.

Works most of the time though, so can't replicate the bug reliably.

[Timo Pietilä]

How do I change walls to solid blocks in 4.0 beta? Old font-win.prf changes don't work in 4.0.

[edit] nevermind, figured that out.

[Timo Pietilä]

possible bug: throwing flasks of oil don't harm monsters. I had my flasks pseudoID:t as {average}, Inspecting it noticed that I don't know the full extend of the item, throw it to scrawny cat and got message "...fails to harm scrawny cat" and "Scrawny cat is unharmed".

[Nick]

No update tonight, should be one tomorrow.

Everything I can measure is telling me digging and unlocking should be unchanged - I will continue to examine it, but at this stage I believe it is working as intended.

[Nick]

Looks like the necessary step was deciding it was working - digging is now fixed

Update c3a7bcd will be up shortly, with the digging fix, a minor fix to effect descriptions, and a fix to the silly numbers in the Hall of Fame.