Angband 3.3.2 - anything else to fix?

[Magnate]

Thanks to the infuriating regression bug in 3.3.1, I'll be releasing an RC of 3.3.2 in the next week or two. (In fact the regression bug is already fixed, but we're also going to try to fix the annoying NumPad problem on Windows.)

So, this is a call for any other irritating bugs or issues in 3.3.1 that you'd really like to see fixed in 3.3.2. I'm not talking about major issues like nerfing scumming or sorting out LOS - work is well underway on 3.4 (which won't fix those either). 3.3.2 will (I hope!) be the last in the 3.3 series, so it would be good to tidy up any minor irritations people have. I'm not guaranteeing that we'll be able to do that (some small problems require really complex fixing), but it would be good to know what bothers people about 3.3.1.

[Gorbad]

The 'invisible' walls issue in Vista. I think there were already some posters that had solutions for them, but a solution that works straight from the package will likely be appreciated.

(I Should probably try to avoid turning this thread into an Ubuntu PaperCuts like thread)

[fizzix]

I forget, are Ainur in 3.3 or are those still angels. If the Ainur are in, the knight templar really needs its name/description changed.

[Magnate]

No, 3.3.1 still has angels. And "papercuts" is exactly the right definition of what I'm looking for. I'm not sure the invisible walls issue is fixable by one person in one day, but I will ask the devteam if someone can provide one that doesn't break on any other Windows version.

Keep them coming.

[PowerWyrm]

Very minor thing... gold found in special rooms is described as "found in a vault". Trivial fix: replace ORIGIN_VAULT by ORIGIN_SPECIAL in vault_objects().

[Magnate]

Very minor thing... gold found in special rooms is described as "found in a vault". Trivial fix: replace ORIGIN_VAULT by ORIGIN_SPECIAL in vault_objects().

Won't this mean that items found in vaults are described as "found in a special room"? Or not?

Also, how do you ever see the origin of gold anyway, since it disappears when you pick it up??

EDIT: no, clearly not. Thanks for the catch.

[PowerDiver]

Thanks to the infuriating regression bug in 3.3.1, I'll be releasing an RC of 3.3.2 in the next week or two. (In fact the regression bug is already fixed, but we're also going to try to fix the annoying NumPad problem on Windows.)

So, this is a call for any other irritating bugs or issues in 3.3.1 that you'd really like to see fixed in 3.3.2. I'm not talking about major issues like nerfing scumming or sorting out LOS - work is well underway on 3.4 (which won't fix those either). 3.3.2 will (I hope!) be the last in the 3.3 series, so it would be good to tidy up any minor irritations people have. I'm not guaranteeing that we'll be able to do that (some small problems require really complex fixing), but it would be good to know what bothers people about 3.3.1.

I provided a patch maybe back in May, a long time ago anyway, that fixed noticing a brand on wield into quiver, and had a correct definition of {good}, and cleaned up a lot of code, and correct ego ID. More improvements I cannot remember any more, and Takkaria gave the patch thumbs up. If you are ever going to use it, you should do it now. Every change will make it harder to incorporate.

[Bill Peterson]

I've experienced a minor problem with the map window. As I move through the dungeon additional images of the PC are deposited onto the map image. Makes it a little confusing locating myself in the dungeon. This happens with the Bolt, Gervais and Nomad tiles, but not with the old tiles or text interface.

I'm running the 3.3.0 binary downloaded from here on Win7. Everything else regarding the graphics looks fine.

P.S. I just downloaded angband-win-3.3RC-197197f version and the problem's still there. I don't see any more recent version.

[Chud]

I've noticed a minor order-of-messages quirk when something dies amid other messages. For example:

You hit the Black Harpy.
Your hands stop glowing.
You hit the Black Harpy.
You have slain the Black Harpy.
The Black Harpy looks confused.

[d_m]

I provided a patch maybe back in May, a long time ago anyway, that fixed noticing a brand on wield into quiver, and had a correct definition of {good}, and cleaned up a lot of code, and correct ego ID. More improvements I cannot remember any more, and Takkaria gave the patch thumbs up. If you are ever going to use it, you should do it now. Every change will make it harder to incorporate.

Sorry, either I lost this patch or I didn't see it. If you can find it would you mind linking it here, or emailing it to d_m AT plastic-idolatry DOT com? Hopefully the relevant code hasn't mutated too much since then.

[Magnate]

I've experienced a minor problem with the map window. As I move through the dungeon additional images of the PC are deposited onto the map image. Makes it a little confusing locating myself in the dungeon. This happens with the Bolt, Gervais and Nomad tiles, but not with the old tiles or text interface.

I'm running the 3.3.0 binary downloaded from here on Win7. Everything else regarding the graphics looks fine.

P.S. I just downloaded angband-win-3.3RC-197197f version and the problem's still there. I don't see any more recent version.

Is this the problem described in http://trac.rephial.org/ticket/1495? Or something else?

In either case, I'm not able to fix this - I know nothing about the tiles code. But I will see if another dev can fix it.

[Magnate]

Sorry, either I lost this patch or I didn't see it. If you can find it would you mind linking it here, or emailing it to d_m AT plastic-idolatry DOT com? Hopefully the relevant code hasn't mutated too much since then.

I don't remember it either - I remember fixing {good} myself, so I obviously didn't know someone else had done it. I do have a vague memory of someone mentioning it on IRC I think (or maybe here), but don't think I ever saw the actual patch. May was before we got serious about pull requests (if were even on github by then).

[Magnate]

I've noticed a minor order-of-messages quirk when something dies amid other messages. For example:

You hit the Black Harpy.
Your hands stop glowing.
You hit the Black Harpy.
You have slain the Black Harpy.
The Black Harpy looks confused.

That, I'm afraid, is entirely non-trivial to fix. We do have a ticket for it (#1502), but it's something for 3.4 or maybe even 3.5/4.0 - it's a lot of work.

[Magnate]

Ok, Angband 3.3.2rc1 is now available from http://buildbot.rephial.org/builds/3...RC-f723066.dmg and d_m to insert Windows link later.

- monsters are slowed and hasted properly again
- the numpad issues on Windows *might* be fixed (feedback welcome)
- the origin of gold in special rooms is correct

If any of these aren't working for you, or you think there are other easily fixable papercuts that ought to go in, please say so in this thread.

[PowerDiver]

Sorry, either I lost this patch or I didn't see it. If you can find it would you mind linking it here, or emailing it to d_m AT plastic-idolatry DOT com? Hopefully the relevant code hasn't mutated too much since then.

It should be

https://github.com/eddiegrove/angband

[edit]

Oh, I should point to a commit I guess

https://github.com/eddiegrove/angband/commit/5e82e576bc1e34dff004cb3b8e9f6fcb733a1c75

[edit again]
If you have questions, send email rather than notices here. I've mostly given up on the way V is heading, so I don't keep up with oook more than glancing once or twice a week.