Angband 4.2.4

[animal_waves]

Thanks that was helpful!

It seems the combo with the CTRL modifier interpret the numpad key as as number while the combo with the SHIFT modifier interpret the same key as a direction, so that explains the bug I guess.

Cfr. attachment: I typed CTRL-6 to clear a rubble, then SHIFT-6 to run to the right.

I hope it can help!

[backwardsEric]

It seems I can't run with the SHIFT-<numpad> when using the X11 frontend (tried with numlock enabled & disabled), is it normal?
Any advice on how to debug this (via a log/verbose argument or whatever external tool)? I'm using an Azerty keyboard, that may have something to do with it...
Weird thing is CTRL-<numpad> works for interacting with doors, traps, etc.

There is the debugging command to display the last 8 keystrokes that were relayed from the frontend. To use that press ctrl-a followed by L (it's also accessible via the Enter menu: Enter -> Hidden -> Debug mode commands -> Query -> Keystroke log). Since enabling the debugging commands marks the save file, it's probably best to try that with a character that you're not planning to submit to the ladder.

Sil's and Frogcomposband's key handling in the X11 front end look fairly similar. vanilla's handling changed around version 3.0.7 and added special case handling of the keypad.

[animal_waves]

X11 frontend &amp; shift-numpad to run does not work?

It seems I can't run with the SHIFT-<numpad> when using the X11 frontend (tried with numlock enabled & disabled), is it normal?
Any advice on how to debug this (via a log/verbose argument or whatever external tool)? I'm using an Azerty keyboard, that may have something to do with it...
Weird thing is CTRL-<numpad> works for interacting with doors, traps, etc.

I already tried to change the keyboard layout of my desktop environment as well as exporting the KEYMAP variable to the angband binary with no luck.

It works fine on other variants (Sil-Q & FCB) using X11.

[edit]
Unrelated, but if someone know if it's possible for the SDL2 fronted to use system fonts instead of those fonts shipped with the game I'll be interested to know how!
[/edit]

[Grotug]

The character died a most *stupid* death (arkenstone, legendary stealth, x4 +21 xbow, fast diving)

I was playing hobbit ranger; not sure if race/class combo matters for this bug. I’m sorry, I should have made a copy of the save file. It’s a little tricky to reproduce because you also need to be wearing an unidentified ring of resist poison while wearing the unidentified amulet of weaponmastery. But the bug should trigger with any ring with unknown resistances (such as fire/cold ring) and an unID’d amulet. Although with a ring of cold/fire I guess you’ll need to be breathed on by cold or fire or maybe quaffing a rHeat or rCold potion would trigger the bug. At any rate I’ll try to reproduce it.

Note: the bug won’t trigger if the amulet of weaponmastery (or whatever amulet you wear that doesn’t have rCold, rFire or rPois) or the ring are fully ID’d. Both items need to be un ID’d).

[backwardsEric]

Bug report: items sometimes falsely display a resistance they do not have. If you look in the character resistances sheet it shows the item does not have the resistance even though the item says it does.

Could you post a compressed savefile for a character affected by the bug? Trying to reproduce it with the debugging commands (new druid character, advance to maximum level, get and equip amulet of weapon mastery and ring of resist poison, cast resist poison) didn't show resist poison for the amulet on the character sheet.

[Grotug]

Bug report: items sometimes falsely display a resistance they do not have. If you look in the character resistances sheet it shows the item does not have the resistance even though the item says it does.

In game example: I put on a bronze amulet which, due to my knowledge of the game, I recognized as an amulet of Weaponmastery, since it has +2 strength, a slay, and sustains Strength and Constitution and prevents paralysis. However, while I was wearing this amulet of weaponmastery, I had also just found a Jewelled ring. Since the ring did not have any abilities on it I cast "resist poison" spell which identified the ring as a ring of resist poison. 'Cool!' I think to myself. I then look again at my bronze amulet to see that it also says it resists poison. Hmm! Anyway, obviously a bug. This happened once before with an amulet of resist acid I believe. It said it also resisted cold, and so I thought I had an amulet of resistance, but I didn't, because I knew the rune of resist lightning and the amulet didn't resist lightning. Once I fully id'd the amulet (which I think was resist acid) it stopped showing that it resisted cold. I suspect that when I learn the rune of rDisenchantment and the "weaponmastery is fully ID'd that it will stop showing that it resists poison. (I'll report back).

[PowerWyrm]

Feather falling halves damage from lava. Shouldn't walking on lava identify the flag?

[PowerWyrm]

Out of curiosity, is that because that environment has a default external command configured to play the MP3 file (or perhaps it's related to this part of the changes list for SDL Mixer 2.0.3: "Fixed regression where Mix_Init() would return 0 for available music formats")? In any case, trying to Mix_Init() to workaround the resource leaks doesn't seem useful.

I'm using SDL Mixer 1.2 so it's probably an error in that version. I guess Mix_Init returns 0 not only when the format is not supported, but also when the format doesn't require a call to Mix_Init.

[backwardsEric]

The problem is that reading MP3 using the SDL Mixer library doesn't require calling Mix_init. In fact, on my WinXP VM, calling Mix_init(MIX_INIT_MP3) returns 0 (Does not support the required music formats) while I can play with sounds using MP3 files perfectly.

Out of curiosity, is that because that environment has a default external command configured to play the MP3 file (or perhaps it's related to this part of the changes list for SDL Mixer 2.0.3: "Fixed regression where Mix_Init() would return 0 for available music formats")? In any case, trying to Mix_Init() to workaround the resource leaks doesn't seem useful.

[PowerWyrm]

As for the sound format support, the added call to Mix_init() was to check that the SDL Mixer library has MP3 support because that's what Vanilla's and FAangband's sound files use.

The problem is that reading MP3 using the SDL Mixer library doesn't require calling Mix_init. In fact, on my WinXP VM, calling Mix_init(MIX_INIT_MP3) returns 0 (Does not support the required music formats) while I can play with sounds using MP3 files perfectly.

If there are file descriptor leaks, it must be another non related issue. For example, load_sample_sdl() calls Mix_LoadMUS() and stores the return value in the "loaded" boolean. Here we can't tell samples not loaded from samples where loading caused an error, maybe the boolean should be changed to an enum (not loaded, loaded, error). In case an error occured and the game tries to reload the sample, the "error" state should tell that the sample cannot be loaded and prevent calling Mix_LoadMUS() again.

[PowerWyrm]

Effect READ_MINDS returns false if no monster with a mind is found, which is not the same as any other detection/mapping effect which always return true. This has a weird side effect of preventing putting the effect on any object, because if there's no monster with a mind around, the object will not be consumed.

[PowerWyrm]

There were two calls to open_audio_hook(), one after the other, in sound-core.c. That change you referenced only removed one of them.

Check the change, that's not the case. First line is to check if the hook (pointer) exists:

if (!hooks.open_audio_hook) return 1;

Second line actually calls the hook and checks the return value:

if (!hooks.open_audio_hook()) return 1;

These are not the same calls. Removing the second line actually removes the call to open_audio_hook() and only leaves the pointer check.

[backwardsEric]

Commit a318f61 removed the call to open_audio_hook(), surely this disabled sound completely no?

Also if you use ogg files and ogg format is supported but not mp3 format, code in open_audio_sdl() will now check for mp3 and reject sound instead of loading the ogg files.

There were two calls to open_audio_hook(), one after the other, in sound-core.c. That change you referenced only removed one of them. As for the sound format support, the added call to Mix_init() was to check that the SDL Mixer library has MP3 support because that's what Vanilla's and FAangband's sound files use. If a variant uses other formats, then it's likely best to 'formats = ...;' line to reflect the formats that the variant expects the SDL mixer to support or to use 'formats = 0;' to disable checking for any specific format (at the risk of triggering file descriptor leaks, see https://github.com/angband/angband/issues/5313 , if the sound system later tries to load a format not supported by the SDL mixer).

[PowerWyrm]

Commit a318f61 removed the call to open_audio_hook(), surely this disabled sound completely no?

Also if you use ogg files and ogg format is supported but not mp3 format, code in open_audio_sdl() will now check for mp3 and reject sound instead of loading the ogg files.

[PowerWyrm]

Item ignoring setup is bugged, the tags are incorrect. Commit 3126eb4 missed a I2A -> all_letters_nohjkl change in tag_options_item() and added a pointless menu.selections in do_cmd_options_item() since the menu is managed by a menu_iter.

(expected: a-b-c-d-e-f-g-i-m-n-o-p-q-r-s-t-u-(blank)-Q-E-T; displayed: a-b-c-d-e-f-g-i-m-n-o-p-q-r-s-t-u-(v)-w-x-y)