Help me make my new variant! (please!)

[will_asher]

Okay, cool.
I wanted to avoid the complication of using Github and just use the downloaded source, but I'll try it if it's that important.

[Pete Mack]

The benefit of github is you can just go grab bug fixes with almost no effort. It will supply a log of changes to the original that you can pick an choose between. You can of course do this with a local git, too, but that means you need to keep pulling V code, and there's no convenient GUI.

[will_asher]

Now I'm tempted to just wait till the bugs are fixed...
but I know, github will be easier once I learn it.

[will_asher]

Okay, I just forked myself.
(sorry, but that sounds really bad, but that's what the instructions told me to do.)

I'm looking at the "Building with Visual Studio 2019" file that comes with the Angband code download.

If I use github, do I still need Visual Studio also?
ie. does github have a whatdoyoucallit ...IDE built in?

[Nick]

I'm looking at the "Building with Visual Studio 2019" file that comes with the Angband code download.

If I use github, do I still need Visual Studio also?
ie. does github have a whatdoyoucallit ...IDE built in?

I guess you're using the github client for windows? I don't know for sure, but I would guess it doesn't have an IDE built into it. If you're happy with Visual Studio, I would use that - there is a github extension for connecting the two (I haven't ever used this, I just googled it).

[Pete Mack]

It's published by github, and yes it works or did when I tried it some years ago. I also used the PowerShell plug in for pulling updates and the like.

[will_asher]

I got it to compile. that's one step.

But I'm already stuck with a bug trying to get it to run. I get a "bad f-flag: " error with a bunch of garbage after it. I made sure all the new flags I plan to add are still commented out in monster.txt and monster-base.txt (even though I already added them to list-mon-race-flags.h). I double and triple checked. I can't figure out what's wrong. Could adding a new monster base do this? Is there a max number of monster bases somewhere? (if so, I can't find it.)

(I'm not going to ask for help for every little thing. Part of the reason I post here for help is sometimes it helps me to think of something when I write out the question.)

[wobbly]

I spied enough to find your github, which contains a fork of 4.2.2 but nothing else. It's going to be easier to see whats going wrong if someone can see the actual code and more importantly the commits of what you actually changed.

[Nick]

This message means that somewhere in the datafile being parsed there was a flag that was not in the list of all the flags. As wobbly says, if people can see your code it's easier to find problems.

[will_asher]

I gotta figure out how to sync the github with what's on my computer...
...Okay, I think I updated my github with my changes, but I don't know how to change the name of my github so that it's clear that it's a variant. I don't get github yet.
EDIT: no it didn't sync. I'm still figuring that out.

Anyway, I barely changed anything so far. It's parsing monster_base.txt, and I looked over that file like 6 times and didn't find anything wrong with it.

Also, Pete implied that there's a relatively easy way to get new changes made to V and add them to my fork. How do I do that?
Is there some quick github tutorial somewhere? I could use a glossary for all the lingo (Push, pull, commit, stash, repository, etc).
EDIT3: I found a github glossary, but it doesn't have "stash".

EDIT2: (learned the difference between push and pull) I told VS to push changes to github, but it didn't update anything...
EDIT4: Okay, I got it to sync now.

https://github.com/will2asher/RubberBand

[wobbly]

You've got typos in your flags, compare:

# Mostly slow with lots of hitpoints and armor
name:golem
glyph:g
pain:1
flags:EMPTY_MIND | CLEAR_WEB | NONLIVING
flags:NO_FEAR | NO_CONF | NO_SLEEP | NO_STUN
desc:Golem

# mostly very deep
name:wall monster
glyph:#
pain:1
flags:COLD_BLOOD | EMPTY_MIND
flags:BASH_DOOR | CLEAR_WEB | NON_LIVING
flags:IM_POIS | NO_CONF | NO_SLEEP | NO_FEAR
desc:Wall Monster

Also that true_sight flag in object properties isn't defined in list-object-flags.h

[will_asher]

Thanks. to think I looked through the file as many times as I did and didn't see that...

[will_asher]

ugh. still won't run.
Now it's saying there's a parse error in dungeon_profile line 60 but I haven't touched dungeon_profile.txt and I don't see anything wrong there.

[backwardsEric]

Now it's saying there's a parse error in dungeon_profile line 60 but I haven't touched dungeon_profile.txt and I don't see anything wrong there.

From the source on GitHub, you added "cutoff:..." lines for the profiles. Those will cause errors until you change the parsing in src/generate.c. The cutoff parameter mentioned in the comments is the last value in "room:..." lines within a profile.

[wobbly]

ugh. still won't run.
Now it's saying there's a parse error in dungeon_profile line 60 but I haven't touched dungeon_profile.txt and I don't see anything wrong there.

You didn't deliberately change it, but you did in fact change it. In fact you accidentally changed a whole bunch of files no doubt, take a look at the file list in this commit:

https://github.com/will2asher/RubberBand/commit/820fbec145a3926edc7c43fb5271eef4255a0a49#diff-1ee747d08cd0541b263a7a0c4dcd7a2e230a5fdf7d59db57d55ab654b8bf0c2e

As far as I can see you've:

downloaded a copy of angband
Nick has updated dungeon_profile.txt
you've uploaded the older version of dungeon_profile.txt