FAangband 1.4

[LostTemplar]

I found an old bug in FAangband, also present in your last version
exactly the same in randart.c and jewel.c

@@ -2836,8 +2836,8 @@ static void j_remove_contradictory(object_type *o_ptr)
     }
   for (i = 0; i < MAX_P_BONUS; i++)
     {
-      if ((o_ptr->bonus_stat[i] > 6) && (i != P_BONUS_SPEED))
-	o_ptr->bonus_stat[i] = 6;
+      if ((o_ptr->bonus_other[i] > 6) && (i != P_BONUS_SPEED))
+	o_ptr->bonus_other[i] = 6;
     }
   if ((o_ptr->flags_curse & CF_NO_TELEPORT) && 
       ((o_ptr->activation = ACT_RANDOM_TELEPORT1) ||

I found it after it start giving segfault after upgrading to gcc 4.8
I wonder how a code with such thing could have worked for such a long time without any troubles.

[Nick]

I found it after it start giving segfault after upgrading to gcc 4.8
I wonder how a code with such thing could have worked for such a long time without any troubles.

Excellent. thanks. I guess it survived because mostly it was running off the end of bonus_stat into bonus_other, and mostly that value was <6, so it rarely tried to overwrite.

[LostTemplar]

Most likely yes. And optimization screw something and it overwritten some pointer maybe instead.

[AnonymousHero]

Yay "undefined behavior".

EDIT: ... at least it didn't delete all the user's files.

[clouded]

Is trap detection with rods not 100% any more?
Zapped a rod and detected a murder hole some 8 steps north from my position, then made 6 steps to the north and stumbled into a shimmering portal, which clearly should have been within the detection radius?!

Hm, I just noticed something similar to this. I was inside of a vault, fully detected and something blanked my mind. I had to teleport out and make my way back, but when I detect traps again outside the vault the map doesn't update with the traps until they get into vision.

[Nick]

Hm, I just noticed something similar to this. I was inside of a vault, fully detected and something blanked my mind. I had to teleport out and make my way back, but when I detect traps again outside the vault the map doesn't update with the traps until they get into vision.

Thanks. I'm having trouble tracking this one down, and this gives me a starting point.

[Nick]

Hm, I just noticed something similar to this. I was inside of a vault, fully detected and something blanked my mind. I had to teleport out and make my way back, but when I detect traps again outside the vault the map doesn't update with the traps until they get into vision.

All right, this is pretty funny. In fact, the traps remain detected after amnesia, and you can 'l'ook at them, even though you can't see them. So this may be a different bug to the other one, but certainly knowledge of traps needs examination.

[Nick]

FAangband 1.4.2

Version 1.4.2 is now available from all the usual places (downloads page, variants tab). This is mostly a bugfix release, with also quite a bit of underlying code restructure as the whole V maintainer thing encourages me to align codebases as mush as possible.

One noticeable change is a better menu for choosing game modes (formerly known as birth options); the game also now moves from the splashscreen to the news screen without requiring a keypress. And The Complainer gets some new complaints

Bugs fixed include:

• Object descriptions contain full curse and curse removal info
• Perfectly balanced weapons ID properly
• Player can no longer move through the lava unharmed by saying they don't want to
• Various issues with shapechange from chaos are fixed
• Some tile allocations have been corrected
• Trap visibility issues after amnesia fixed
• Door placement on dungeon generation works properly now (2-year-old bug finally fixed)
• Trap detect edge drawing updates immediately, and is complete
• Objects meant to be light (weight) now are, instead of giving permanent light
• Items bought from a store still show their curses once bought
• Trap setting can be chosen as an ability by warriors, rangers and druids again
• Detection animation doesn't leave map errors

I actually don't know of any remaining bugs

[Mondkalb]

The Complainer complains about caps that look like gloves ... Fortunately they don't anymore.

Also, that's just mean :

[getter77]

Congrats on yet another release!

[debo]

The Complainer complains about caps that look like gloves ... Fortunately they don't anymore.

Also, that's just mean :

From what I've learned thus far of him, these boots are sort of the perfect expression of Nick's personality and approach to game design.

[HugoVirtuoso]

The Complainer complains about caps that look like gloves ... Fortunately they don't anymore.

Also, that's just mean :

That's just...sadistic.

[Nick]

I suspect Leon Marrick is responsible for Boots of Pitiless Torment - this will not come as any surprise to those familiar with his body of work. I merely aim to learn at the feet of the master...

[Arralen]

Version 1.4.2 is now available ...
I actually don't know of any remaining bugs

Why? Why?
Each time I get an @ to level 25 (and don't have it killed in some horrible way well before), you release a new version, and I never figure out how to move over all the settings together with the savegame, so I start to do the whole tweaking process again. And when I'm done, I just move on with the last test character ... to level 25 ...


About the game settings formerly known as birth options ... up-/down arrows let you navigate, right-arrow toggles the option (text should tell you that, instead of "toggle options" .. but how?), but left-arrow takes you to the next screen, instead of toggling the option off again.
This is counter-intuitive, and somewhat collides with the seperate entry "accept current modes".

Havent got any further, because I really want to migrate the settings and savegame from 1.41 ... maybe I can make it to lvl 35 then

[Nick]

Why? Why?

It's called commitment to (annoying) my players.

Savefiles from 1.4.1 should just load.

About the game settings formerly known as birth options ... up-/down arrows let you navigate, right-arrow toggles the option (text should tell you that, instead of "toggle options" .. but how?), but left-arrow takes you to the next screen, instead of toggling the option off again.
This is counter-intuitive, and somewhat collides with the seperate entry "accept current modes".

Yes, agreed, that is a bit unintuitive. I will write it up as a bug

For now, I recommend not using either left or right arrow on that screen - enter to toggle, escape to move back, select accept (h) to move forward.