Current master post-4.2.1

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Nick
    Vanilla maintainer
    • Apr 2007
    • 9637

    The github release page has an updated build with the change to auto_more referred to in this thread.

    Unless I hear of a good reason in the next few days, I plan to release 4.2.2 this weekend. So all the people who delight in finding bugs just when I think they're all done, get your skates on
    One for the Dark Lord on his dark throne
    In the Land of Mordor where the Shadows lie.

    Comment

    • Cuboideb
      Adept
      • May 2020
      • 196

      Great news!

      BTW, the last change (auto-more) is a bit drastic for Android. One line messages are handy for checking objects on the floor, even when auto-more is on. Could it be tweaked in some way? Thank you!

      Comment

      • Nick
        Vanilla maintainer
        • Apr 2007
        • 9637

        Originally posted by Cuboideb
        BTW, the last change (auto-more) is a bit drastic for Android. One line messages are handy for checking objects on the floor, even when auto-more is on. Could it be tweaked in some way? Thank you!
        How about if printing messages to the top line is suppressed when auto_more is on and there is a subwindow open with messages?

        I can always revert this change completely if it is causing problems - here is the discussion about the change before it was made.
        One for the Dark Lord on his dark throne
        In the Land of Mordor where the Shadows lie.

        Comment

        • Nick
          Vanilla maintainer
          • Apr 2007
          • 9637

          Originally posted by Nick
          Originally posted by Ingwe Ingweron
          Potential Bug on the Character Information Screen: Upon @ contributing a helm with an unknown curse to the Armorer, @ learned the rune of impair mana recovery curse. However, the "ImpSP" line on the character information screen remains greyed out. Shouldn't it turn white after learning this curse?
          This is technical, but I believe correct. The player learns the impair mana recovery curse, but not that that curse imparts the IMPAIR_MANA flag.
          If you (or anyone) think that this is the wrong behaviour for selling cursed objects, backwardsEric has provided a patch to change it so that all properties of the curse are learned. Opinions welcome
          One for the Dark Lord on his dark throne
          In the Land of Mordor where the Shadows lie.

          Comment

          • Cuboideb
            Adept
            • May 2020
            • 196

            Originally posted by Nick
            How about if printing messages to the top line is suppressed when auto_more is on and there is a subwindow open with messages?
            If the android port is the only that has problems I can manage easily, because I use a slightly modified copy of the sources. The ncurses port comes to my mind, it's still active?

            Comment

            • Pete Mack
              Prophet
              • Apr 2007
              • 6883

              Yes, I occasionally use nCurses.
              Edit. Damn autocorrect
              Last edited by Pete Mack; February 25, 2021, 20:13.

              Comment

              • Ingwe Ingweron
                Veteran
                • Jan 2009
                • 2129

                Originally posted by Nick
                If you (or anyone) think that this is the wrong behaviour for selling cursed objects, backwardsEric has provided a patch to change it so that all properties of the curse are learned. Opinions welcome
                It can go either way. Guess that one property is just incredibly rare to learn, which is why I noticed it.
                “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
                ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

                Comment

                • Nick
                  Vanilla maintainer
                  • Apr 2007
                  • 9637

                  New build on the github release page, with two small fixes:
                  • Correction of some errors in randart generation, thanks PowerWyrm
                  • Slight fix to quiver counting, thanks David Medley for reporting and backwardsEric for fixing
                  This should be ready to go for 4.2.2 now, I think. On the auto_more question, I can't see why anyone would use auto_more if they don't have a message window open - please let me know if there is a good reason, and I'll just revert the whole thing.
                  One for the Dark Lord on his dark throne
                  In the Land of Mordor where the Shadows lie.

                  Comment

                  • Cuboideb
                    Adept
                    • May 2020
                    • 196

                    Originally posted by Nick
                    This should be ready to go for 4.2.2 now, I think. On the auto_more question, I can't see why anyone would use auto_more if they don't have a message window open - please let me know if there is a good reason, and I'll just revert the whole thing.
                    It's a silly thing. In the android port there isn't much place for the messages subwindow, but auto_more saves a lot of presses. It's useful to see the last message for inspecting the floor. Of course, sometimes I have to trigger ^P to see the missing messages.

                    Keep the change, I can comment that line in the port sources. There is no need to write a complex solution for just that line.

                    Comment

                    • Nick
                      Vanilla maintainer
                      • Apr 2007
                      • 9637

                      Originally posted by Cuboideb
                      It's a silly thing. In the android port there isn't much place for the messages subwindow, but auto_more saves a lot of presses. It's useful to see the last message for inspecting the floor. Of course, sometimes I have to trigger ^P to see the missing messages.

                      Keep the change, I can comment that line in the port sources. There is no need to write a complex solution for just that line.
                      Excellent, thanks
                      One for the Dark Lord on his dark throne
                      In the Land of Mordor where the Shadows lie.

                      Comment

                      • DavidMedley
                        Veteran
                        • Oct 2019
                        • 1004

                        I saw this mentioned before, but now that it's happened to me I actually give a shit...

                        Fighting an Ancient Green with double poison resist and the foul worm down to 4 stars, it breathes its poisonous vapor on me.

                        You resist the effect!
                        The stench sickens you.
                        You feel very sickly.
                        The resisted effect must be the poisoned status effect. I think the sickens/sickly are the same thing, which is reduced CON. I only took 9 HP of damage!

                        This seems... off...
                        Please like my indie game company on Facebook! https://www.facebook.com/RatherFunGames

                        Comment

                        • Nick
                          Vanilla maintainer
                          • Apr 2007
                          • 9637

                          Originally posted by DavidMedley
                          I saw this mentioned before, but now that it's happened to me I actually give a shit...

                          Fighting an Ancient Green with double poison resist and the foul worm down to 4 stars, it breathes its poisonous vapor on me.



                          The resisted effect must be the poisoned status effect. I think the sickens/sickly are the same thing, which is reduced CON. I only took 9 HP of damage!

                          This seems... off...
                          OK, new update is up which fixes this. Still some possible issues with throwables in the inventory/quiver.
                          One for the Dark Lord on his dark throne
                          In the Land of Mordor where the Shadows lie.

                          Comment

                          • jevansau
                            Adept
                            • Jan 2009
                            • 200

                            Any chance of improving the max depth for randarts? Tends to be way too low for lights in particular.

                            Comment

                            • Pete Mack
                              Prophet
                              • Apr 2007
                              • 6883

                              There is a minor bug in rune id that shows ? symbols on the character abilities for S.Inv and ESP even though it is clear the equipment does not have them.
                              Attached Files

                              Comment

                              • Pete Mack
                                Prophet
                                • Apr 2007
                                • 6883

                                jevensau--
                                I don't see how, since (say) every wooden torch after depth 40 would then be an artifact and therefore obvious.

                                Comment

                                Working...
                                😀
                                😂
                                🥰
                                😘
                                🤢
                                😎
                                😞
                                😡
                                👍
                                👎