Preparation for 4.1 release

[Ingwe Ingweron]

As before, I now believe I have got all the bugs. Please let me know if I'm wrong about this.

Another minor bug. The fix for "rolls underfoot" is good, but not perfect. If one "looks" at the square one is told the number of objects, then a further action will reveal the list of those objects so you can decide what to do. The number of objects given does not match the number of objects listed, assumedly because the ignored "rolls underfoot" items are being counted for the number of objects information.

EDIT: NEVERMIND -- It was me being an idiot. The reason for the limited list was the @'s pack was too full, so only duplicate pack items were available for pickup. Duh!

[Huqhox]

The point is, it is a change that was introduced by the fix for fire IMMUNE monsters being able to route-find past lava. Previously, a non-immune monster could not be pushed onto lava, only an immune monster could cross it (albeit with route-finding problems). Now a non-immune monster is found standing on lava (and also doesn't appear to take any damage for doing so).

To my mind, this is a bug.

They should certainly take damage from standing on the lava (and ideally seek to move away from it immediately). But I don't think it's a bug that they end up there

[Gwarl]

Can you have players interact with the server via screen or some similar utility? Then the angband process always has a terminal to talk to, and the player connects to that terminal rather than to Angband directly. You can also take over screen processes when players leave and do anything you want to them, without relying on panic anything.

Oh. Hrm. That's interesting.

[Nomad]

As before, I now believe I have got all the bugs. Please let me know if I'm wrong about this.

Still this one outstanding:

The selling bug where shopkeepers always give you the correct money for unidentified items yet react as if they'd ripped you off and got a bargain is still in effect.

Otherwise all looking good now, as far as I can see!

[Ingwe Ingweron]

In the latest nightly, after killing Morgoth, for kicks @ donned the Massive Iron Crown, wielded Grond, and descended the stairs. Instant CRASH. Idiot, me, did not save the game prior to descending. I will try to reproduce it with a savefile, if I can.

[Nomad]

Oops, looks like this "seeing through doors" issue is back/still happening:

[TT][BC=black][COLOR=white]
                                                                                
[COLOR="#00FFFF"]High-Elf[/COLOR]                                                                        
[COLOR="#00FFFF"]Swordsman[/COLOR]                                                                       
[COLOR="#00FFFF"]Warrior[/COLOR]                                                                         
LEVEL [COLOR="#00FF00"]    14[/COLOR]                                                                    
NXT [COLOR="#00FF00"]     156[/COLOR]                                                                    
AU [COLOR="#00FF00"]     2142[/COLOR]                                                                    
[COLOR="#C0C0C0"]|[/COLOR][COLOR="#804000"]}[/COLOR][COLOR="#606060"]=[/COLOR][COLOR="#00FFFF"]=[/COLOR] [COLOR="#C08040"]~[/COLOR][COLOR="#0040FF"][[/COLOR]  [COLOR="#808080"]][/COLOR][COLOR="#C08040"]]][/COLOR]                                                                    
STR:  [COLOR="#00FF00"] 18/30[/COLOR]                                                                    
INT:  [COLOR="#00FF00"]    11[/COLOR]                                                                    
WIS:  [COLOR="#00FF00"]     7[/COLOR]                                  [COLOR="#00FFFF"]h[/COLOR]                                 
DEX:  [COLOR="#00FF00"] 18/50[/COLOR]                     #############[COLOR="#C08040"]+[/COLOR]##                               
CON:  [COLOR="#00FF00"]    13[/COLOR]                     .............<.#                               
                                 ########.......#                               
Cur AC [COLOR="#00FF00"]   51[/COLOR]                            ####..@.#                               
HP [COLOR="#00FF00"] 173[/COLOR]/[COLOR="#00FF00"] 173[/COLOR]                               ###..#                               
                                             #...                               
                                             #..                                
[[COLOR="#00FF00"]**********[/COLOR]]                                                                    
                                                                                
                                                                                
                                                                                
750' (L15)                                                                      
             LF:[COLOR="#0040FF"]2[/COLOR]-?                                                             
[/COLOR][/BC][/TT]

Savefile attached this time, in case it's helpful.

[Nick]

Do you consider it a bug for non-fire immune monsters to be pushed onto lava when non-lava spaces are available for them? Do you consider it a bug for non-fire immune monsters to exist on lava squares without apparently taking any damage? If so, these are two bugs.

Probably not (I don't think the pushed monster gets a say in it) and yes.

[Nick]

You could panic save to different location. Attempt to load panic-save file if it exists. If that load fails, load the default (auto-save) file. If it succeeds, move it to the default location, else unlink it.

That sounds sensible - I will look into it, although it's now less urgent because...

It was g8886dc4.

...that was before I removed the probably cause of the level generation crashes. This is good news, because I now know of no other crash bugs. Except...

In the latest nightly, after killing Morgoth, for kicks @ donned the Massive Iron Crown, wielded Grond, and descended the stairs. Instant CRASH. Idiot, me, did not save the game prior to descending. I will try to reproduce it with a savefile, if I can.

...this one.

[Nick]

Savefile attached this time, in case it's helpful.

Thanks, enormously helpful. Now fixed in development.

[Ingwe Ingweron]

Not a bug, but it is ironic when a "blessed" weapon is {cursed}.

[Pete Mack]

Bring back the warrior's extra blow. The way things stand now, Half-Troll warrior is a huge drag. I'm stuck using Aglarang when I have lots of nice heavy weapons at home. This just seems like bad role-playing. A half troll warrior should be able to use a heavy club.

[Ingwe Ingweron]

Probably not (I don't think the pushed monster gets a say in it) and yes.

So, pushed past now really means swapped places with? It used to be that pushed monsters didn't necessarily swap places with the pusher if other squares were available for the pushee (not lava). Similar to @ nimbly dodging falling debris. But maybe I'm misremembering. In any event, those Vampires standing on lava should be taking massive damage, they are, after all, particularly susceptible to fire. But it looks like they are standing on the lava with impunity.

[Nick]

So, pushed past now really means swapped places with? It used to be that pushed monsters didn't necessarily swap places with the pusher if other squares were available for the pushee (not lava). Similar to @ nimbly dodging falling debris. But maybe I'm misremembering.

I've just done a couple of random checks - 3.5.1 and 3.0.3 - and it was still just straight swap places in both of those. More interesting pushing is certainly something to think about post-4.1, though.

In any event, those Vampires standing on lava should be taking massive damage, they are, after all, particularly susceptible to fire. But it looks like they are standing on the lava with impunity.

Yes, I suspect this is the case, and it needs fixing.

[Nick]

Bring back the warrior's extra blow. The way things stand now, Half-Troll warrior is a huge drag. I'm stuck using Aglarang when I have lots of nice heavy weapons at home. This just seems like bad role-playing. A half troll warrior should be able to use a heavy club.

As far as I can determine, the current blows system has been in place since at least 3.2.0; I don't know when or how did warriors lost their extra blow. If we were making lists of things to revert to their pre-2010 state, I don't know how high this would be on mine

This seems like quite a good thing to examine when classes are up for re-examination post 4.1, rather than something to squeeze in at the last minute.

[Sky]

I feel Ancalong should squish mobs like Huan does. Huan is a big, horse-sized wolf. Ancalong BROKE A FREKIN MOUNTAIN BY FALLING ON IT.

Unrealted, i understand paladins and rogues now max out at 5 blows?

Gibe back extra blow for warriors nau plos.
Come on, let me "i suck at everything but at least i can rekk you".