4.0.2 Bugs
Collapse
X
-
My variant just crashed while processing objects. Found out the following loop is faulty:
Code:while (obj) { struct object *next = obj->next; [B][I]<-- crashes here[/I][/B] /* do something */ /* Delete the object */ object_delete(&obj); obj = next; }
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.Comment
-
[1] AFAICT from current master, it doesn't.
[2] There are actually some interesting cases of this in the Linux kernel which have caused security issues, but I don't think it's particularly pertinent to Angband, though it can obviously still happen and obscure other errors when using optimizations. The compiler is quite unlikely to be able to "peer through" object_deleteLast edited by AnonymousHero; October 11, 2015, 21:05.Comment
-
[nevermind, I just read the referred post and it talks about crash, not odd message sequence]Comment
-
Yeah my bad. Didn't reproduce the crash either after having fixed two occurences of object_delete called on inventory objects without doing a gear_excise first.PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!Comment
-
Just now I got a message with no subject, that said:
makes a soft 'pop'.
I'm used to it saying "Something makes a soft 'pop'," when it's about an unseen monster. I don't know much about programming- is this just a case of the message not having an assigned value because the monster is offscreen?
DLvl 39; it could have been any number of things teleporting/phasedooring as I approached a big, dark room. Seems minor, but thought I'd report it since I don't see anyone mentioning it yet.PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!Comment
-
- ARROW_4: "thwang" (no idea if it's correct, it's spelled "twang" everywhere else)
- BA_POIS: it was "creates a cloud of poison" in 3.5
- BA_WATE: it was "creates a whirlpool of water" in 3.5 (and "Something gurgles")
- CAUSE_2: missing punctuation (--> "points at you and curses horribly!")
- CAUSE_4: idem (2x "DIE!".)
- HASTE: "{name} mutters." (not when blind --> "Something mutters.")
- TPORT: missing "Something" ("Something makes a soft 'pop'.")
- S_KIN: "You hear something appear nearby!" (S_KIN is not limited to 1 --> "some things")PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!Comment
-
This looks OK to me - 'DIE!' is what the monster is saying, and it's in quotes because it's being referred to by the message.One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.Comment
-
-
OK, I believe all outstanding bugs for 4.0.2 are either fixed (latest build will be up soon), or filed here. Note that I've confirmed the "too many Dracoliches" bug.“We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
― Tom Stoppard, Rosencrantz and Guildenstern are DeadComment
-
Information leak bug. If @ quaffs an unidentified potion you can get the message something like, "Choose a direction..." Ah, that's !Dragon's Breath, but I shouldn't know that until after it's identified. And since I didn't choose a direction, it is just a "Light Brown Potion". Not sure of what the solution should be. I don't remember the problem existing in 3.5.1.Comment
-
Information leak bug. If @ quaffs an unidentified potion you can get the message something like, "Choose a direction..." Ah, that's !Dragon's Breath, but I shouldn't know that until after it's identified. And since I didn't choose a direction, it is just a "Light Brown Potion". Not sure of what the solution should be. I don't remember the problem existing in 3.5.1.Comment
-
Except it didn't identify when the direction wasn't chosen. Nomad's solution sounds like a reasonable justification. The change needed would be for the potion to identify when a direction is not chosen, much like the identify scroll/staff/rod when no item is chosen.“We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
― Tom Stoppard, Rosencrantz and Guildenstern are DeadComment
-
PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!Comment
-
OK, I believe all outstanding bugs for 4.0.2 are either fixed (latest build will be up soon), or filed here. Note that I've confirmed the "too many Dracoliches" bug.Comment
Comment