Nightlies embark on long journey towards 3.3

[Magnate]

This is what I complained about in the other thread. Obviously, mileages vary.

I went down to DL10 just for silliness. Smaug, Shelob, and Kavlax in a vault and my only resistance was an amulet for acid.

Ok, the dungeon silliness has been reverted - it was an accidental change in defines.h which has been re-set.

Sirridan: I never spotted the pickup bug because I play with pickup_always on, which means everything is picked up and the duplicate messages never happen. It's due to some reworked pickup code which went in a couple of days ago. The ticket is now confirmed so I expect it'll be fixed soon. (I am not volunteering because I don't really know that bit of the code and I'm in the middle of another branch I'm trying to finish before going back to work.)

[PowerDiver]

EDIT: Also finding tons of vaults in the low levels, at least 3 or 4 before dlvl 10, normal? Lots of other special rooms too, like the checkerboards that are full of items, monsters, and traps. Makes it a lot more dangerous and interesting, I like it.

This is what I complained about in the other thread. Obviously, mileages vary.

I went down to DL10 just for silliness. Smaug, Shelob, and Kavlax in a vault and my only resistance was an amulet for acid.

[Sirridan]

Ah, d_m will be pleased: he reported that and we all told him he was going mad, as nobody else can reproduce it. I've opened http://trac.rephial.org/ticket/1308, so grateful if you could attach a savefile which reproduces the problem.

Attaching. Also, it only seems to happen when I pick up something that won't stack. To clarify:

Walk over a single green potion, it tells me I see it 10x.
Walk over another green potion, it picks it up automatically.

Same thing happens with weapons, armor, etc.

ID'ed or not it doesn't matter, if it doesn't auto-pickup because it can stack with something in inventory, it prompts a ton of times.

Also prompt amounts vary between 6 and 10, but stay static with any given game session.

EDIT: Also finding tons of vaults in the low levels, at least 3 or 4 before dlvl 10, normal? Lots of other special rooms too, like the checkerboards that are full of items, monsters, and traps. Makes it a lot more dangerous and interesting, I like it.

[Magnate]

Bit of a bug, playing a human warrior, dungeon level 1, walked over a light blue mushroom after killing a floating eye, and it said "you see a light blue mushroom <x10>". Quite annoying actually.

Ah, d_m will be pleased: he reported that and we all told him he was going mad, as nobody else can reproduce it. I've opened http://trac.rephial.org/ticket/1308, so grateful if you could attach a savefile which reproduces the problem.

[Sirridan]

Bit of a bug, playing a human warrior, dungeon level 1, walked over a light blue mushroom after killing a floating eye, and it said "you see a light blue mushroom <x10>". Quite annoying actually.

[Magnate]

(P.S. The new nightlies *shouldn't* break savefiles - I've done quite a lot of testing of that. But if you have any bronze DSM, finish your current game before upgrading ...)

Ok, I fixed it so that importing savefiles with bronze DSM (or with bronze monsters on the level) will not crash.

But ... randarts are broken in nightlies. If you start a new game with randarts, it will work ok, but your randarts will be very weird - all resists/slays and almost no stat boosts. This is a side-effect of the introduction of multiple pvals - since I need to rewrite randart.c completely for 3.3 I've decided not to spend time fixing it up before I do that.

So if you're playing nightlies you might want to stick with standarts until further notice.

[buzzkill]

Allow me to throw out a feature request for 3.3, a small tweak to the store interface. It's something I became accustomed to playing DaJ and since the stores already use noun/verb syntax, it will be a very small change.

Allow a purchase to be initiated by selecting it twice consecutively. For example, given...

a) 13 potions of cure light wounds

You can currently press either 'ag' or 'ab' to initiate a purchase of this item. I would just like to add 'aa' to that list. To the best of my knowledge this won't interfere with anything else, and it's a little less keyboard travel for your fingers. Eventually, if it's embraced, it could lead to the elimination of 'g' and 'b' as store commands, freeing them up to be used as store inventory slots.

[Magnate]

I couldn't find the "new ticket" button, so I just registered immediately prior to reporting it. In the past, I submitted tickets and attached files unregistered with no problems. The only possible change on my side is upgrading from an ancient browser without flash to something modern.

The need for registration is an anti-spam measure. No idea why you're not getting the attachment thing working properly. I'll keep a look out for it.

[PowerDiver]

Hmmm. Haven't come across this. Are you registered on trac? Maybe it's a setting for unregistered users?

I couldn't find the "new ticket" button, so I just registered immediately prior to reporting it. In the past, I submitted tickets and attached files unregistered with no problems. The only possible change on my side is upgrading from an ancient browser without flash to something modern.

[Magnate]

Thanks for fixing my issues so quickly. However, I need to report a bug on reporting a bug!

I tried a few times to attach a file to the ticket, both when I opened the ticket and after it was created. I always immediately got a screen telling me the connection timed out and the file was not attached.

Hmmm. Haven't come across this. Are you registered on trac? Maybe it's a setting for unregistered users?

In case anyone is wondering, takk has fixed the 'M'ap view (which wasn't showing items or monsters), and has also imported Buzzkill's fixed 32x32 tiles ...

[PowerDiver]

I'll go open the ticket.

Thanks for fixing my issues so quickly. However, I need to report a bug on reporting a bug!

I tried a few times to attach a file to the ticket, both when I opened the ticket and after it was created. I always immediately got a screen telling me the connection timed out and the file was not attached.

[Magnate]

If it is not my corrupted game, it is trivial to reproduce. I just dropped two !hero in different squares, then set the autoinscription on !hero to "testing" [without the quotes], stepped on them and they are unstacked in my pack.

I'll go open the ticket.

Fixed in staging. We changed o_ptr->note from an index into the "quark" array to an actual string, so we need to change == to strcmp when testing for equality.

[Magnate]

I couldn't get '-' to work, so I tried loading back into 3.2. I know it's a bad thing to do, but I was trying things out. The behavior was so strange I figured I should report it.

I tried toggling the option, but I still auto-disarmed the trapdoor even after turning it [easy_open specifically mentions disarm] off.

Ok, takk clarified this: the command still exists, but it's now shift-w instead of minus. I've updated command.txt to reflect this. Sorry for the confusion.

[PowerDiver]

This last is likely to be a real bug, because inscriptions have been refactored. When it's reproducible, pls open a ticket with a savefile. But note that two stacks with different inscriptions have never stacked, so that's not a bug. But one with should stack with one without.

If it is not my corrupted game, it is trivial to reproduce. I just dropped two !hero in different squares, then set the autoinscription on !hero to "testing" [without the quotes], stepped on them and they are unstacked in my pack.

I'll go open the ticket.

[Magnate]

I couldn't get '-' to work, so I tried loading back into 3.2. I know it's a bad thing to do, but I was trying things out. The behavior was so strange I figured I should report it.

I tried toggling the option, but I still auto-disarmed the trapdoor even after turning it [easy_open specifically mentions disarm] off.

In yet another strangeness, I had two staves of teleport stacked and a third one unstacked in my pack that did not merge. The cause has something to do with my !* autoinscription. When I uninscribed the one, they merged and kept the !*. Of course, my savefile may be corrupted by the back-and-forth.

This last is likely to be a real bug, because inscriptions have been refactored. When it's reproducible, pls open a ticket with a savefile. But note that two stacks with different inscriptions have never stacked, so that's not a bug. But one with should stack with one without.

easy_open is only about not checking for a direction prompt, so shouldn't apply to walking into trapdoors. I've opened #1300 for this.