Nightlies embark on long journey towards 3.3

[Derakon]

This totally nerfs disenchantment for no good reason that I can see. Disenchantment used to be something to avoid at all costs. Now, it's just another minor side effect.

If Restore Item were as rare as Acquirement, would this still be an issue? Assuming that it were tweaked to only affect artifacts, anyway.

[Pete Mack]

Sorry, I don't think I understand this. Do you mean that you don't like the fact that it shows two different alternatives? Or something else?

I am taking this back, now that I understand fractional blows a bit more. (I was thinking that the numbers should be for +1 STR or +1 DEX, if there's any change in fractional blows. But that can be a very small effect indeed.)
EDIT:

[?Restore object] is *intended* to restore disenchanted artifacts (and egos I think), but it's not intended to affect non-artifact jewelry. See ticket #1319.

This totally nerfs disenchantment for no good reason that I can see. Disenchantment used to be something to avoid at all costs. Now, it's just another minor side effect. Also, for ego cursed ego objects, it removes the huge negatives, despite their being part of the ego definition.

[Magnate]

Bugs observed while wandering around town in first trial of 3.3 nightlies.

* No yellow hilite box for player

I couldn't say for sure but I think that was deliberate.

* Can't change colors of non-illuminated walls through knowlege menu. (I don't like red walls.)

This is known, but admittedly has no ticket yet.

* ?Restore Item is insanely powerful and/or insanely common. It should NOT affect cursed objects, artifacts, or jewelry. (I have no idea what it does to things like disenchanted gloves of Power.)

It is *intended* to restore disenchanted artifacts (and egos I think), but it's not intended to affect non-artifact jewelry. See ticket #1319.

* Gold drops seem too small given object resale values. I am really struggling to get $.

Excellent. Try playing with no_selling and see if it's easier.

* Weapon display "you would get X blows" should show fractional blows for a single stat point

Sorry, I don't think I understand this. Do you mean that you don't like the fact that it shows two different alternatives? Or something else?

[Pete Mack]

Bugs observed while wandering around town in first trial of 3.3 nightlies.

* No yellow hilite box for player
* Can't change colors of non-illuminated walls through knowlege menu. (I don't like red walls.)
* Weaponsmith store color changes with illumination, despite having 333 as display colors in feature knowlege. (Behaves like 333).
EDIT: This is particularly annoying for stairs down and trap doors.
* 8x13 font is wacky (Windows)
* ?Restore Item is insanely powerful and/or insanely common. It should NOT affect cursed objects, artifacts, or jewelry. (I have no idea what it does to things like disenchanted gloves of Power.)
* Gold drops seem too small given object resale values. I am really struggling to get $.
* Weapon display "you would get X blows" should show fractional blows for a single stat point:

2.7 blows/round
With +2 STR and +0 DEX you would get 3.0 blows
With +0 STR and +2 DEX you would get 3.1 blows

* Free action is not dangerous enough. I'm out of practice & screwed up a couple times. Went way down on HP, but still survived, including vs a spectator(!)

[APWhite]

Can you guys work on getting the borg-necessary changes? I do not have a good diff program but the files that need some edits are:
birth.c
cmd-misc.c
dungeon.c
externs.h
init2.c
main-win.c
variable.c

All my edits are clearly marked with apw. You can get copies of my edited files from www.innovapain.com/borg/download/320saver.zip

And let me know when you get it done because there is a memory error that the borg is encountering and I am not sure if it was the borg or the 320 code that was doing it.

Andrew

[takkaria]

No idea. It stands for Walk?

Yeah, that. I think commands should be discoverable, so 'W' is a lot more sensible then '-'.

[Magnate]

Why do that? What does W have that - doesn't?

No idea. It stands for Walk?

[Zyphyr]

Why do that? What does W have that - doesn't?

Peaks and Valleys, of course. - is a boring flat line, and as such not nearly as interesting.

[buzzkill]

The '-' command hasn't been removed, it's been renamed/remapped to W.

Why do that? What does W have that - doesn't?

[Magnate]

That's been removed. I don't know exactly why this time, but commands are limited and every time someone adds something like the new 'h' command you should expect something else will need to be removed.

The '-' command hasn't been removed, it's been renamed/remapped to W.

[PowerDiver]

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

That's been removed. I don't know exactly why this time, but commands are limited and every time someone adds something like the new 'h' command you should expect something else will need to be removed.

Besides, it seems intuitive to me. I believe the problem is unlearning past habits, not intuitiveness.

[edit] Oh, if you have autopickup off, using run to toggle it on is unintuitive.

[Magnate]

I tend to get into a habit when moving from A to B in the dungeon of running everywhere, since it just requires me to hold down Shift. There are occasionally items I've left behind that I don't want to pick up (e.g. potions of stat restore that I don't need right now), so I'd have to stop running if running also toggled autopickup.

Shock and horror, I'd have to release the shift key.

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

What he said. I don't associate running with pickup, so I would have to learn to do so. It could be done, but I'd rather not.

[Derakon]

I tend to get into a habit when moving from A to B in the dungeon of running everywhere, since it just requires me to hold down Shift. There are occasionally items I've left behind that I don't want to pick up (e.g. potions of stat restore that I don't need right now), so I'd have to stop running if running also toggled autopickup.

Shock and horror, I'd have to release the shift key.

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

[PowerDiver]

I understand the trap case, but how can you be sure I want to toggle autopickup? I *never* toggle autopickup, running or not.

If you are adjacent to an item, and want to pick it up, knowing that you will be disturbed when you step on it, why would you bother to run when you could just step on it for the same effect? Running is completely pointless in that scenario, unless I am missing something blindingly obvious.

[Magnate]

In that case, there is no longer a need for the '-' command or any successors. A run from an adjacent square into a trap should mean to jump in, and into an adjacent square with an item should mean to move onto it while toggling autopickup.

I understand the trap case, but how can you be sure I want to toggle autopickup? I *never* toggle autopickup, running or not.