Nightlies embark on long journey towards 3.3

[PowerDiver]

No, the current thinking is that globals are bad and should be removed where possible. I didn't do this refactor so I don't know what the solution was (a linked list, maybe?), but it's been reverted for the time being.

You don't want to be mallocing strings, ever. If this is some sort of religious coding style, then a much better solution is to bloat the object_type with an array of chars large enough to hold the max allowed inscription.

[PowerDiver]

There was a change made with running. It used to be that when your run stopped you at the border of trap detection, if you tried to run again you would not move. Now, the second run succeeds. Was this done on purpose, or by accident? I think I prefer the earlier behavior, but if the change was made on purpose that will allow some useful overloading of the run command, for example to jump into traps.

[Magnate]

There was a change made with running. It used to be that when your run stopped you at the border of trap detection, if you tried to run again you would not move. Now, the second run succeeds. Was this done on purpose, or by accident? I think I prefer the earlier behavior, but if the change was made on purpose that will allow some useful overloading of the run command, for example to jump into traps.

It was a deliberate change - ticket #855. FWIW, I share your preference for the earlier behaviour and argued against the change, but was outvoted.

[PowerDiver]

It was a deliberate change - ticket #855. FWIW, I share your preference for the earlier behaviour and argued against the change, but was outvoted.

In that case, there is no longer a need for the '-' command or any successors. A run from an adjacent square into a trap should mean to jump in, and into an adjacent square with an item should mean to move onto it while toggling autopickup.

[Magnate]

In that case, there is no longer a need for the '-' command or any successors. A run from an adjacent square into a trap should mean to jump in, and into an adjacent square with an item should mean to move onto it while toggling autopickup.

I understand the trap case, but how can you be sure I want to toggle autopickup? I *never* toggle autopickup, running or not.

[PowerDiver]

I understand the trap case, but how can you be sure I want to toggle autopickup? I *never* toggle autopickup, running or not.

If you are adjacent to an item, and want to pick it up, knowing that you will be disturbed when you step on it, why would you bother to run when you could just step on it for the same effect? Running is completely pointless in that scenario, unless I am missing something blindingly obvious.

[Derakon]

I tend to get into a habit when moving from A to B in the dungeon of running everywhere, since it just requires me to hold down Shift. There are occasionally items I've left behind that I don't want to pick up (e.g. potions of stat restore that I don't need right now), so I'd have to stop running if running also toggled autopickup.

Shock and horror, I'd have to release the shift key.

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

[Magnate]

I tend to get into a habit when moving from A to B in the dungeon of running everywhere, since it just requires me to hold down Shift. There are occasionally items I've left behind that I don't want to pick up (e.g. potions of stat restore that I don't need right now), so I'd have to stop running if running also toggled autopickup.

Shock and horror, I'd have to release the shift key.

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

What he said. I don't associate running with pickup, so I would have to learn to do so. It could be done, but I'd rather not.

[PowerDiver]

Still, this seems kind of unintuitive. What's wrong with using '-' to toggle autopickup / easy-disarm?

That's been removed. I don't know exactly why this time, but commands are limited and every time someone adds something like the new 'h' command you should expect something else will need to be removed.

Besides, it seems intuitive to me. I believe the problem is unlearning past habits, not intuitiveness.

[edit] Oh, if you have autopickup off, using run to toggle it on is unintuitive.

[Magnate]

That's been removed. I don't know exactly why this time, but commands are limited and every time someone adds something like the new 'h' command you should expect something else will need to be removed.

The '-' command hasn't been removed, it's been renamed/remapped to W.

[buzzkill]

The '-' command hasn't been removed, it's been renamed/remapped to W.

Why do that? What does W have that - doesn't?

[Zyphyr]

Why do that? What does W have that - doesn't?

Peaks and Valleys, of course. - is a boring flat line, and as such not nearly as interesting.

[Magnate]

Why do that? What does W have that - doesn't?

No idea. It stands for Walk?

[takkaria]

No idea. It stands for Walk?

Yeah, that. I think commands should be discoverable, so 'W' is a lot more sensible then '-'.

[APWhite]

Can you guys work on getting the borg-necessary changes? I do not have a good diff program but the files that need some edits are:
birth.c
cmd-misc.c
dungeon.c
externs.h
init2.c
main-win.c
variable.c

All my edits are clearly marked with apw. You can get copies of my edited files from www.innovapain.com/borg/download/320saver.zip

And let me know when you get it done because there is a memory error that the borg is encountering and I am not sure if it was the borg or the 320 code that was doing it.

Andrew