Borg Issues with the latest nightly

[agoodman]

It's tricky to catch it in the act, but it seems that if the borg dies while the Angband window is visible, it often causes a crash. I'll let you know if I can come up with steps to reproduce.

I have had reports that the reincarnation (begin again as a new char) code rather than the resurrection (continue same character) sometimes crashes. I -think- I just have to remove a bunch of things I am setting but I haven't been able to duplicate it regularly.

NOTE1:
to do "reincarnation" have "borg_cheat_death=false" in borg.txt but set "cheat death" to true in the Angband flags.
to do "resurrection" have borg_cheat_death=true". The code will set the cheat death flag automatically.
to do neither have "borg_cheat_death=false" and don't set the cheat death flag.
if you compile as a screen saver the "cheat death" flag is set to true automatically.

NOTE2: I will be traveling between Aug 23 and Sept 9 without my computer. I will be able to check the forum on my phone but unable to do any coding... so borg fixes will be slightly delayed.

NOTE3: I just saw https://github.com/angband/angband/issues/6022 maybe that is the issue? I don't think so.... I think the borg has its own issue...

[Aodhlin]

It's tricky to catch it in the act, but it seems that if the borg dies while the Angband window is visible, it often causes a crash. I'll let you know if I can come up with steps to reproduce.

[agoodman]

With clang 15, there's a "set but unused" warning for glyphs in borg-fight-defend.c's borg_defend_aux_banishment_morgoth(). It wasn't clear to me if the the glyph counting there could be removed entirely, since line 3226 where the count is used is preprocessed out, or just preprocess out the declaration of glyphs and the loop that computes it.

Well, the code has been this way since before 3.4.0 (the earliest borg code I have). For now I am going to comment out that variable and all the code that uses it.

It seems to be limiting the use of banishment when you are building a sea of runes but it seems to me that that is just when banishment would come in handy... as long as you don't banish morgoth himself (and you can't, I don't think... at least you couldn't at one point, haven't checked recently) seems like "I am busy building my sea of runes, %^&* off" is just the right time to use the spell.
If someone gets a borg to fighting Morgoth again and thinks it is banishing wrong, LMK and I can adjust.

[Nick]

Just for clarity to everyone: This borg was written by Ben Harrison, who was maintainer at the time. As I recall, I took his borg (ages and ages ago) and modified it making "AdamBorg". Dr Andrew White (APW APWhite) took my borg and did a while bunch of modifications to it and became the borg maintainer for a long while making APWBorg. I came back when I noticed it had been removed from the base code because 4.x was out and it needed updating. As I result, I am really familiar with much of the code but there are vast areas I haven't had to touch and am reading for the first time when someone writes up bugs. Just saying so that people don't think "Adam wrote this, how does he not know?" ... lots written by smarter people than me

Having only come to Angband in the early 2000s, I didn't know this history. Glad you're back

[agoodman]

With clang 15, there's a "set but unused" warning for glyphs in borg-fight-defend.c's borg_defend_aux_banishment_morgoth(). It wasn't clear to me if the the glyph counting there could be removed entirely, since line 3226 where the count is used is preprocessed out, or just preprocess out the declaration of glyphs and the loop that computes it.

Hmm, not code I am intimately familiar with. I will have to read it and figure out what it is doing. It looks to me like I should put back the #if 0'd out code but I want to make sure.


Just for clarity to everyone: This borg was written by Ben Harrison, who was maintainer at the time. As I recall, I took his borg (ages and ages ago) and modified it making "AdamBorg". Dr Andrew White (APW APWhite) took my borg and did a while bunch of modifications to it and became the borg maintainer for a long while making APWBorg. I came back when I noticed it had been removed from the base code because 4.x was out and it needed updating. As I result, I am really familiar with much of the code but there are vast areas I haven't had to touch and am reading for the first time when someone writes up bugs. Just saying so that people don't think "Adam wrote this, how does he not know?" ... lots written by smarter people than me

[backwardsEric]

With clang 15, there's a "set but unused" warning for glyphs in borg-fight-defend.c's borg_defend_aux_banishment_morgoth(). It wasn't clear to me if the the glyph counting there could be removed entirely, since line 3226 where the count is used is preprocessed out, or just preprocess out the declaration of glyphs and the loop that computes it.

[agoodman]

I've been having issues with the forum, so I ended up opening a Github issue.

https://github.com/angband/angband/issues/6011

Aodhlin I requested borg.txt and angband.ini for the crash you reported on that issue, in case you didn't see that. I can't seem to duplicate the crash.

[agoodman]

one of the things mentioned in the github issue is now in the nightly.

[agoodman]

I've been having issues with the forum, so I ended up opening a Github issue.

https://github.com/angband/angband/issues/6011

I have responded on that. Sorry, took me a bit. Chaos abounds

[Aodhlin]

Looks like the fixes for shopping are in the latest beta release. These changes should help the stuck borgs (closed off areas) and the late stage/high level slowness.

I've been having issues with the forum, so I ended up opening a Github issue.

https://github.com/angband/angband/issues/6011

[agoodman]

Looks like the fixes for shopping are in the latest beta release. These changes should help the stuck borgs (closed off areas) and the late stage/high level slowness.

[agoodman]

Here's another example for this!

I have code checked in that should help the buying and selling and swapping stuff issues... but it is big changes and risky. I will post when it is merged in.

[Aodhlin]

Hmm this looks like a place where he is optimizing his inventory. When he is in the store he wants to put the ring in the home, when he is not, he wants to junk it. I need to rewrite this section of the code. I just redid the optimizing equipment section so hopefully I can leverage some changes there.

Here's another example for this!

[agoodman]

This borg is caught in a nasty loop trying to buy/sell things.

Hmm this looks like a place where he is optimizing his inventory. When he is in the store he wants to put the ring in the home, when he is not, he wants to junk it. I need to rewrite this section of the code. I just redid the optimizing equipment section so hopefully I can leverage some changes there.

[agoodman]

Here's another example of the same situation. I don't think it happens much, but once it does happen the borg gets stuck, and I have to rescue him.

Since I run it in the background, I don't see how it happened, just that it did.

Is there a way to easily get logs for when the borg either crashes Angband entirely, or unhooks?

I have checked in a fix to to this situation. I will post when it is merged in.
There are no real logs. I am not really sure how to make one or what I would put in it that the save doesn't give.