Spear of Light

[agoodman]

A change that is giving the borg a bit of trouble and I am not sure if this was done on purpose.

in an unknown hall

####
@..
####

what the reality (but not yet mapped) is:

########
@......#
########

shoot spear of light down hall
in 3.x get:

########
@......#
########
​

(wall at end lit up)
in 4.x get:

########
@......
########
​

(last wall not lit up)

Is this on purpose? If so I need to code around it for the borg and guess that after the beam, if less than beam length, guess that it is a wall.

[Nick]

That was not done on purpose.

[agoodman]

ok, I can take a quick look at a fix for it. It doesn't look hard.

[agoodman]

(argh this forum seems to have some real issues. I keep getting errors and can't be sure when what I say gets posted)

[agoodman]

ok, I can take a quick look at a fix for it. It doesn't look hard.

Well, I was wrong about it not being hard. It looks to me like it is setting "SQUARE_GLOW" which is what I would have thought would be needed to make that square visible. I tried setting SQUARE_SEEN too but that didn't work. Not sure what should change. I can keep looking but if you or Eric wants to hop in, it would get done faster.

[backwardsEric]

glow_can_light_wall() in cave-view.c is what's causing this. A proposed change is up at https://github.com/angband/angband/pull/5975 . It reverts a change made in 2019 which should no longer be needed as source_can_light_wall() in cave-view.c should keep walls from appearing lit if not viewed from the right direction.

[agoodman]

glow_can_light_wall() in cave-view.c is what's causing this. A proposed change is up at https://github.com/angband/angband/pull/5975 . It reverts a change made in 2019 which should no longer be needed as source_can_light_wall() in cave-view.c should keep walls from appearing lit if not viewed from the right direction.

I got all the way in debugging to think maaaaybe it was in glow_can_light_wall() but had no clue how to fix it.
Thanks

[Sky]

(argh this forum seems to have some real issues. I keep getting errors and can't be sure when what I say gets posted)

it does - have faith.