Spear of Light

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • agoodman
    Apprentice
    • Jan 2011
    • 98

    Spear of Light

    A change that is giving the borg a bit of trouble and I am not sure if this was done on purpose.

    in an unknown hall
    Code:
    ####
    @..
    ####
    what the reality (but not yet mapped) is:

    Code:
    ########
    @......#
    ########
    ​​
    shoot spear of light down hall
    in 3.x get:
    Code:
    ########
    @......#
    ########
    ​
    (wall at end lit up)
    in 4.x get:
    Code:
    ########
    @......
    ########
    ​
    ​(last wall not lit up)

    Is this on purpose? If so I need to code around it for the borg and guess that after the beam, if less than beam length, guess that it is a wall.
  • Nick
    Vanilla maintainer
    • Apr 2007
    • 9603

    #2
    That was not done on purpose.
    One for the Dark Lord on his dark throne
    In the Land of Mordor where the Shadows lie.

    Comment

    • agoodman
      Apprentice
      • Jan 2011
      • 98

      #3
      ok, I can take a quick look at a fix for it. It doesn't look hard.

      Comment

      • agoodman
        Apprentice
        • Jan 2011
        • 98

        #4
        (argh this forum seems to have some real issues. I keep getting errors and can't be sure when what I say gets posted)

        Comment

        • agoodman
          Apprentice
          • Jan 2011
          • 98

          #5
          Originally posted by agoodman
          ok, I can take a quick look at a fix for it. It doesn't look hard.
          Well, I was wrong about it not being hard. It looks to me like it is setting "SQUARE_GLOW" which is what I would have thought would be needed to make that square visible. I tried setting SQUARE_SEEN too but that didn't work. Not sure what should change. I can keep looking but if you or Eric wants to hop in, it would get done faster.

          Comment

          • backwardsEric
            Knight
            • Aug 2019
            • 508

            #6
            glow_can_light_wall() in cave-view.c is what's causing this. A proposed change is up at https://github.com/angband/angband/pull/5975 . It reverts a change made in 2019 which should no longer be needed as source_can_light_wall() in cave-view.c should keep walls from appearing lit if not viewed from the right direction.

            Comment

            • agoodman
              Apprentice
              • Jan 2011
              • 98

              #7
              Originally posted by backwardsEric
              glow_can_light_wall() in cave-view.c is what's causing this. A proposed change is up at https://github.com/angband/angband/pull/5975 . It reverts a change made in 2019 which should no longer be needed as source_can_light_wall() in cave-view.c should keep walls from appearing lit if not viewed from the right direction.
              I got all the way in debugging to think maaaaybe it was in glow_can_light_wall() but had no clue how to fix it.
              Thanks

              Comment

              • Sky
                Veteran
                • Oct 2016
                • 2312

                #8
                Originally posted by agoodman
                (argh this forum seems to have some real issues. I keep getting errors and can't be sure when what I say gets posted)
                it does - have faith.
                "i can take this dracolich"

                Comment

                Working...
                😀
                😂
                🥰
                😘
                🤢
                😎
                😞
                😡
                👍
                👎