I love the quiver, but if I hit (f)ire without any ammo or with unfireable ammo, then the game crashes.
Quiver bug in v1802
Collapse
X
-
-
This whole thing about ammo being "wielded" into the quiver is silly. I know it is how it has always been done, but that doesn't make it right.Comment
-
After having ported this feature from NPP I think I agree with you, but you're going to hit these bugs whichever way you implement the feature based on the way the loops over intentory[] are written--changing the pick up command to put stuff in the quiver (so that ammo never hits the backpack) doesn't simplify that.
If I were going to do a refactor I would split inventory[] into equipment[], quiver[] and inventory[]. I think that would make the inventory code a lot easier to read, and obviate most of the weirdness involving INVEN_PACK, INVEN_TOTAL and friends.Comment
-
Patches welcome!
After having ported this feature from NPP I think I agree with you, but you're going to hit these bugs whichever way you implement the feature based on the way the loops over intentory[] are written--changing the pick up command to put stuff in the quiver (so that ammo never hits the backpack) doesn't simplify that.
If I were going to do a refactor I would split inventory[] into equipment[], quiver[] and inventory[]. I think that would make the inventory code a lot easier to read, and obviate most of the weirdness involving INVEN_PACK, INVEN_TOTAL and friends."Been away so long I hardly knew the place, gee it's good to be back home" - The BeatlesComment
-
-
Thank you for pointing that out - I hadn't realised it annoyed me. I'll work on finding a more sensible system at some point.One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.Comment
-
It's also obviously a large amount of work.
The only slightly tricky issue is differentiating items that can be both thrown effectively or wielded for melee, like Nimloth. One solution is to separate the types entirely. Another is that ammo goes in the quiver but throwing items do not. Yet another is to put it in the quiver, but allow you to wield it from the quiver into the melee slot.Comment
-
Comment
Comment