Quiver added to Vanilla as of r1776

[d_m]

Hi all,

As part of closing ticket #34 I have added a quiver to Vanilla. The design is based on NPP but I had to write most of it myself because of the refactoring and work on Vanilla.

I'm too tired to write a detailed explanation of how it works tonight. The basic gist: 10 quiver slots show up in the equipment. Ammo will auto-absorb into matching ammo in the quiver. Ammo that is inscribed @fN will prefer slot N if possible. (f)ire will always accept slot numbers. If you inscribe ammo it will try to move to the right slot. Etc, etc.

It's also worth noting that slot 0 is the first slot used and the "default" slot... just hitting enter on the ammo selection screen will choose it.

Currently ammo doesn't compact properly when you uninscribe. This is due an object-swapping bug on Windows which I can't figure out tonight (although I forced MarbleDice to test innumerable patches). Once that issue is fixed it should work. For now taking ammo off and putting it back on is the work around.

Please feel free to open tickets or respond to this thread if you encounter one of the (many) bugs I assume has been added to the codebase. I would prefer to keep feature requests separate, unless they relate to buggy behavior, since there are probably about a hojillion features one could imagine a quiver having.

Thanks to Magnate, MarbleDice and Elly for moral support and testing!

[Magnate]

Awesome. That's the single biggest improvement to V since ... oh I don't know, the removal of lua, say ;-)

I foresee a battery of ranger wins ...

[Whelk]

Please excuse me while a do a dance of joy.

(dance of joy)

Thank you. I will start testing away tomorrow and report any bugs I find. You might say I'm quivering with anticipation (groan).

[Magnate]

You might say I'm quivering with anticipation (groan).

Who are you and what have you done with Nick?

[Philip]

Awesome. That's the single biggest improvement to V since ... oh I don't know, the removal of lua, say ;-)

I foresee a battery of ranger wins ...

Yeah, as if rangers were hard already.

[Magnate]

Yeah, as if rangers were hard already.

That was kind of my point. Missile combat is still overpowered w.r.t. melee combat and spells, but that doesn't mean the quiver isn't a great thing to have in V. We just need to tone down missiles a bit is all. See http://trac.rephial.org/ticket/317

[TJS]

Actually I'm slightly against this change. As already mentioned ranged combat is massively overpowered, so making their inventory management easier is maybe not the way to go in my opinion.

There was talk of getting rid of enchantments on ammo completely (as well as the things in the tracker Magnate mentions), which would partially help with the inventory management issues as well as overpowered launchers.

Still I'm looking forward to trying it out.

[Nick]

Who are you and what have you done with Nick?

'tis nobler in the mind to suffer the slings and arrows of outrageous fortune ... I have shot my bolt, and must bow to Whelk's superior wordplay.

[SilverD]

I use a separate TERM for my equipment listing, and this has all sorts of display problems :-)

When unequipping arrows, that display doesn't update and I get duplicate entries in my inventory window and equipment. Just a display issue, though.

And, I love this change!

[Magnate]

Raised as http://trac.rephial.org/ticket/1019. Thanks for the report.

[fizzix]

That was kind of my point. Missile combat is still overpowered w.r.t. melee combat and spells, but that doesn't mean the quiver isn't a great thing to have in V. We just need to tone down missiles a bit is all. See http://trac.rephial.org/ticket/317

yup. Toning down missiles a little will solve the problem. Just reducing the multipliers on weapons and brands will do it as a first step. For now, let's just give it a shot without having a row about it. (double groan)

[mbell999]

I love the quiver! I'm testing out r1792 now and it is working very well.

One bug I've found is that when you equip a stack of arrows, the weight is subtracted from your burden. But when you take a stack out of your quiver, the weight doesn't change. So you can take off and re-equip stacks of ammo repeatedly and make your burden go negative. Saving and restarting will fix your weight.

[d_m]

I love the quiver! I'm testing out r1792 now and it is working very well.

One bug I've found is that when you equip a stack of arrows, the weight is subtracted from your burden. But when you take a stack out of your quiver, the weight doesn't change. So you can take off and re-equip stacks of ammo repeated and make your burden go negative. Saving and restarting will fix your weight.

Wow, that's a great bug! I've opened ticket #1020 for it.

[d_m]

The bug mbell999 found (messed up burden calculations) is fixed in r1793.

[d_m]

I use a separate TERM for my equipment listing, and this has all sorts of display problems :-)

....

When unequipping arrows, that display doesn't update and I get duplicate entries in my inventory window and equipment. Just a display issue, though.

And, I love this change!

Thanks for testing this!

All the equipment sub-window issues should be fixed in r1795. Please let me know if you find any others.