Your views wanted on artifacts in V

[d_m]

This issue is fixed in r1970.

[d_m]

sent (link sent via pm, couldn't upload)

In the meantime, I've tried generating more randart sets and have come across the same problem.

I compiled a fresh version of r1967 and still got a zero slay/brand set of randarts. weird.

edit: used previous auto-compiled versions. Bug goes back at least to r1963. It's not present in 3.1.2v2

I can confirm this bug... in HEAD you get none (or exceeding few) slays on every randart set.

The bug was introduced in r1948, which was a bit-flag cleanup/rewrite. Before that slays on randarts worked about like you'd expect.

This means that either the artifact-specific bit-flag stuff is buggy, or that there are potentially other bit-flag related bugs introduced also.

[fizzix]

sent (link sent via pm, couldn't upload)

In the meantime, I've tried generating more randart sets and have come across the same problem.

I compiled a fresh version of r1967 and still got a zero slay/brand set of randarts. weird.

edit: used previous auto-compiled versions. Bug goes back at least to r1963. It's not present in 3.1.2v2

[Magnate]

I figure this is as good a place to post this as any.

Looking through the randart log of my recent game I found not a single brand or slay on any weapon. (Except Grond and a Mace of Disruption with the slay undead flag)

This has got to be a bug.

I'm inclined to agree - the chances of it happening should be impossibly small. Can you post the randart.log file please? (zipped)

[Zikke]

I figure this is as good a place to post this as any.

Looking through the randart log of my recent game I found not a single brand or slay on any weapon. (Except Grond and a Mace of Disruption with the slay undead flag)

This has got to be a bug.

Quoting Magnate from the future: "There isn't anything in the code that would cause this kind of pattern besides the RNG just being a meanie face."

[fizzix]

I figure this is as good a place to post this as any.

Looking through the randart log of my recent game I found not a single brand or slay on any weapon. (Except Grond and a Mace of Disruption with the slay undead flag)

This has got to be a bug.

[PowerDiver]

Good catch, thank you. I hadn't noticed that Mediator was heavier than normal. Happy for it to be the standard 20lb.

You can add Razorback to the list.. 50 lb and it aggravates too.

[Magnate]

I found Mediator, and am not using it because of its excessive weight. If you are still on your mission to make artifacts be things one might use, could you please reduce the weight to the standard 20 lb of the base item?

Or remove it. I would have been happier with standard balance DSM. That's playing a warrior. Any other class would be annoyed by the weight even more due to mana penalties.

Good catch, thank you. I hadn't noticed that Mediator was heavier than normal. Happy for it to be the standard 20lb.

[PowerDiver]

I found Mediator, and am not using it because of its excessive weight. If you are still on your mission to make artifacts be things one might use, could you please reduce the weight to the standard 20 lb of the base item?

Or remove it. I would have been happier with standard balance DSM. That's playing a warrior. Any other class would be annoyed by the weight even more due to mana penalties.

[PowerDiver]

Yes please.

OK - here's mine too.

[fizzix]

After making the zipfile I opened the game and ID'd the Massive Iron Crown and it's (+0, +2)

[Magnate]

My just completed (randart) game did not have a hammer drop from Morgoth. It did have a Crown but I haven't picked it up.

I did make a savefile before retiring. I can post it here if you want.

Yes please.

[fizzix]

This is an old bug, which was thought closed at least once. I don't think its re-emergence can be connected to changes to artifact.txt, though it's quite possible that I've done something wrong in randart.c

Psi was using randarts - were you?

My just completed (randart) game did not have a hammer drop from Morgoth. It did have a Crown but I haven't picked it up.

I did make a savefile before retiring. I can post it here if you want.

[PowerDiver]

This is an old bug, which was thought closed at least once. I don't think its re-emergence can be connected to changes to artifact.txt, though it's quite possible that I've done something wrong in randart.c

Psi was using randarts - were you?

No, standart game.

It is likely that I started on an earlier revision and copied the savefile a few times as I upgraded. Maybe 1847->1851->1858. I just diffed, and the artifact.txt files are identical in 1847 and 1858.

[Magnate]

Is it possible that your changes messed up the final drop?

M just dropped a massive iron crown [0,+2] and mighty hammer (3d9) (+3,+5) with no special abilities. r1858

Psi reported something similar fairly recently.

This is an old bug, which was thought closed at least once. I don't think its re-emergence can be connected to changes to artifact.txt, though it's quite possible that I've done something wrong in randart.c

Psi was using randarts - were you?