Nightlies

[scud]

Mac nightly of 5 March.

Being a ranger I'd much rather have a nice long bow, but I thought it would be rude not to buy this...

[myshkin]

I've committed a few fixes that get keypad 5 working and add the reported keymaps to pref.prf for movement, running, and tunneling. They should be in nightlies shortly.

[Mondkalb]

Why have the cure wounds potions been moved to the alchemy shop?

[PowerDiver]

Numlock on/off? With numlock off I get end from keypad 1 and numlock on 1 in normal writing.

With numlock on, I get {MK}1

However, I believe that I normally play with numlock off. I checked that numlock off works for me in 3.2.

[Timo Pietilä]

Sure, but you get {K}1 when pressing numpad 1, so we are in different worlds.

Numlock on/off? With numlock off I get end from keypad 1 and numlock on 1 in normal writing.

[PowerDiver]

I get {K}5 when pressing 5 on my "keypad." I think this may be a platform-specific thing. You are still using X11 on Linux, right?

Sure, but you get {K}1 when pressing numpad 1, so we are in different worlds.

I'm currently using an Antec keyboard with X11 on Ubuntu 10.04 [I think] if that matters. The 7, 9, 1, and 3 numpad keys have the words Home, Pg Up, End, and Pg Dn on them below the numbers. The 2, 4, 6 and 8 numpad keys have arrows below the numbers.

Is there anything intrinsically wrong about including both sets of keymaps in the pref file?

Hmm, on the other hand, I'd love to be able to disable the standard 1 through 9 keys. If I don't notice that I am confused, and m2f, currently the 2 gets interpreted as a movement request after the m is denied due to confusion. I'd rather the non-numpad 2 did nothing but maybe beep at me when I am not in object selection mode. Perhaps that means that users should be expected to customize this stuff in their pref files, possibly during some installation process.

[myshkin]

I manage to get everything except the numpad 5 key to work. When I am in query keymap mode, and press it, nothing happens. I remember troubles with 5 in some older versions or maybe Moria. I think that is likely to be much harder to fix then adjusting a pref file.

I get {K}5 when pressing 5 on my "keypad." I think this may be a platform-specific thing. You are still using X11 on Linux, right?

This is one of the reasons I was opposed to the change to searching. We need a redundant way to wait one turn, not using the 5 key. Hmm, maybe ',' currently fills that role.

Yes, "," is the keymap for the 5 key by default

[PowerDiver]

I manage to get everything except the numpad 5 key to work. When I am in query keymap mode, and press it, nothing happens. I remember troubles with 5 in some older versions or maybe Moria. I think that is likely to be much harder to fix then adjusting a pref file. This is one of the reasons I was opposed to the change to searching. We need a redundant way to wait one turn, not using the 5 key. Hmm, maybe ',' currently fills that role.

These lines work for me, except for 5:

A:;1
C:0:{K}[End]

A:;2
C:0:{K}[Down]

A:;3
C:0:{K}[PageDown]

A:;4
C:0:{K}[Left]

A:;5
C:0:{K}5

A:;6
C:0:{K}[Right]

A:;7
C:0:{K}[Home]

A:;8
C:0:{K}[Up]

A:;9
C:0:{K}[PageUp]

[myshkin]

When I press the 1 on the numpad, the Key line changes to

Key: {K}[End]

and below

No keymap with that trigger. Press any key to continue.

I got out, changed the line in the pref from {K}1 to {K}[End] , restarted and the 1 worked.

Thanks. I am a bit surprised that running worked for you, as I don't see any default mappings for {SK}[End]. Does anything change if you toggle numlock? I can't think of any harm to adding the Home, Page Up, etc. keypad mappings to pref.prf, but I may be missing something.

[PowerDiver]

They should work fine anywhere, as long as you don't have another overriding keymap elsewhere. It is probably cleaner if you download a new pref.prf from the link above, though.

If you query the keymap for keypad 1 (Interact with macros => Query a keymap => KP 1), what key and action do you find, if any?

When I press the 1 on the numpad, the Key line changes to

Key: {K}[End]

and below

No keymap with that trigger. Press any key to continue.

I got out, changed the line in the pref from {K}1 to {K}[End] , restarted and the 1 worked.

[myshkin]

Do those keypad lines need to go in any particular place? I pasted them into lib/pref.prf near the top, just before the # Movement comment, and my keypad problem remains.

They should work fine anywhere, as long as you don't have another overriding keymap elsewhere. It is probably cleaner if you download a new pref.prf from the link above, though.

If you query the keymap for keypad 1 (Interact with macros => Query a keymap => KP 1), what key and action do you find, if any?

[PowerDiver]

Do those keypad lines need to go in any particular place? I pasted them into lib/pref.prf near the top, just before the # Movement comment, and my keypad problem remains.

[myshkin]

Actually, it turns out that the correct fix for the keypad bug is simply to add those entries into pref.prf. This should go into the nightlies soon. If you would like to test before then, you can get the raw version from github and drop it into .../lib/pref.

[myshkin]

The input layer refactor of February 15 introduced the keypad problem and removed macros. I don't yet understand the code, and so have not come up with a code-level fix yet for the keypad problem. However, if you add the lines below to your .prf file, your keypad should work again. (Change the 0 in the C: lines to a 1 if you use the roguelike keyset.)

A:;1
C:0:{K}1

A:;2
C:0:{K}2

A:;3
C:0:{K}3

A:;4
C:0:{K}4

A:;5
C:0:{K}5

A:;6
C:0:{K}6

A:;7
C:0:{K}7

A:;8
C:0:{K}8

A:;9
C:0:{K}9

In addition, to convert your macros to keymaps, edit your .prf file. You will need to convert every P: line to a C: line. The format of the C: line is C:mode:keypress, where mode is 0 for the normal keyset and 1 for the roguelike keyset. The keypress syntax is somewhat different from the macros. Experimenting with the query mode may be the easiest way to understand the syntax for now, unless you want to read keypress_from_text() in ui-event.c. Here are a few examples:

Macro P: line                           Keymap C: line
P:\[F15]                                C:0:[F15]
P:\[shift-F15]                          C:0:{S}[F15]
P:\[KP_8]                               C:0:{K}8
P:\[option-KP_0]                        C:0:{AK}0
P:\[control-KP_0]                       C:0:{^K}0
P:\[Right]                              C:0:[Right]

[scud]

Perhaps you should add your comments to that ticket.

Done.









*adds words to hit the required character count*