Cthangband Crash

[karat]

I just had a crash with Cthangband 6.3. It crashed when dropping an item (via the clumsy mutation) that was equipped while I had a full inventory.

A screenshot should be attached.

[karat]

Okay, it happened again. Yes, I believe what is happening is that my inventory is full, but my clumsy mutation causes me to drop my equipped weapon, which goes into Cthangband.inventory.invenTakeoff, but has an index error in Cthangband.extensions.indexToLabel, since my inventory a-z is full.

[karat]

Here's a different Cthangband crash. I entered Kadath (city, not the dungeon). Got in trouble. Read a Word of Recall scroll from the city. Then, I exited the city before the recall kicked in. Finally, the recall kicked in from the wilderness, and the game crashed.

Screenshot included

[karat]

I have a third type of crash. If I enter the Demon's Spire, the game becomes unresponsive. This is easily reproduced with my save below.

https://drive.google.com/file/d/16MgSrFka91YbzbQ8pY2yqHL2z9KNQCBj/view?usp=sharing

[Dean Anderson]

Thanks for the reports.

I've been working on another project for the last couple of months, but I'm in a position to start looking at Cthangband again now so I'll take a look at them.

[karat]

Thanks for the reports.

I've been working on another project for the last couple of months, but I'm in a position to start looking at Cthangband again now so I'll take a look at them.

I also had another thread where my cloak wasn't giving me abilities (eg 'see invisible'), but I wasn't sure if that was a bug or a flaw in my understanding.

Thanks for taking a look!

[Dean Anderson]

I also had another thread where my cloak wasn't giving me abilities (eg 'see invisible'), but I wasn't sure if that was a bug or a flaw in my understanding.

Thanks for taking a look!

Well, in a very productive evening I managed to fix all the reported bugs apart from this one.

• The Demon Spire hang was because it had an invalid quest monster on its first level so it got in an infinite loop when trying to place the non-existent monster (this was because the monster's name was misspelled in earlier versions; in 6.3 I fixed the spellling in the monster record but hadn't noticed that the Demon Spire's dungeon record still referred to the monster under its old misspelled name).
• The Word of Recall crash was because when you teleport from the surface to a dungeon the game wasn't correctly updating your wilderness location until you emerged from the dungeon once more. This is a very old bug (it's been there since the introduction of the wilderness in Cthangband 3.0.0), but in previous versions I'd never noticed it because it had never made a difference - your wilderness location is never looked at while you're in the dungeon. However, a recent change to the level generation code now means that it does suddenly matter, but only if you're recalling from a wilderness grid that doesn't have a dungeon of its own (i.e. an empty one that isn't a town and isn't an outdoor dungeon/tower).
• The inventory issue is a knock-on effect for the larger inventory introduced in 6.3. It happened every time your inventory "overflowed" (because you've taken something off with a full inventory or because you've used an item that was stacked and they've been forcibly unstacked while you have a full inventory). During the overflow you temporarily have one more item in your pack than it can normally hold. The inventory management code was handling it fine, it was just the display code telling you that the extra item was about to be dropped that would have a problem with running out of letters of the alphabet when describing the item's temporary inventory slot.

However, I've not been able to reproduce the issue of an item not granting abilities. Do you have a save-file that manifests that issue, by any chance?

[karat]

Well, in a very productive evening I managed to fix all the reported bugs apart from this one.

• The Demon Spire hang was because it had an invalid quest monster on its first level so it got in an infinite loop when trying to place the non-existent monster (this was because the monster's name was misspelled in earlier versions; in 6.3 I fixed the spellling in the monster record but hadn't noticed that the Demon Spire's dungeon record still referred to the monster under its old misspelled name).
• The Word of Recall crash was because when you teleport from the surface to a dungeon the game wasn't correctly updating your wilderness location until you emerged from the dungeon once more. This is a very old bug (it's been there since the introduction of the wilderness in Cthangband 3.0.0), but in previous versions I'd never noticed it because it had never made a difference - your wilderness location is never looked at while you're in the dungeon. However, a recent change to the level generation code now means that it does suddenly matter, but only if you're recalling from a wilderness grid that doesn't have a dungeon of its own (i.e. an empty one that isn't a town and isn't an outdoor dungeon/tower).
• The inventory issue is a knock-on effect for the larger inventory introduced in 6.3. It happened every time your inventory "overflowed" (because you've taken something off with a full inventory or because you've used an item that was stacked and they've been forcibly unstacked while you have a full inventory). During the overflow you temporarily have one more item in your pack than it can normally hold. The inventory management code was handling it fine, it was just the display code telling you that the extra item was about to be dropped that would have a problem with running out of letters of the alphabet when describing the item's temporary inventory slot.

However, I've not been able to reproduce the issue of an item not granting abilities. Do you have a save-file that manifests that issue, by any chance?

It's in the same save I attached for the Demon's Spire earlier in this thread. (Rather, I shared it through Google Drive, since it was too big to attach.)

I'm still not 100% sure that one is a bug, but if I look in the Journal/abilities, I don't see anything for that column, but I see the properties if I examine that same item in the equipment list. I also don't seem to be able to see invisible in practice either. However, I do gain AC from the cloak.

[Dean Anderson]

It's in the same save I attached for the Demon's Spire earlier in this thread. (Rather, I shared it through Google Drive, since it was too big to attach.)

I'm still not 100% sure that one is a bug, but if I look in the Journal/abilities, I don't see anything for that column, but I see the properties if I examine that same item in the equipment list. I also don't seem to be able to see invisible in practice either. However, I do gain AC from the cloak.

I've found (and fixed) the bug with the ability display - it wasn't showing the abilities for 'fixed' (i.e. non-random) artifacts properly. For example in your character it wasn't showing the abilities for either the Star Essence of Polaris or the Cloak 'Shade'.

Debugging through the code with your save file shows that it was giving you all of their abilities though - it was just a display issue. Your character was able to see invisible and did have free action, just as they did have the armour class bonus and did have the light from the star essence. It just wasn't showing those abilities on the journal page.

[Dean Anderson]

I just thought I'd mention that the bugfixes for all these are in Cthangband 6.4 here, in case you subscribed to this thread to get notified about responses.