Unangband 0.6.4-pre3 released

[Arralen]

I'll have a look in this in more detail: I think the pic you've attached has turned into a thumbnail which I can't seem to expand.

New link to screenshot here !

('was way too big to attach, or even link directly, from the forum ...)

[SaThaRiel]

Hi Andrew,

i got new warnings

load.c: In function ‘rd_extra’:
load.c:1221: warning: array subscript is above array bounds
load.c:1223: warning: array subscript is above array bounds

and

main-x11.c:1730: warning: ‘copy_x11_start’ defined but not used

The other 2 "defined but not used" warnings from the prerelease before still exists, i think you want to fix them in the release.

[andrewdoull]

New link to screenshot here !

('was way too big to attach, or even link directly, from the forum ...)

Thanks - got it. I know the problem - I'll see what I can do.

Andrew

[andrewdoull]

Hi Andrew,

i got new warnings

load.c: In function ‘rd_extra’:
load.c:1221: warning: array subscript is above array bounds
load.c:1223: warning: array subscript is above array bounds

Thanks. Fixed.

and

main-x11.c:1730: warning: ‘copy_x11_start’ defined but not used

Not in code I can compile and test at the moment.

The other 2 "defined but not used" warnings from the prerelease before still exists, i think you want to fix them in the release.

I may do. Depends if I get back to that code during this development cycle.

Andrew

[Big Al]

Looking great so far!

If I may suggest, make the various notes you find only show up once per savefile, not once lifetime? There are some very useful notes out there so I don't want to turn off notes altogether, but getting a note about mushrooms for the hundredth time is not so fun. (I die a lot. ) Perhaps as another option?

Also, a "bug" perhaps: I cast chill on a shrieker mushroom, it dies and drops a smelly mushroom. I go over to pick it up and nearly died because the chill effect is still lingering, but I couldn't see it because of the dropped mushroom. I don't know which is more important to show: the region effect or the objects but it's kind of unclear.

Cheers!

[ekolis]

Seconded on the notes!

[andrewdoull]

Seconded on the notes!

I suspect part of the problem here is people are reloading the old save game - one of the requirements for the competition - and the fact the notes have been read is stored in the save file.

There really needs to be a user based rather than save game based repository for information, such as monster memory. Angband doesn't have one and should.

I'd love to hear technical suggestions as to how to do this.

Andrew

[Pete Mack]

Pretty much you need to keep two copies of the "lore" in memory, and add the delta to the monster lore file every time you save.
It's occurred to me more than once that competition files should be with full monster knowledge, since experienced players already have a large advantage, even without knowing the monsters in advance.

[andrewdoull]

Pretty much you need to keep two copies of the "lore" in memory, and add the delta to the monster lore file every time you save.

Since monster memory is only additive, you should be able to effectively AND the two together as opposed to worry about deltas. I was more worried about having ensuring there's a non-platform specific way of referencing the files, and whether the format should be platform independent binaries or something else, like the PRF files are.

It's occurred to me more than once that competition files should be with full monster knowledge, since experienced players already have a large advantage, even without knowing the monsters in advance.

I ended up making full monster knowledge a birth option rather than a cheat option along similar reasoning.

Andrew

[takkaria]

Since monster memory is only additive, you should be able to effectively AND the two together as opposed to worry about deltas. I was more worried about having ensuring there's a non-platform specific way of referencing the files, and whether the format should be platform independent binaries or something else, like the PRF files are.

The way would be to have another savefile in the save directory that was (I would have thought) binary, on unix systems prefixed with the uid for multi-player installs. In V, monster lore flags are now "this flag is known or the absence of this flag is known" rather than just "this flag is known", so even if monster info changes, the lore isn't messed up. Platform independent like the savefiles isn't hard, you just have to use the same routines as the savefile code does.

I used to be against this idea but I'm not anymore, it seems. The only thing to be careful about is introducing a race condition if two games are being played at once.

[Pete Mack]

The possibility of a race condition is why I suggested deltas.