Tiny Display bug with 4.2

[bron]

I'm playing in the current competition, and I notice something odd: my Priest character has cast Heroism, and this does show correctly in the status line at the bottom of the normal play screen, but in the character status screen where the resists (etc.) are shown, it does NOT have the expected '!' in the '@' slot of the 'pFear' line.

[PowerWyrm]

I'm playing in the current competition, and I notice something odd: my Priest character has cast Heroism, and this does show correctly in the status line at the bottom of the normal play screen, but in the character status screen where the resists (etc.) are shown, it does NOT have the expected '!' in the '@' slot of the 'pFear' line.

IIRC in the latest version, Heroism doesn't provide pFear anymore, just the AC and tohit boost. Same applies to Berserk. No idea if it's a bug or a feature.

[bron]

IIRC in the latest version, Heroism doesn't provide pFear anymore

Humm .. if true, then the bug is in the documentation - the description of the Priestly "Heroism" spell says that it provides resistance to fear. I will say that my character has not been made afraid ever since I started running with Heroism on all the time, so it certainly *seems* like I'm getting pFear. OTOH, the character has a high saving throw (as of now, it's 100%, although it wasn't earlier), so maybe I just got really lucky (?)

[Sphara]

Does pFear show after you've reached CL 20?

[bron]

Does pFear show after you've reached CL 20?

The character is CL41 at the moment, and there is no indication on the character status screen (as shown, e.g. in the char dump for Morin in competition 223). The "Browse" description of the Prayer is still the same, and the "Hero" indication is shown on the bottom of the main play screen.

[bron]

Looking at calc_bonuses in player-calcs.c I see that both heroism (HERO) and berserk (SHERO) *do* set the PROT_FEAR flag. So it kinda looks like the original post was correct and this is just a (very minor) issue with the character status display.

[bron]

So .. I'm no expert on the Angband code, but a quick look at it makes me think the problem is that in calc_bonuses, both p->timed[TMD_HERO] and p->timed[TMD_SHERO] set OF_PROT_FEAR directly, but display_resistance_panel in ui-player.c appears to use player->timed[TMD_BOLD] when figuring out whether or not to display the '!'