[bug] solid_walls options in gcu module

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Egres
    Rookie
    • Apr 2019
    • 8

    [bug] solid_walls options in gcu module

    Angband 4.1.3, linux, gnome-terminal
    ./angband -mgcu

    I can't turn solid walls on with gcu module. If I select x11 - solid walls work fine, but in gcu it looks like the hybrid_walls option is permanently linked to the solid_walls option.

    solid_walls = off
    hybrid_walls = off


    solid_walls = on
    hybrid_walls = off


    solid_walls = on
    hybrid_walls = on


    solid_walls = off
    hybrid_walls = on



    How can I get solid walls in text only mode?

    P.S. In older versions I remember the "interact with visuals" menu item, but now it gone
  • Nick
    Vanilla maintainer
    • Apr 2007
    • 9637

    #2
    I'm not sure of this - solid walls were first implemented in the gcu port in 2012 - but I believe it may be a terminal setting that's the problem. But maybe not. I'll try to ask someone who knows better.
    One for the Dark Lord on his dark throne
    In the Land of Mordor where the Shadows lie.

    Comment

    • takkaria
      Veteran
      • Apr 2007
      • 1951

      #3
      Originally posted by Egres
      P.S. In older versions I remember the "interact with visuals" menu item, but now it gone
      Everything you used to be able to do in that screen you can now do on the knowledge (~) screens. It wouldn't have helped with this, which looks a rendering issue in the curses port.
      takkaria whispers something about options. -more-

      Comment

      • Egres
        Rookie
        • Apr 2019
        • 8

        #4
        Originally posted by Nick
        I'm not sure of this - solid walls were first implemented in the gcu port in 2012 - but I believe it may be a terminal setting that's the problem. But maybe not. I'll try to ask someone who knows better.
        Thank you. Can you open the ticket on
        https://trac.rephial.org about this issue?
        Last edited by Egres; April 8, 2019, 10:33.

        Comment

        • Egres
          Rookie
          • Apr 2019
          • 8

          #5
          Originally posted by takkaria
          Everything you used to be able to do in that screen you can now do on the knowledge (~) screens.
          Thank you very much. But how I can change the symbol for the wall, by example?

          Display current knowledge (~) -> Display feature knowledge -> Walls -> permanent wall -> 'v' and ... what next? I can change color of the wall by left/right arrow, but how I can to change the symbol ('#') itself?

          Comment

          • takkaria
            Veteran
            • Apr 2007
            • 1951

            #6
            Originally posted by Egres
            Thank you very much. But how I can change the symbol for the wall, by example?

            Display current knowledge (~) -> Display feature knowledge -> Walls -> permanent wall -> 'v' and ... what next? I can change color of the wall by left/right arrow, but how I can to change the symbol ('#') itself?
            'i' will let you enter the ASCII code of the symbol, in hexadecimal - see https://en.wikipedia.org/wiki/ASCII#...ble_characters for a list.
            takkaria whispers something about options. -more-

            Comment

            • Egres
              Rookie
              • Apr 2019
              • 8

              #7
              Originally posted by takkaria
              'i' will let you enter the ASCII code of the symbol, in hexadecimal - see https://en.wikipedia.org/wiki/ASCII#...ble_characters for a list.
              This is somewhat less convenient, then in older versions (3.x?), but ok.
              Thank you again.

              Upd: The right link is https://en.wikipedia.org/wiki/Block_Elements
              Last edited by Egres; April 8, 2019, 13:18.

              Comment

              • takkaria
                Veteran
                • Apr 2007
                • 1951

                #8
                Originally posted by Egres
                This is somewhat less convenient, then in older versions (3.x?), but ok.
                Thank you again.
                Yeah it is a bit less convenient. Last time I looked I remember it having a symbol picker too. I think it's only enabled in tiles mode now. Honestly, though, if you want to use U+2580 as your symbol then you're better off not scrolling through 9600 characters first

                Fair point!
                takkaria whispers something about options. -more-

                Comment

                • Egres
                  Rookie
                  • Apr 2019
                  • 8

                  #9
                  Originally posted by takkaria
                  Honestly, though, if you want to use U+2580 as your symbol then you're better off not scrolling through 9600 characters first
                  2588

                  It's very strange, but in this menu used hex coded, but in prf files - decimal ones. So 2588 (walls and lava) turns to 9608 and vains (2593) to 9619

                  Code:
                  #=#=#=#=#=#=#=#=#=#=#=#=#=#=#=#=#=#=#=# begin Save feature attr/chars
                  # *Warning!*  The lines below are an automatic dump.
                  # Don't edit them; changes will be deleted and replaced automatically.
                  #
                  # [...]
                  #
                  # Terrain: magma vein
                  feat:magma vein:los:2:9619
                  feat:magma vein:torch:2:9619
                  feat:magma vein:lit:2:9619
                  feat:magma vein:dark:2:9619
                  # Terrain: quartz vein
                  feat:quartz vein:los:9:9619
                  feat:quartz vein:torch:9:9619
                  feat:quartz vein:lit:9:9619
                  feat:quartz vein:dark:9:9619
                  # Terrain: granite wall
                  feat:granite wall:los:1:9608
                  feat:granite wall:torch:1:9608
                  feat:granite wall:lit:1:9608
                  feat:granite wall:dark:1:9608
                  # Terrain: permanent wall
                  feat:permanent wall:los:26:9608
                  feat:permanent wall:torch:26:9608
                  feat:permanent wall:lit:26:9608
                  feat:permanent wall:dark:26:9608
                  # Terrain: lava
                  feat:lava:los:4:9608
                  feat:lava:torch:4:9608
                  feat:lava:lit:4:9608
                  feat:lava:dark:4:9608

                  Comment

                  • takkaria
                    Veteran
                    • Apr 2007
                    • 1951

                    #10
                    Originally posted by Egres
                    2588
                    Depends how you count...

                    It's very strange, but in this menu used hex coded, but in prf files - decimal ones. So 2588 (walls and lava) turns to 9608 and vains (2593) to 9619
                    That's probably my fault. I probably half-assed tried to move away from using hex in the pref files to make stuff easier to understand (especially for tiles) but never finished the job. Typical of my tenure, really 🙃
                    takkaria whispers something about options. -more-

                    Comment

                    • Egres
                      Rookie
                      • Apr 2019
                      • 8

                      #11
                      Originally posted by takkaria
                      It wouldn't have helped with this, which looks a rendering issue in the curses port.
                      Apropos, if you are Angband developer, can explain this sentence a bit more? Is this a bug in Anbgnad and therefore it may be fixed in the future or this is "just ncurses poprblem", so nothing to talk about it?

                      if this is still a bug, can you open a ticket on trac? I can't do it myself.

                      Comment

                      • takkaria
                        Veteran
                        • Apr 2007
                        • 1951

                        #12
                        Originally posted by Egres
                        Apropos, if you are Angband developer, can explain this sentence a bit more? Is this a bug in Anbgnad and therefore it may be fixed in the future or this is "just ncurses poprblem", so nothing to talk about it?
                        It wasn't a helpful answer - I'd forgotten that you can reassign symbols in text mode. Looking at the curses port's code, I'm surprised that you are even getting a different background colour - I can't see where in the code that would happen!

                        I will file a Trac ticket.
                        takkaria whispers something about options. -more-

                        Comment

                        • Egres
                          Rookie
                          • Apr 2019
                          • 8

                          #13
                          Originally posted by takkaria
                          I will file a Trac ticket.
                          Thank you.

                          Comment

                          • takkaria
                            Veteran
                            • Apr 2007
                            • 1951

                            #14
                            Originally posted by Egres
                            Thank you.
                            Turns out I can't because I have long since lost my login password and I can't find any way to reset it! Sorry. I'm not even sure who hosts Trac now...
                            takkaria whispers something about options. -more-

                            Comment

                            • moosferatu
                              Apprentice
                              • Feb 2020
                              • 99

                              #15
                              Originally posted by Egres
                              Apropos, if you are Angband developer, can explain this sentence a bit more? Is this a bug in Anbgnad and therefore it may be fixed in the future or this is "just ncurses poprblem", so nothing to talk about it?

                              if this is still a bug, can you open a ticket on trac? I can't do it myself.
                              This was bothering me this weekend, so I looked into it and was able to fix it.

                              This PR fixes two GCU issues. It fixes the bug where solid walls are displayed as hybrid walls (described here). The problem was that it was just inverting the bg and fg colors rather than setting...

                              Comment

                              Working...
                              😀
                              😂
                              🥰
                              😘
                              🤢
                              😎
                              😞
                              😡
                              👍
                              👎