Dimension Door bug

[kandrc]

Playing from a several-weeks-old git checkout, ga4f08cb. My mage just got Dimension Door. I tried to test it out in town. Game went into an infinite loop:

Program received signal SIGINT, Interrupt.
square_in_bounds_fully (c=0xa6bea8, grid=...) at cave-square.c:883
883             return grid.x > 0 && grid.x < c->width - 1 &&
(gdb) bt
#0  square_in_bounds_fully (c=0xa6bea8, grid=...) at cave-square.c:883
#1  0x000000000041945c in effect_handler_TELEPORT_TO (context=0x7fffffffd870)
    at effects.c:2915
#2  0x000000000041e099 in effect_do (effect=0x849f98, origin=..., obj=0x0, 
    ident=0x9df7f8, aware=true, dir=0, beam=36, boost=0) at effects.c:5251
#3  0x000000000049ab84 in spell_cast (spell_index=23, dir=0)
    at player-spell.c:491
#4  0x00000000004116f8 in do_cmd_cast (cmd=0x764210 <cmd_queue+880>)
    at cmd-obj.c:971
#5  0x000000000040e91e in process_command (ctx=CMD_GAME, 
    cmd=0x764210 <cmd_queue+880>) at cmd-core.c:235
#6  0x000000000040ea1a in cmdq_pop (c=CMD_GAME) at cmd-core.c:264
#7  0x0000000000420896 in process_player () at game-world.c:900
#8  0x0000000000420b6f in run_game_loop () at game-world.c:1004
#9  0x00000000004be6c9 in play_game (new_game=false) at ui-game.c:435
#10 0x00000000004f7a75 in main (argc=1, argv=0x7fffffffdbb8) at main.c:528

I doubt it matters, but I was standing on a shop entrance.

[Nick]

My first guess was that it's looking for a grid far enough away and can't find one, but I'm not sure if that makes sense. I've filed it as a bug; let me know if it still happens in the dungeon.

[kandrc]

Confirmed that I also get the infinite loop in the dungeon.

[Nick]

At what stage were you - had you chosen a place to teleport to?

There are definite problems with the spell (I can make it crash by giving a direction instead of choosing a grid); I want to try and get them all fixed at once.

[kandrc]

I cast and am immediately in an infinite loop.

[Nick]

This seems fine in the current revision - is anyone seeing any problems with Dimension Door now?

[Chud]

The last time I ran a mage was two or three nightlies ago at least, but it always worked correctly for me. I never tried giving it a direction though, I always picked a specific target.