Bugs and issues in 4.1.2

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Nick
    Vanilla maintainer
    • Apr 2007
    • 9338

    Originally posted by Ingwe Ingweron
    I understand your point, and generally I agree. But for stuff that is purely UI type changes, you've often made the change to master and then added it to the feature branch. It's odd that this one UI change you made to feature branch only. In the interest of having a completed, definitive, 4.1 series completed, I hope you'd make an exception here and add the UI change.
    That is because this wasn't a purely UI change, but a side effect of some broader changes that I was making to timed effects. It would be possible to pull those changes out, apply those of them that do apply to master, and then adjust feature/magic, but it's a pain and I think my time (which is an increasingly limited resource, I am finding) is better spent elsewhere.

    Originally posted by Ingwe Ingweron
    Or is the major feature branch stuff going to be part of the 4.1 series? I always thought those major deviations weren't going to come in except as 4.2.
    Correct. I'm hoping for 4.1.3 to be the last 4.1 release.
    One for the Dark Lord on his dark throne
    In the Land of Mordor where the Shadows lie.

    Comment

    • spara
      Adept
      • Nov 2014
      • 235

      @ is wearing a Ring of Searching and the ring shop shows question marks on a Ring of Searching it's selling.

      Latest master version. I think. Save attached.

      ros.zip

      Comment

      • spara
        Adept
        • Nov 2014
        • 235

        Oh and the general store shows this:

        Click image for larger version

Name:	general_store.png
Views:	1
Size:	4.0 KB
ID:	233162

        Something wrong with my compiled version of Angband or are these bugs I'm seeing?

        Comment

        • Nick
          Vanilla maintainer
          • Apr 2007
          • 9338

          Originally posted by spara
          Something wrong with my compiled version of Angband or are these bugs I'm seeing?
          I'm seeing it in the development version too. Looks like my changes yesterday introduced a bug

          EDIT: In fact, the error seems to date back a few months. Will fix soon.
          Last edited by Nick; July 8, 2018, 02:17. Reason: Worse than I realised
          One for the Dark Lord on his dark throne
          In the Land of Mordor where the Shadows lie.

          Comment

          • spara
            Adept
            • Nov 2014
            • 235

            I read a Scroll of Summon Monster and it summoned two uniques. It should not do that, right?

            Comment

            • Nick
              Vanilla maintainer
              • Apr 2007
              • 9338

              Originally posted by spara
              I read a Scroll of Summon Monster and it summoned two uniques. It should not do that, right?
              It's not impossible - there was a recently fixed bug where it always summoned uniques, though, which it shouldn't.
              One for the Dark Lord on his dark throne
              In the Land of Mordor where the Shadows lie.

              Comment

              • spara
                Adept
                • Nov 2014
                • 235

                Ok. Maybe @ was just (un)lucky .

                Comment

                • PowerWyrm
                  Prophet
                  • Apr 2008
                  • 2940

                  Originally posted by Nick
                  It's not impossible - there was a recently fixed bug where it always summoned uniques, though, which it shouldn't.
                  The fix you applied is only for traps
                  Still occuring with scrolls
                  PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

                  Comment

                  • kaypy
                    Swordsman
                    • May 2009
                    • 292

                    Looking at items in shops gives you a description of what items do, even if you haven't identified that flavour yet.

                    Pretty reasonable so far, but:
                    Home storage is implemented as a type of shop...

                    So you can figure out flavours for free just by dropping them off for a minute.

                    (Found it in the feature branch, but just checked against the latest 4.1.x nightly. I have never before had to clear so much of level 1 to find some un-ided junk)

                    Comment

                    • Nick
                      Vanilla maintainer
                      • Apr 2007
                      • 9338

                      Originally posted by PowerWyrm
                      The fix you applied is only for traps
                      Still occuring with scrolls
                      ...and staffs. Bollocks.
                      One for the Dark Lord on his dark throne
                      In the Land of Mordor where the Shadows lie.

                      Comment

                      • spara
                        Adept
                        • Nov 2014
                        • 235

                        Funny how a change of graphics just feels wrong. I've been playing with Gervais tiles as long as I remember. Which is at least from the end of the '90s. And now the rubble tile has changed as a result to distinguish passable rubble I suppose. It's a good thing one can edit the tile map to ones liking. Just coloring the impassable rubble to brown would suffice nicely:

                        Click image for larger version

Name:	rubble.png
Views:	1
Size:	3.9 KB
ID:	233172

                        Anyone else find the new tile out of place?

                        Comment

                        • luneya
                          Swordsman
                          • Aug 2015
                          • 279

                          Originally posted by spara
                          Funny how a change of graphics just feels wrong. I've been playing with Gervais tiles as long as I remember. Which is at least from the end of the '90s. And now the rubble tile has changed as a result to distinguish passable rubble I suppose. It's a good thing one can edit the tile map to ones liking. Just coloring the impassable rubble to brown would suffice nicely:

                          [ATTACH]1651[/ATTACH]

                          Anyone else find the new tile out of place?
                          Of course. Everyone knows that rubble should look like :

                          I've never played Angband using anything other than ASCII, so any tileset looks wrong to me.

                          Comment

                          • spara
                            Adept
                            • Nov 2014
                            • 235

                            Originally posted by luneya
                            Of course. Everyone knows that rubble should look like :

                            I've never played Angband using anything other than ASCII, so any tileset looks wrong to me.
                            It's the first impression that sticks. I started playing Moria on Amiga 500 back in the day and that version had tiles. Later on progression to Angband and Gervais-tiles was very natural. I tried playing with ASCII at some point and it just didn't work for me,. For me it has to be Gervais tiles, and now someone has broken my rubble .

                            Comment

                            • Nick
                              Vanilla maintainer
                              • Apr 2007
                              • 9338

                              Originally posted by spara
                              It's the first impression that sticks. I started playing Moria on Amiga 500 back in the day and that version had tiles. Later on progression to Angband and Gervais-tiles was very natural. I tried playing with ASCII at some point and it just didn't work for me,. For me it has to be Gervais tiles, and now someone has broken my rubble .
                              Don't you like the fact that this one actually changes with light level?
                              One for the Dark Lord on his dark throne
                              In the Land of Mordor where the Shadows lie.

                              Comment

                              • spara
                                Adept
                                • Nov 2014
                                • 235

                                Originally posted by Nick
                                Don't you like the fact that this one actually changes with light level?
                                That's cool of course, but the actual graphic is quite out of place with Gervais tiles. The background makes the tile look like a something like a marble tile that has stuff on it, because there's some sort of emboss as a frame. Also the actual graphic is somehow more cartoony than the other set. My daughter watched me play and spontaneously asked if that's a potato .

                                This is really just nitpicking. I just wanted wanted to voice this out as an old school tile player, since most of you seem to prefer ASCII.

                                Edit: And to anyone who's wondering what's this all about, here's the old and the new tile in action:
                                Click image for larger version

Name:	old_tile.png
Views:	1
Size:	6.6 KB
ID:	233173
                                Click image for larger version

Name:	new_tile.png
Views:	1
Size:	7.2 KB
ID:	233174

                                Edit2: And here's what the old one looks like with proper backgrounds:
                                Click image for larger version

Name:	old_wtih_bg.png
Views:	1
Size:	12.8 KB
ID:	233175

                                I think it works better, but I'm kind of biased with this for solely playing with this tile set for so long.
                                Last edited by spara; July 10, 2018, 10:45.

                                Comment

                                Working...
                                😀
                                😂
                                🥰
                                😘
                                🤢
                                😎
                                😞
                                😡
                                👍
                                👎