ignoring lights

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Sky
    Veteran
    • Oct 2016
    • 2321

    ignoring lights

    i was thinking, what if you have a randart set with randart torches, and you set your game to ignore torches .. that means the artifact would not be visible, right? generally, when i find a lantern, i immediately set my torches to squelch. but, that means i'll never see any artifact torch, unless i walk over it, or not even that ?
    "i can take this dracolich"
  • Pete Mack
    Prophet
    • Apr 2007
    • 6883

    #2
    That's right--unless you can squelch all except artifact.

    Comment

    • Sky
      Veteran
      • Oct 2016
      • 2321

      #3
      i'm sorry, something is not right here.

      if i ignore "every cloak except artifacts" then i still see cloaks; once i walk over them, if they are not an artifact, they disappear.

      if i ignore "every torch except artifacts", ALL the torches disappear.
      "i can take this dracolich"

      Comment

      • Nick
        Vanilla maintainer
        • Apr 2007
        • 9638

        #4
        Looking at the code, artifact torches should not ever be ignored - even if you set torches to be ignored in the main ignore list. Have you ever come across a case where they are?
        One for the Dark Lord on his dark throne
        In the Land of Mordor where the Shadows lie.

        Comment

        • Sky
          Veteran
          • Oct 2016
          • 2321

          #5
          well, i can't tell, can i ?

          it just seems weird that, with artifact lights being the most common, and almost every set of randarts generating a torch or lantern randart, i never seem to find any after the ignore is set on.

          im gonna do a quick testing.
          "i can take this dracolich"

          Comment

          • kandrc
            Swordsman
            • Dec 2007
            • 299

            #6
            Originally posted by Sky
            well, i can't tell, can i ?

            it just seems weird that, with artifact lights being the most common, and almost every set of randarts generating a torch or lantern randart, i never seem to find any after the ignore is set on.

            im gonna do a quick testing.
            To add my own anecdote to Sky's, I've never found an artifact torch, and I've only found one artifact lantern, in many games since they were added.

            Comment

            • Nick
              Vanilla maintainer
              • Apr 2007
              • 9638

              #7
              All right, bug found - and it's not at all as expected. There was an error in choosing the kinds for objects to base randarts on which meant the first of any type never got chosen, namely:
              • Torch
              • Dagger
              • Whip
              • Spear
              • Sling
              • Shovel
              • Leather Sandals
              • Hard Leather Cap
              • Iron Crown
              • Robe
              • Metal Scale Mail
              • Cloak
              • Leather Gloves
              • Wicker Shield
              • Ring (rings were always Band)
              • Amulet (amulets were Pendant, Necklace, etc)
              • Black Dragon Scale Mail


              Well done all, glad to find that one
              One for the Dark Lord on his dark throne
              In the Land of Mordor where the Shadows lie.

              Comment

              • Sky
                Veteran
                • Oct 2016
                • 2321

                #8
                Another victory for empirical analysis
                "i can take this dracolich"

                Comment

                • PowerWyrm
                  Prophet
                  • Apr 2008
                  • 2986

                  #9
                  Originally posted by Nick
                  All right, bug found - and it's not at all as expected. There was an error in choosing the kinds for objects to base randarts on which meant the first of any type never got chosen, namely:
                  • Torch
                  • Dagger
                  • Whip
                  • Spear
                  • Sling
                  • Shovel
                  • Leather Sandals
                  • Hard Leather Cap
                  • Iron Crown
                  • Robe
                  • Metal Scale Mail
                  • Cloak
                  • Leather Gloves
                  • Wicker Shield
                  • Ring (rings were always Band)
                  • Amulet (amulets were Pendant, Necklace, etc)
                  • Black Dragon Scale Mail


                  Well done all, glad to find that one
                  That's strange... I remember a similar bug being fixed for 4.1, but maybe it was concerning egos I don't remember. But yes, finding always "Bands" should have made it obvious there was something fishy going on.
                  PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

                  Comment

                  • Nick
                    Vanilla maintainer
                    • Apr 2007
                    • 9638

                    #10
                    Originally posted by PowerWyrm
                    That's strange... I remember a similar bug being fixed for 4.1, but maybe it was concerning egos I don't remember. But yes, finding always "Bands" should have made it obvious there was something fishy going on.
                    I was previously off by one in the other direction - so no Arkenstones, etc
                    One for the Dark Lord on his dark throne
                    In the Land of Mordor where the Shadows lie.

                    Comment

                    • Ingwe Ingweron
                      Veteran
                      • Jan 2009
                      • 2129

                      #11
                      And I remember a similar but that I reported and Nick fixed sometime ago, that torched of brightness weren't appearing. If I recall, it was a similar one integer off bug.
                      “We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
                      ― Tom Stoppard, Rosencrantz and Guildenstern are Dead

                      Comment

                      Working...
                      😀
                      😂
                      🥰
                      😘
                      🤢
                      😎
                      😞
                      😡
                      👍
                      👎