bug with acid brand on aule

[Sornil]

My great hammer Aule is only doing x2 weapon damage with its acid brand. The dissolve emote is chosen and x2 damage is dealt even when another slay is available, such as x3 for slay undead.

For example, and this is how I noticed it, I was dissolving a vampire lord for 85 per hit, and then I was smiting an undead beholder, which resists acid, for 103 per hit.

I haven't checked any other acid brand weapons to see if it is global.

I am playing the 4.1.0 release.

[Nick]

I will investigate.

EDIT: Confirmed. I'll look to see how widespread this is.

[PowerWyrm]

Easy

static int melee_damage(struct object *obj, int b, int s)
{
	int dmg = damroll(obj->dd, obj->ds);

	if (s)
		dmg *= slays[s].multiplier;
	else if (b)
		dmg *= slays[b].multiplier;

	dmg += obj->to_d;

	return dmg;
}

Using "brand" for a brand should work better

[Nick]

Easy

static int melee_damage(struct object *obj, int b, int s)
{
	int dmg = damroll(obj->dd, obj->ds);

	if (s)
		dmg *= slays[s].multiplier;
	else if (b)
		dmg *= slays[b].multiplier;

	dmg += obj->to_d;

	return dmg;
}

Using "brand" for a brand should work better

Wow, that must have been leading to all sorts of hilarity.

[Nick]

In fact, the acid brand was the only one of the regular brands to be affected.

On the other hand, anyone with a randart with a "weak" poison, cold or fire brand was getting a x5 multiplier

[PowerWyrm]

In fact, the acid brand was the only one of the regular brands to be affected.

On the other hand, anyone with a randart with a "weak" poison, cold or fire brand was getting a x5 multiplier

Elec was affected too since it was remapped to the 2nd slay, which is slay animal (x2).

[Nick]

Elec was affected too since it was remapped to the 2nd slay, which is slay animal (x2).

Actually no, because they're stored in reverse order, and there's one more slay than brand; so acid brand was using the slay animal multiplier.