Connected stairs option does not save

[calris]

Playing the latest Traps branch (i.e. with Rune ID) I notice the 'Generate Connected Stairs' option keeps resetting to 'Yes' after saving

[t4nk]

Yeah, I'm playing master and I noticed that too. That's because the string "birth_connect_stairs" is 20 bytes long (not counting the terminating null byte). But the options loader (rd_options() in load.c) has only 20 byte buffer (lines 396-406):

    while (1) {
        byte value;
        char name[20];
        rd_string(name, sizeof name);

        if (!name[0])
            break;

        rd_byte(&value);
        option_set(name, !!value);
    }

and rd_string() does (line 302 of savefile.c):

void rd_string(char *str, int max)
{
    ...
    str[max - 1] = '\0';
}

so name turns out to be "birth_connect_stair" (without "s" at the end).
I didn't find a ticket on trac.rephial.org; perhaps thats already fixed?

[Nick]

I didn't find a ticket on trac.rephial.org; perhaps thats already fixed?

You vastly overestimate how organised our ticketing is. Now fixed in development.