Savefile compatibility

[tumbleweed]

Thing is, this one has changed during the rewriting process, so it is no longer compatible with savefiles form early in the rewrite, and there is no nice system of tiered item readers to allow it to fail gracefully.

Yeah, fair enough.

Then again, I'd still call it "failing gracefully" if it at least told me to kindly fuck off with pre-230 (iirc) savefiles. But instead it just falls flat on its face with assertion failures and access violations.

[Derakon]

Yeah, fair enough.

Then again, I'd still call it "failing gracefully" if it at least told me to kindly fuck off with pre-230 (iirc) savefiles. But instead it just falls flat on its face with assertion failures and access violations.

Sounds like all that's really needed is to stick a version number in the header and error out if that version doesn't match the version of Angband currently running.

[Nick]

Then again, I'd still call it "failing gracefully" if it at least told me to kindly fuck off with pre-230 (iirc) savefiles. But instead it just falls flat on its face with assertion failures and access violations.

Yes, I think assertion failure just from loading something invalid is a bit rude. I'll fix that.

[AnonymousHero]

It's also good for me to see that sometimes it's Linux that makes my life more difficult rather that one of the other OSes

Hey! I'm sure I should feel insulted, but somehow I don't...?!? Dude?!?

[AnonymousHero]

Thanks. Without looking into the code, and I'm hopeless at reading C, I wouldn't have known that.

I don't mean to (metaphorically) apply a trounce to anyone, so please do ask if you have any questions about coding (or otherwise). EDIT: ... and I also want to sell you the true awesome of programming in case you're not acquainted already.

[Carnivean]

I don't mean to (metaphorically) apply a trounce to anyone, so please do ask if you have any questions about coding (or otherwise). EDIT: ... and I also want to sell you the true awesome of programming in case you're not acquainted already.

I'm somewhat familiar with coding, even took classes in C 20 years ago. Nowadays I stick to SQL and VBA. Reading C hurts my head, so I avoid it where possible.

Sadly I know enough to be dangerous, but not enough to be useful. I don't mind getting an honest answer to a question, no matter how negative the answer might be, so don't feel like you were being dismissive.

[Timo Pietilä]

Can anyone provide me with a single good reason why savefile compatibility is desirable now?

In the past, the big reason was monster memory. That is now in a separate file.

If there is no such reason, then the plan would be that, for example: Angband 8.1.0 would be released; 8.1.1, 8.1.2, ... would all be savefile compatible (as changes in the third digit are just for fixes); then when 8.2.0 is released 8.1.x savefiles will (probably) not work in it.

If there are no gameplay changes then keep savefile compatibility, if there are then break it. The mid-game char might not be compatible with new version anyway if the game has gameplay changes.

That's how I see it. If that requires some conversion routine, then that's needed.

[Ingwe Ingweron]

If there are no gameplay changes then keep savefile compatibility, if there are then break it. The mid-game char might not be compatible with new version anyway if the game has gameplay changes.

That's how I see it. If that requires some conversion routine, then that's needed.

Why not just finish your game on the version you're playing before upgrading to the new version?

[Carnivean]

Why not just finish your game on the version you're playing before upgrading to the new version?

I'd say that's what he's suggesting. No point taking a mid-game character into what is essentially a different game.

[debo]

IMO if you try to load an incompatible savefile, angband should scrape the savefile for the character name, auto-download FAangband, and create a character of the same name in thrall mode. (Nightmare difficulty, if possible.)

[Timo Pietilä]

Why not just finish your game on the version you're playing before upgrading to the new version?

That can take a long time. 20 hours real time, half a hour max / day, 40 days for single char.