[3.5-dev] Possible crash on cavern levels

[PowerWyrm]

Since the removal of the in_bounds macros, I think it's possible to crash the game on cavern levels because the layout doesn't generate permanent walls outside of the cavern bounds.

See init_cavern():

/* Fill the edges with perma-rock, and rest with rock */
draw_rectangle(c, 0, 0, DUNGEON_HGT - 1, DUNGEON_WID - 1, FEAT_PERM_SOLID);
fill_rectangle(c, 1, 1, DUNGEON_HGT - 2, DUNGEON_WID - 2, FEAT_WALL_SOLID);

compared to the same code for the town:

/* Start with solid walls, and then create some floor in the middle */
fill_rectangle(c, 0, 0, DUNGEON_HGT - 1, DUNGEON_WID - 1, FEAT_PERM_SOLID);
fill_rectangle(c, 1, 1, c->height -2, c->width - 2, FEAT_FLOOR);

[PowerWyrm]

The best would be to ensure that everything outside cave bounds is FEAT_PERM_SOLID, so that nothing can be placed there.

[eMeM]

I'm playing current dev version and there is a display problem on cavern levels

[scud]

You've somehow managed to access the top secret multi-player mode.

Shhhh. Tell no-one.

[Nick]

I'm playing current dev version and there is a display problem on cavern levels

Yep, I've found that bug too. Refreshing the screen fixes it.

[eMeM]

Multiplayer on maze level