[3.4-RC] Dropping items in the dark

[PowerWyrm]

Found this while playtesting my variant, and reproduced it with the latest 3.4-RC:
- when you drop an item on the ground in the dark (you can do that by removing your light source and walking on a dark tile), it simply disappears
- if you walk on the item while having a similar item in the inventory and the pickup_inven option is on, you manage to combine the items
- if you walk on the item and it's not similar to something you have in the inventory, nothing happens at all: no message (when you're blind, but carry a light source, you get a "You feel..." message), and pressing "g" doesn't initiate pickup... it's just like the item has been squelched

I re-downloaded 3.3 and 3.2 to see if the same bug happens in these versions: the problem happens in 3.3, but not in 3.2 (you get a message and can get the item while in the dark). Clearly a regression...

[dos350]

wow

massive vouch

atleast some1 here is trying,

siz 4 all others

[CynicK]

wow legit ideas, we need more like them!~

[Philip]

Look, everyone, dos's sock puppet is back! Let us all welcome him back with an ignore.
EDIT: It's not like we can't read what he says in dos's posts.

[PowerWyrm]

In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...

[Magnate]

In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...

It sounds like it, from the bug you've observed. Reported as #1665.