Stat/exp increase doesn't update current HP/SP

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2986

    Stat/exp increase doesn't update current HP/SP

    This sounds like a bug to me...

    For example, let's say a character is fully healed at 100/100 HPs. Then I find a ring of constitution +3 and equip it. Now the character has 100/120HPs, as if it had been injured in the process...

    Same thing happens when you increase your INT/WIS for SP, or when you gain a level for both HP and SP.

    When did this behavior change? And why? I remember clearly that you used to have HP/SP adjusted when you raised INT/WIS/CON or gained a level before...
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
  • Derakon
    Prophet
    • Dec 2009
    • 9022

    #2
    Your memories must be of a variant, because Vanilla has always been like this. I'm not saying it's right, might you. It would be straightforward to update your current HP/SP so that the ratio of current:max was maintained.

    Comment

    • fizzix
      Prophet
      • Aug 2009
      • 3025

      #3
      Originally posted by Derakon
      Your memories must be of a variant, because Vanilla has always been like this. I'm not saying it's right, might you. It would be straightforward to update your current HP/SP so that the ratio of current:max was maintained.
      I love that moment of fear when you kill something OoD clevel 1 and all the sudden you get a low hitpoint warning because your HP tripled.

      Comment

      • Raxmei
        Apprentice
        • Feb 2011
        • 94

        #4
        Angband's been like that for as long as I can remember. Adom does increase currrent HP when you level. I can't count the number of times levelling up has saved the life of a character in a tight spot in that game. If Angband did change that would reduce the annoyance factor of using certain swap equipment but that's about all that I'd really notice.

        Comment

        • camlost
          Sangband 1.x Maintainer
          • Apr 2007
          • 523

          #5
          Sangband scales HP/SP now. But it's not standard Angband practice.
          a chunk of Bronze {These look tastier than they are. !E}
          3 blank Parchments (Vellum) {No french novels please.}

          Comment

          • PowerWyrm
            Prophet
            • Apr 2008
            • 2986

            #6
            Alright... diving into the source, I found traces of code dealing with maintaining current HP/max HP ratio (and current SP/max SP ratio). The system was changed... in Angband 2.8.1! From the change list:

            •The player's current mana/hitpoints are no longer adjusted when the maximum mana/hitpoints change, except to enforce maximum limits. Among other things, gaining a level no longer raises the player's current mana/hitpoints immediately. This prevents some bizarre implications of the old adjustment semantics
            I guess it was easier to remove the feature than to fix it...
            PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

            Comment

            Working...
            😀
            😂
            🥰
            😘
            🤢
            😎
            😞
            😡
            👍
            👎