Using bad items offensively?

[Netbrian]

If you could provide a diff (or series of commits) where you did this, or even a patch for V (if you had time) I would be extremely grateful. I've wanted to do something exactly like what you've done but never found the time/energy/inclination.

I will be interested to hear how this works for you, and will be sure to let you know if I get anything working.

I'd love to see this. Regardless of what is done with bad potions, I'd really appreciate seeing enemy status effects approved. Maybe then Bedlam won't be such a letdown.

[d_m]

Is there any particular version of the Angband source you would want me to start with (Ang 3.2, the nightlies, one of your branches?) as the basis for a patch?

I would love to get a patch against angband/master on github, but 3.2 would be fine also. Thanks!

[nppangband]

I would love to get a patch against angband/master on github, but 3.2 would be fine also. Thanks!

Will do. I am trying to get a NPP 0.5.1 release candidate out today, then I will get started on this. I should have it done in a couple days.

[nppangband]

Done. The patch is available here:

http://download.nppangband.org/Angband_messages.patch

(D_m - I also e-mailed you a copy, along with a good savefile for testing).

* This patch changes two things.
- The first is centralizing the increase and decrease of temporary
monster effects into one place. It handles checking for resistances,
setting, increasing, decreasing, and clearing these temporary effects, as
well as monsters getting slowed and hasted. It can also optionally print
out the messages. This allows for slightly cleaner code and eliminates alot
of duplication, and puts in a single place the chances for the monster
resisting a temporary effect
- The second thing it does is count, store and flush monster pain, damage and recovery messages only once. This means if you take your priest inside a troll pit and start casting dispel evil you will no longer get a couple hundred redundant messages, instead you will get "18 troll priests shudder in pain, 23 trolls are destroyed, 11 trolls scream in agony"...etc.

[Nick]

Yoink! Thank you, Jeff

[will_asher]

I'd like to use this for DaJAngband. How can I get this (or convert this) to a more readable format?

[Nick]

Opening it in a file differencing tool is probably what you want. I haven't tried it, but WinMerge looks like a good one for Windows.

[nppangband]

It should be just a simple text file ready to patch into the current Angband master. But I get an unreadable html document from the link. I will re-upload it.

I can also e-mail it to you if you want.

EDIT:

Not sure how the file got changed. This link should be a simple zip file with a single patch (txt) file.

http://download.nppangband.org/Angband_patch.zip

[d_m]

Jeff, thanks so much!

We are currently assimilating your patch into V... through an unfortunate coincidence CunningGabe modified some of the same areas, so it may take a little time for us to get it all in... but it looks great, and I'm excited that I will probably hit the spacebar 80% less while playing Angband (and that we'll get better monster status effects, of course)!

[nppangband]

You are welcome. I am always happy to help out any time.

I do believe there is one major mistake throughout the patch. I am not too familiar with the new Angband monster race flags or how they work. I think there are a a dozen or so places in the patch with lines like this:

if ((rf_has(r_ptr->flags, RSF_BR_SOUN))

shouldn't those be:

(rsf_has(r_ptr->spell_flags, RSF_BR_WALL))) )

I beleive that every line of code in the patch that contains "RSF_BR" needs to be checked and in places where we are checking monster breaths for resistances. I am also wondering if I marked the monster lore properly. I have a feeling it changed and I didn't do it right.

[will_asher]

Thanks I can read it now. And I'll have to do a good bit of changing to adapt it to the DAJ code anyway.

[nppangband]

Thanks I can read it now. And I'll have to do a good bit of changing to adapt it to the DAJ code anyway.

Which version of Angband is DAJ based upon? The combined monster messages have been in NPP for a while, so there might be a version that would fit smoothly into your variant.

[will_asher]

Which version of Angband is DAJ based upon? The combined monster messages have been in NPP for a while, so there might be a version that would fit smoothly into your variant.

It's based on Angband 3.0.9