quiver improvement patch

[d_m]

So, after playing with the quiver for awhile, I decided to try to make it nicer/easier to use. So I went ahead and implemented the suggestion to make picked up ammo always go in the quiver.

This is really convenient in a lot of ways... when your pack is full but you have room for 20 arrows in your quiver, you can buy the arrows at the store and have them automatically go there (currently you have to drop something first). It's also nice when playing with auto-pickup.

The one drawback (and the reason I haven't committed to SVN yet) is that any ammo you want to carry has to be carried in the quiver. This can be a drag if you have lots of different kinds. It also means that those Slay Evil bolts you found have to stay in the quiver even though you're using arrows.

I'm attaching it as a patch--for those who can compile their own Angband I'd appreciate feedback. I've been playing with it today and it seems like a net win for my Hobbit Warrior so far.

[Timo Pietilä]

So, after playing with the quiver for awhile, I decided to try to make it nicer/easier to use. So I went ahead and implemented the suggestion to make picked up ammo always go in the quiver.

This is really convenient in a lot of ways... when your pack is full but you have room for 20 arrows in your quiver, you can buy the arrows at the store and have them automatically go there (currently you have to drop something first). It's also nice when playing with auto-pickup.

The one drawback (and the reason I haven't committed to SVN yet) is that any ammo you want to carry has to be carried in the quiver. This can be a drag if you have lots of different kinds. It also means that those Slay Evil bolts you found have to stay in the quiver even though you're using arrows.

I'm attaching it as a patch--for those who can compile their own Angband I'd appreciate feedback. I've been playing with it today and it seems like a net win for my Hobbit Warrior so far.

I'm not sure those drawbacks are worth the patch. what happens when you "take off" ammunition? Does it then go to inventory? What happens when your quiver "overflows" to another letter? Do it still make you drop that extremely valuable whatever you had in letter "v" in your inventory?

Also the fact that I might want to store those excellent holy might arrows in my home but I am using xbow could be too problematic. It makes quiver unusable if it offers wrong type of the ammo as "F0" ammo and you have macros to shoot whatever you have in that slot. That requires sorting and that is currently done by inscriptions that force the ammo to take some slot and not go anywhere else (something like "preferred order" would be better).

Can you make a patch that picks up arrows with some inscription directly to quiver instead?

EDIT: =e instead of =g perhaps? That inscription could then be useful to "pick up" dropped gear too.

I also think that quiver should only allow 99 items, no more, so that "quiver overflow" never happens.

[PowerDiver]

I'm trying it out. I'll work on better ammo sorting as I go.

It is disconcerting to use the takeoff command, select ammo without error, and have nothing happen. Presumably that should be disabled.

If I try to pickup ammo with a full pack, I cannot even if there is room in the quiver, but I can wield it directly.

What are you doing about cursed ammo? Options include ignore the curse when dropping. I sent you a patch a week or two ago because remove curse did not work on ammo in the quiver. If ammo is auto-wielded something needs to be done. It is possible you fixed this already, as I haven't tested, but I didn't notice the change when I glanced at the patch.

[d_m]

I'm trying it out. I'll work on better ammo sorting as I go.

Thanks!

It is disconcerting to use the takeoff command, select ammo without error, and have nothing happen. Presumably that should be disabled.

Agreed. I just wanted to get the basic patch working before going through the trouble of getting that working.

If I try to pickup ammo with a full pack, I cannot even if there is room in the quiver, but I can wield it directly.

Huh. I thought I tested that but apparently not. I will try to reproduce.

What are you doing about cursed ammo? Options include ignore the curse when dropping. I sent you a patch a week or two ago because remove curse did not work on ammo in the quiver. If ammo is auto-wielded something needs to be done. It is possible you fixed this already, as I haven't tested, but I didn't notice the change when I glanced at the patch.

I think I either missed your email or lost it or something--I have no memory of getting that. Sorry. Can you resend it?

Cursed ammunition doesn't work very well currently; I think at one point there was talk about dropping curses for ammo. Anyway, I am happy to commit patches that fix the remove curse behavior.

[PowerDiver]

I think I either missed your email or lost it or something--I have no memory of getting that. Sorry. Can you resend it?

It's just missing ALL_INVEN_TOTAL in remove_curse.

[d_m]

It's just missing ALL_INVEN_TOTAL in remove_curse.

Fixed in HEAD as of r1996.