Possible bug in latest version

[TJS]

I've got a defender equipped which appears to have been identified, but in the shift+c then h character screen it has question marks for most of the fields. I still can't identify it though.

By the way, how to you find the number for the version you're currently using?

[Magnate]

I've got a defender equipped which appears to have been identified, but in the shift+c then h character screen it has question marks for most of the fields. I still can't identify it though.

Defenders have a LOT of attributes. It won't fully ID until every last one has been noted - including slow digestion, feather fall, etc. etc. If you're still convinced it's a bug, please post a savefile.

By the way, how to you find the number for the version you're currently using?

Good question. I'll get back to you on that. I thought it was supposed to appear in dumps, but they just say 3.1.2dev.

[NeoWizard]

By the way, how to you find the number for the version you're currently using?

press shift+v

[TJS]

press shift+v

Ah right thanks.

Defenders have a LOT of attributes. It won't fully ID until every last one has been noted - including slow digestion, feather fall, etc. etc. If you're still convinced it's a bug, please post a savefile.Good question. I'll get back to you on that. I thought it was supposed to appear in dumps, but they just say 3.1.2dev.

Actually it is happening after it has been identified by the game as a defender and it won't let me use a scroll of id on it, but it is still missing a lot of the fields and only gets them as I discover by use.

In fact it seems to be the case with a few of my items. I'll post a savefile when I get back onto my main PC.

[TJS]

I've got the offending save here.

[Magnate]

I've got the offending save here.

Ok, you have not IDd the Feather Fall attribute. The bug is in not letting you use a scroll on it - it should still be saying "You do not know the full extent of this item's powers". I'll have a look and see if FEATHER is special-cased in identify.c

EDIT: I've spent a while trying to reproduce this. I think I've found a bug with ID-by-use of See Invisible, but I can't reproduce this one ...

[TJS]

Ok, you have not IDd the Feather Fall attribute. The bug is in not letting you use a scroll on it - it should still be saying "You do not know the full extent of this item's powers". I'll have a look and see if FEATHER is special-cased in identify.c

It recognised it was a defender much earlier, I've just discovered all the other fields since then by use. Probably never found feather falling because I always detect traps. I had the same problem with a cloak of stealth that I threw away earlier.

It seems to recognise the ego type sometimes, but not reveal all its powers. Perhaps after I've seen the same ego in stores?

On a completely different subject, how do I put a character on the ladder and then paste the contents in here? I've tried a search, but no luck as yet.

[Magnate]

On a completely different subject, how do I put a character on the ladder and then paste the contents in here? I've tried a search, but no luck as yet.

Why would you want to do that? Just post a link to the ladder record!

[TJS]

Why would you want to do that? Just post a link to the ladder record!

Dunno I thought that is what people did. How do I dump the character and add it to the ladder?

[Timo Pietilä]

OT signature

------
aoccdrnig to a rscheearch at Cmabrigde Uinervtisy, it dseno't mtaetr in waht oerdr the ltteres in a wrod are, the olny iproamtnt tihng is taht the frsit and lsat ltteer be in the rghit pclae. Tihs is bcuseae the huamn mnid deos not raed ervey lteter by istlef, but the wrod as a wlohe. fi yuo cna raed tihs, palce it in yuor siantugre. Olny 55% of plepoe can.

Really? I can read that just fine, and I'm not even native English reader. I bet that number is higher than 55%.

[Magnate]

Dunno I thought that is what people did. How do I dump the character and add it to the ladder?

Take a chardump (C then f). Click on the Ladder tab (next to the Forum tab). Upload the file you just dumped.

P.S. I can't reproduce your bug. I created a Defender, IDd all the flags except FF and rElec, and eventually it self-IDd, including both those attributes. If you come across another instance of an item IDing-by-use but still showing ?s in the char details screen, please post the save in this thread immediately, so that I can check recent messages. Thanks.

[PowerDiver]

The problem is presumably that somehow the IDENT_KNOWN flag got set incorrectly. Once that happens, you cannot ?id any more. It can happen when you migrate savefiles across different revisions if anything changes with IDENT structures in between. It can also happen if there are bugs.

I submitted a patch [including an admittedly gross hack] that I thought was the best way to deal with inconsistent IDENT stuff, but it was either just before Tak went on break or he thought auto-fixing the problem would make it harder to find bugs, or maybe both. I think I also asked d_m to consider committing it.

I understand their reservations. My solution was far from perfect, but I think the problem requires a nasty solution. Objects that are treated as const need to be modified when you notice inconsistencies, and that causes a mess on way or another.

[d_m]

I submitted a patch [including an admittedly gross hack] that I thought was the best way to deal with inconsistent IDENT stuff, but it was either just before Tak went on break or he thought auto-fixing the problem would make it harder to find bugs, or maybe both. I think I also asked d_m to consider committing it.

I understand their reservations. My solution was far from perfect, but I think the problem requires a nasty solution. Objects that are treated as const need to be modified when you notice inconsistencies, and that causes a mess on way or another.

I wouldn't say I thought your code had problems so much as I wasn't sure I understood it

Anyway, I'll take another look at it now; if I still don't understand it I'll send Magnate the patch.

[TJS]

Take a chardump (C then f). Click on the Ladder tab (next to the Forum tab). Upload the file you just dumped.

P.S. I can't reproduce your bug. I created a Defender, IDd all the flags except FF and rElec, and eventually it self-IDd, including both those attributes. If you come across another instance of an item IDing-by-use but still showing ?s in the char details screen, please post the save in this thread immediately, so that I can check recent messages. Thanks.

I think to reproduce the error you need to make an ego that becomes known on wielding and then wield it.

It has just happened again, here is the save.

[Magnate]

I think to reproduce the error you need to make an ego that becomes known on wielding and then wield it.

What ego becomes known on wielding? They become {splendid} if they have any obvious mods, but not fully known until you sense or ID-by-use all the flags. If something is IDing on wield, something is wrong.

I'll take a look at the save.