possible bug in r1762

[shawnosullivan]

when i try to start a new game using a file i've already created a character on, the program crashes. this seems to only occur if i have random artifacts enabled.
im running vista, so that could well be the problem :-P

[Magnate]

when i try to start a new game using a file i've already created a character on, the program crashes. this seems to only occur if i have random artifacts enabled.
im running vista, so that could well be the problem :-P

Please provide the savefile for testing.

[PowerDiver]

Wasn't there a bug loading savefiles with randarts, fairly recently, perhaps in 3.1.0? Or maybe it was the next char after a randart guy died. I never knew what the bug was, but perhaps someone could check if it creeped back in.

[Magnate]

Wasn't there a bug loading savefiles with randarts, fairly recently, perhaps in 3.1.0? Or maybe it was the next char after a randart guy died. I never knew what the bug was, but perhaps someone could check if it creeped back in.

The bug I think you're talking about was the random names given to standard artifacts, if you switched *back* to non-randarts after a randart game. That's been fixed, and is not the problem the OP is having. I have not had any bug reports about randart games not loading at all since 3.1.1 broke savefiles. I am assuming that the OP is not using an old savefile ...

[shawnosullivan]

here's a file. it's happened with several characters in 1762 - i don't recall it being an issue in 3.1.1 or the other nightlies i've downloaded.

[Magnate]

here's a file. it's happened with several characters in 1762 - i don't recall it being an issue in 3.1.1 or the other nightlies i've downloaded.

Is that save file supposed to contain a live character? I can load it fine, but it puts me at the birth screen and offers to create a new character called Annarri. If the character was alive, this is a serious problem! If not, I don't know what the problem is. (I can't test on Windows, so grateful if someone else could.)

[Marble Dice]

Doesn't contain a live character, just start a new one using this file and sometimes it will crash. First time it didn't crash for me, but I suicided on a merc and started again for a crash. I put the savefile up on #1009, would a randart.log help do you think?

[shawnosullivan]

no, the character was dead.
thats the issue - when i try to create a new character using that file, it asks me if i'd like to use the same stats as the old character. if i press "y", it crashes (or just freezes entirely) every time, i've tried probably 20-30 times.
i can create a character initially just fine, naturally

[Magnate]

no, the character was dead.
thats the issue - when i try to create a new character using that file, it asks me if i'd like to use the same stats as the old character. if i press "y", it crashes (or just freezes entirely) every time, i've tried probably 20-30 times.
i can create a character initially just fine, naturally

Ok, I think the reason it's crashing for you is that it's using the same random seed and hitting the same problem in randart generation. Please zip and attach your randart.log file from immediately after a crash.

Thanks to Marble Dice for the second opinion - I presume the random seed is treated differently on different machines - I can't get it to crash at all. MD - if you could post a randart.log from after a crash too, that would help me cross-reference. I recently changed the base item selection logic, and I had to take out a couple of special cases (Grond, Morgoth and the special artifacts all have special base items) - looks like I missed one.

[shawnosullivan]

is this the correct randart file?

http://rapidshare.com/files/312154033/randart.zip.html

[Magnate]

is this the correct randart file?
http://rapidshare.com/files/312154033/randart.zip.html

I don't know. It says I can only download it by becoming a premium user??

EDIT: No worries, I looked at Marble Dice's log attached to the ticket on trac.rephial.org and I think I may have found the problem. Please try r1768 with the *same* savefile and let me know if you still get the crash.

[Marble Dice]

It works for me, using that same affected savefile. High five!

[shawnosullivan]

yup! works a-ok on this end too

[Magnate]

yup! works a-ok on this end too

Thanks both for the tests. I hadn't realised that randint1(x) went all the way to x. I knew that randint0(x) maxes at x-1, and assumed the same was true. Doh!